Attachment 155257 Details for Bug 92627 – Patch

[patch] Patch

bug-92627-20120730134256.patch (text/plain), 1.61 KB, created by Balazs Kelemen on 2012-07-30 04:43:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Balazs Kelemen

Created: 2012-07-30 04:43:26 PDT

Size: 1.61 KB

patch

obsolete

>Subversion Revision: 124014
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index cd8ed791176c3908c240a3d7d30295a4837ea35c..7a0e539e3efa7d653a602f401f81a0a200e9d696 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2012-07-30  Balazs Kelemen  <kbalazs@webkit.org>
>+
>+        [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
>+        https://bugs.webkit.org/show_bug.cgi?id=92627
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove the default behavior I added in r123729 so that we run all tests as pixel
>+        test with -p. It was intentional but it seems like we don't have consensus on
>+        that we want it.
>+
>+        * Scripts/webkitpy/layout_tests/port/qt.py:
>+        (QtPort._supports_switching_pixel_tests_per_test):
>+
> 2012-07-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
> 
>         [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
>diff --git a/Tools/Scripts/webkitpy/layout_tests/port/qt.py b/Tools/Scripts/webkitpy/layout_tests/port/qt.py
>index 392ab028fea407a436556ef291f917913b667881..e239c7e3aaf6f602b0c351ec22dcfa68064ea269 100644
>--- a/Tools/Scripts/webkitpy/layout_tests/port/qt.py
>+++ b/Tools/Scripts/webkitpy/layout_tests/port/qt.py
>@@ -187,10 +187,3 @@ class QtPort(Port):
>     def _supports_switching_pixel_tests_per_test(self):
>         return True
> 
>-    def _should_run_as_pixel_test(self, test_input):
>-        return any(test_input.test_name.startswith(directory)
>-                   for directory in QtPort._default_pixel_test_directories())
>-
>-    @staticmethod
>-    def _default_pixel_test_directories():
>-        return ['compositing']

Actions: View | Formatted Diff | Diff

Attachments on bug 92627: 155257