Attachment 154724 Details for Bug 92414 – Patch

[patch] Patch

bug-92414-20120726125218.patch (text/plain), 2.97 KB, created by Joshua Bell on 2012-07-26 12:52:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joshua Bell

Created: 2012-07-26 12:52:29 PDT

Size: 2.97 KB

patch

obsolete

>Subversion Revision: 123656
>diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog
>index 27b552be4d81a2b3a6cfbb0dbc166053a8dd463e..0c89a9c666d91294444f007d54b70fe492a76c29 100644
>--- a/Source/WebKit/chromium/ChangeLog
>+++ b/Source/WebKit/chromium/ChangeLog
>@@ -1,3 +1,20 @@
>+2012-07-26  Joshua Bell  <jsbell@chromium.org>
>+
>+        [Chromium] IndexedDB: API stubs to simplify WebIDBCursor API
>+        https://bugs.webkit.org/show_bug.cgi?id=92414
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Prep work to unblock Chromium changes so that http://webkit.org/b/92278 can land.
>+        Adds no-op methods which will later be implemented; during the landing sequence,
>+        Chromium will call both the new methods and the old ones. The end goal is that
>+        the success callbacks for cursors will include the new key/primaryKey/value rather
>+        than requiring the callee to call back into the cursor backend to fetch them.
>+
>+        * public/WebIDBCallbacks.h:
>+        (WebIDBCallbacks):
>+        (WebKit::WebIDBCallbacks::onSuccess):
>+
> 2012-07-24  Shawn Singh  <shawnsingh@chromium.org>
> 
>         [chromium] Refactor CCLayerTreeHostCommon: move root layer special case initialization into internal code.
>diff --git a/Source/WebKit/chromium/public/WebIDBCallbacks.h b/Source/WebKit/chromium/public/WebIDBCallbacks.h
>index a63c0bc9ee6c4caf2d67d95e5d00a11c9fcd829d..c7272437bc4d72d07ecfcff819578adc1e56c4c0 100644
>--- a/Source/WebKit/chromium/public/WebIDBCallbacks.h
>+++ b/Source/WebKit/chromium/public/WebIDBCallbacks.h
>@@ -51,12 +51,16 @@ public:
>     virtual void onError(const WebIDBDatabaseError&) { WEBKIT_ASSERT_NOT_REACHED(); }
>     virtual void onSuccess(const WebDOMStringList&) { WEBKIT_ASSERT_NOT_REACHED(); }
>     virtual void onSuccess(WebIDBCursor*) { WEBKIT_ASSERT_NOT_REACHED(); }
>+    // FIXME: Temporary no-op method to allow callers to update before WK92278 lands.
>+    virtual void onSuccess(WebIDBCursor*, const WebIDBKey&, const WebIDBKey&, const WebSerializedScriptValue&) { }
>     virtual void onSuccess(WebIDBDatabase*) { WEBKIT_ASSERT_NOT_REACHED(); }
>     virtual void onSuccess(const WebIDBKey&) { WEBKIT_ASSERT_NOT_REACHED(); }
>     virtual void onSuccess(WebIDBTransaction*) { WEBKIT_ASSERT_NOT_REACHED(); }
>     virtual void onSuccess(const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
>     virtual void onSuccess(const WebSerializedScriptValue&, const WebIDBKey&, const WebIDBKeyPath&) { WEBKIT_ASSERT_NOT_REACHED(); }
>     virtual void onSuccessWithContinuation() { WEBKIT_ASSERT_NOT_REACHED(); }
>+    // FIXME: Temporary no-op method to allow callers to update before WK92278 lands.
>+    virtual void onSuccess(const WebIDBKey&, const WebIDBKey&, const WebSerializedScriptValue&) { }
>     virtual void onBlocked() { WEBKIT_ASSERT_NOT_REACHED(); }
>     virtual void onSuccessWithPrefetch(const WebVector<WebIDBKey>& keys, const WebVector<WebIDBKey>& primaryKeys, const WebVector<WebSerializedScriptValue>& values) { WEBKIT_ASSERT_NOT_REACHED(); }
> };

Actions: View | Formatted Diff | Diff

Attachments on bug 92414: 154724 | 154759 | 155869