Attachment 146185 Details for Bug 88489 – Patch 1

[patch] Patch 1

bug-88489-20120607125243.patch (text/plain), 2.28 KB, created by yosin on 2012-06-06 20:52:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: yosin

Created: 2012-06-06 20:52:43 PDT

Size: 2.28 KB

patch

obsolete

>Subversion Revision: 119657
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e29661fe7253943ecea816fbeaad056c2dafd215..ca0a2e75c886767dd02cc0a531fafc491704d9ec 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2012-06-06  Yoshifumi Inoue  <yosin@chromium.org>
>+
>+        [Forms] Improve test coverage of input-number-size.html
>+        https://bugs.webkit.org/show_bug.cgi?id=88489
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch improves test coverage for NumberInputType::sizeShouldIncludeDecoration()
>+        for preparation of introducing decimal arithmetic.
>+
>+        * fast/forms/number/input-number-size-expected.txt: Updated for a new test case.
>+        * fast/forms/number/input-number-size.html: Added a test case.
>+
> 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Revert erroneous change in r119637.
>diff --git a/LayoutTests/fast/forms/number/input-number-size-expected.txt b/LayoutTests/fast/forms/number/input-number-size-expected.txt
>index 90abb20684f774338b553851298d3b1b0a06b0b0..b2ba9c4e1a323d02815b175dd1df00d99f8e4f59 100644
>--- a/LayoutTests/fast/forms/number/input-number-size-expected.txt
>+++ b/LayoutTests/fast/forms/number/input-number-size-expected.txt
>@@ -77,6 +77,7 @@ PASS numberWidth(0.005, 1, 1) is textWidthPlusSpinButtonWidth(5)
> PASS numberWidth(1.5, 2, 1) is textWidthPlusSpinButtonWidth(3)
> PASS numberWidth(1.05, 2, 1) is textWidthPlusSpinButtonWidth(4)
> PASS numberWidth(1.005, 2, 1) is textWidthPlusSpinButtonWidth(5)
>+PASS numberWidth(123456, 123456, 0.0000005) is textWidthPlusSpinButtonWidth(14)
> 
> PASS successfullyParsed is true
> 
>diff --git a/LayoutTests/fast/forms/number/input-number-size.html b/LayoutTests/fast/forms/number/input-number-size.html
>index 3ab99ed814de29450dabab05a137127ff301bbfe..36031a9d4fe23fb58ef31d74fb640dd3ac4cf0d1 100644
>--- a/LayoutTests/fast/forms/number/input-number-size.html
>+++ b/LayoutTests/fast/forms/number/input-number-size.html
>@@ -149,6 +149,8 @@ shouldBe('numberWidth(1.5, 2, 1)', 'textWidthPlusSpinButtonWidth(3)');
> shouldBe('numberWidth(1.05, 2, 1)', 'textWidthPlusSpinButtonWidth(4)');
> shouldBe('numberWidth(1.005, 2, 1)', 'textWidthPlusSpinButtonWidth(5)');
> 
>+shouldBe('numberWidth(123456, 123456, 0.0000005)', 'textWidthPlusSpinButtonWidth(14)');
>+
> debug('')
> </script>
>

Actions: View | Formatted Diff | Diff

Attachments on bug 88489: 146185