Attachment 144137 Details for Bug 87531 – Patch

[patch] Patch

bug-87531-20120525161756.patch (text/plain), 3.88 KB, created by Mark Pilgrim (Google) on 2012-05-25 13:18:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Pilgrim (Google)

Created: 2012-05-25 13:18:25 PDT

Size: 3.88 KB

patch

obsolete

>Index: Source/Platform/ChangeLog
>===================================================================
>--- Source/Platform/ChangeLog	(revision 118554)
>+++ Source/Platform/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2012-05-25  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Move fileExists to Platform.h
>+        https://bugs.webkit.org/show_bug.cgi?id=87531
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part of a refactoring series. See tracking bug 82948.
>+
>+        * chromium/public/Platform.h:
>+        (WebKit::Platform::fileExists):
>+        (Platform):
>+
> 2012-05-17  Andrey Kosyakov  <caseq@chromium.org>
> 
>         [chromium] add instrumentation for compositing
>Index: Source/Platform/chromium/public/Platform.h
>===================================================================
>--- Source/Platform/chromium/public/Platform.h	(revision 118544)
>+++ Source/Platform/chromium/public/Platform.h	(working copy)
>@@ -102,6 +102,9 @@ public:
>     // Must return non-null.
>     virtual WebFileSystem* fileSystem() { return 0; }
> 
>+    virtual bool fileExists(const WebString&) { return false; }
>+
>+
>     // Gamepad -------------------------------------------------------------
> 
>     virtual void sampleGamepads(WebGamepads& into) { into.length = 0; }
>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 118554)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2012-05-25  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Move fileExists to Platform.h
>+        https://bugs.webkit.org/show_bug.cgi?id=87531
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part of a refactoring series. See tracking bug 82948.
>+
>+        * platform/chromium/FileSystemChromium.cpp:
>+        (WebCore::fileExists):
>+
> 2012-05-25  Dean Jackson  <dino@apple.com>
> 
>         Unreviewed, rolling out r112155.
>Index: Source/WebCore/platform/chromium/FileSystemChromium.cpp
>===================================================================
>--- Source/WebCore/platform/chromium/FileSystemChromium.cpp	(revision 118544)
>+++ Source/WebCore/platform/chromium/FileSystemChromium.cpp	(working copy)
>@@ -36,6 +36,8 @@
> #include "PlatformString.h"
> #include "PlatformSupport.h"
> 
>+#include <public/Platform.h>
>+
> namespace WebCore {
> 
> bool deleteFile(const String& path)
>@@ -88,7 +90,7 @@ bool makeAllDirectories(const String& pa
> 
> bool fileExists(const String& path)
> {
>-    return PlatformSupport::fileExists(path);
>+    return WebKit::Platform::current()->fileExists(path);
> }
> 
> PlatformFileHandle openFile(const String& path, FileOpenMode mode)
>Index: Source/WebKit/chromium/ChangeLog
>===================================================================
>--- Source/WebKit/chromium/ChangeLog	(revision 118554)
>+++ Source/WebKit/chromium/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2012-05-25  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Move fileExists to Platform.h
>+        https://bugs.webkit.org/show_bug.cgi?id=87531
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part of a refactoring series. See tracking bug 82948.
>+
>+        * src/PlatformSupport.cpp:
>+        (WebCore):
>+
> 2012-05-25  Kinuko Yasuda  <kinuko@chromium.org>
> 
>         Unreviewed; rolling chromium deps.
>Index: Source/WebKit/chromium/src/PlatformSupport.cpp
>===================================================================
>--- Source/WebKit/chromium/src/PlatformSupport.cpp	(revision 118544)
>+++ Source/WebKit/chromium/src/PlatformSupport.cpp	(working copy)
>@@ -302,11 +302,6 @@ bool PlatformSupport::cookiesEnabled(con
> 
> // File ------------------------------------------------------------------------
> 
>-bool PlatformSupport::fileExists(const String& path)
>-{
>-    return WebKit::Platform::current()->fileUtilities()->fileExists(path);
>-}
>-
> bool PlatformSupport::deleteFile(const String& path)
> {
>     return WebKit::Platform::current()->fileUtilities()->deleteFile(path);

Actions: View | Formatted Diff | Diff

Attachments on bug 87531: 144135 | 144137 | 144601 | 144682