WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-86981-20120521112926.patch (text/plain), 23.39 KB, created by
Kentaro Hara
on 2012-05-20 19:29:27 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Kentaro Hara
Created:
2012-05-20 19:29:27 PDT
Size:
23.39 KB
patch
obsolete
>Subversion Revision: 117718 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 16bea4afbd1ef8d166f66355bfe02b47aec32858..1e2faa618db206b7a15f1d6975438e7d9b8cf758 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,54 @@ >+2012-05-20 Kentaro Hara <haraken@chromium.org> >+ >+ [V8] Pass Isolate to throwError()s in V8 custom bindings (Part 2) >+ https://bugs.webkit.org/show_bug.cgi?id=86981 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The objective is to pass Isolate around in V8 bindings. >+ This patch passes Isolate to throwError()s in V8 custom bindings. >+ >+ No tests. No change in behavior. >+ >+ * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: >+ (WebCore::v8HTMLImageElementConstructorCallback): >+ * bindings/v8/custom/V8HistoryCustom.cpp: >+ (WebCore::V8History::pushStateCallback): >+ (WebCore::V8History::replaceStateCallback): >+ * bindings/v8/custom/V8IntentConstructor.cpp: >+ (WebCore::V8Intent::constructorCallback): >+ * bindings/v8/custom/V8MessagePortCustom.cpp: >+ (WebCore::handlePostMessageCallback): >+ * bindings/v8/custom/V8NotificationCenterCustom.cpp: >+ (WebCore::V8NotificationCenter::createHTMLNotificationCallback): >+ (WebCore::V8NotificationCenter::createNotificationCallback): >+ (WebCore::V8NotificationCenter::requestPermissionCallback): >+ * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: >+ (WebCore::V8SQLResultSetRowList::itemCallback): >+ * bindings/v8/custom/V8SQLTransactionCustom.cpp: >+ (WebCore::V8SQLTransaction::executeSqlCallback): >+ * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp: >+ (WebCore::V8SQLTransactionSync::executeSqlCallback): >+ * bindings/v8/custom/V8StorageCustom.cpp: >+ (WebCore::storageSetter): >+ * bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: >+ (WebCore::V8WebKitMutationObserver::constructorCallback): >+ (WebCore::V8WebKitMutationObserver::observeCallback): >+ * bindings/v8/custom/V8WebSocketCustom.cpp: >+ (WebCore::V8WebSocket::constructorCallback): >+ (WebCore::V8WebSocket::sendCallback): >+ (WebCore::V8WebSocket::closeCallback): >+ * bindings/v8/custom/V8WorkerContextCustom.cpp: >+ (WebCore::V8WorkerContext::importScriptsCallback): >+ * bindings/v8/custom/V8WorkerCustom.cpp: >+ (WebCore::handlePostMessageCallback): >+ * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: >+ (WebCore::V8XMLHttpRequest::constructorCallback): >+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: >+ (WebCore::V8XMLHttpRequest::responseTextAccessorGetter): >+ (WebCore::V8XMLHttpRequest::openCallback): >+ (WebCore::V8XMLHttpRequest::sendCallback): >+ > 2012-05-20 George Staikos <staikos@webkit.org> > > Use reinterpret_cast_ptr<> to fix an alignment warning. >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp >index 513b506cd0aecb16eb0dc90a152fa367c04b952f..571e443a2ff4025fc4df9092500baacf0755d87d 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp >@@ -58,11 +58,11 @@ static v8::Handle<v8::Value> v8HTMLImageElementConstructorCallback(const v8::Arg > > Frame* frame = V8Proxy::retrieveFrameForCurrentContext(); > if (!frame) >- return V8Proxy::throwError(V8Proxy::ReferenceError, "Image constructor associated frame is unavailable"); >+ return V8Proxy::throwError(V8Proxy::ReferenceError, "Image constructor associated frame is unavailable", args.GetIsolate()); > > Document* document = frame->document(); > if (!document) >- return V8Proxy::throwError(V8Proxy::ReferenceError, "Image constructor associated document is unavailable"); >+ return V8Proxy::throwError(V8Proxy::ReferenceError, "Image constructor associated document is unavailable", args.GetIsolate()); > > // Make sure the document is added to the DOM Node map. Otherwise, the HTMLImageElement instance > // may end up being the only node in the map and get garbage-ccollected prematurely. >diff --git a/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp >index 944368277284fbd988f52b6d3e60a11cbde5b841..4e30db514ba173de266e25f94f24656f2ed598dc 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp >@@ -81,7 +81,7 @@ v8::Handle<v8::Value> V8History::pushStateCallback(const v8::Arguments& args) > History* history = V8History::toNative(args.Holder()); > history->stateObjectAdded(historyState.release(), title, url, History::StateObjectPush, ec); > args.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state()); >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > } > > v8::Handle<v8::Value> V8History::replaceStateCallback(const v8::Arguments& args) >@@ -106,7 +106,7 @@ v8::Handle<v8::Value> V8History::replaceStateCallback(const v8::Arguments& args) > History* history = V8History::toNative(args.Holder()); > history->stateObjectAdded(historyState.release(), title, url, History::StateObjectReplace, ec); > args.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state()); >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > } > > bool V8History::indexedSecurityCheck(v8::Local<v8::Object> host, uint32_t index, v8::AccessType type, v8::Local<v8::Value>) >diff --git a/Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp b/Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp >index 28fa21e3b017c717587fd4e9caabbf3910e5484e..53abdfdbca4242e2c34cd3f1602bed340f245a35 100644 >--- a/Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp >@@ -61,7 +61,7 @@ v8::Handle<v8::Value> V8Intent::constructorCallback(const v8::Arguments& args) > ExceptionCode ec = 0; > RefPtr<Intent> impl = Intent::create(ScriptState::current(), options, ec); > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > v8::Handle<v8::Object> wrapper = args.Holder(); > V8DOMWrapper::setDOMWrapper(wrapper, &info, impl.get()); >@@ -81,11 +81,11 @@ v8::Handle<v8::Value> V8Intent::constructorCallback(const v8::Arguments& args) > bool dataDidThrow = false; > RefPtr<SerializedScriptValue> data = SerializedScriptValue::create(args[2], &messagePortArrayTransferList, &arrayBufferArrayTransferList, dataDidThrow); > if (dataDidThrow) >- return throwError(DATA_CLONE_ERR); >+ return throwError(DATA_CLONE_ERR, args.GetIsolate()); > > RefPtr<Intent> impl = Intent::create(action, type, data, messagePortArrayTransferList, ec); > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > v8::Handle<v8::Object> wrapper = args.Holder(); > V8DOMWrapper::setDOMWrapper(wrapper, &info, impl.get()); >diff --git a/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp b/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp >index ee7d16caff90e80d84399d08c6425aa05806097d..bdccafcc05392987f59fe89bf9018c5b2f15ff41 100644 >--- a/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp >@@ -62,7 +62,7 @@ static v8::Handle<v8::Value> handlePostMessageCallback(const v8::Arguments& args > return v8::Undefined(); > ExceptionCode ec = 0; > messagePort->postMessage(message.release(), &portArray, ec); >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > } > > v8::Handle<v8::Value> V8MessagePort::postMessageCallback(const v8::Arguments& args) >diff --git a/Source/WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp b/Source/WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp >index 4ca198c7ebb56bfbd6f22cf4f7ab1157318e08c5..109aaf90edb4e1fc99ecf22f0938cafb0c8e18ab 100644 >--- a/Source/WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp >@@ -57,7 +57,7 @@ v8::Handle<v8::Value> V8NotificationCenter::createHTMLNotificationCallback(const > RefPtr<Notification> notification = notificationCenter->createHTMLNotification(url, ec); > > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > notification->ref(); > return toV8(notification.get(), args.GetIsolate()); >@@ -72,7 +72,7 @@ v8::Handle<v8::Value> V8NotificationCenter::createNotificationCallback(const v8: > RefPtr<Notification> notification = notificationCenter->createNotification(toWebCoreString(args[0]), toWebCoreString(args[1]), toWebCoreString(args[2]), ec); > > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > notification->ref(); > return toV8(notification.get(), args.GetIsolate()); >@@ -86,11 +86,11 @@ v8::Handle<v8::Value> V8NotificationCenter::requestPermissionCallback(const v8:: > > // Make sure that script execution context is valid. > if (!context) >- return throwError(INVALID_STATE_ERR); >+ return throwError(INVALID_STATE_ERR, args.GetIsolate()); > > // Requesting permission is only valid from a page context. > if (context->isWorkerContext()) >- return throwError(NOT_SUPPORTED_ERR); >+ return throwError(NOT_SUPPORTED_ERR, args.GetIsolate()); > > RefPtr<V8CustomVoidCallback> callback; > if (args.Length() > 0) { >diff --git a/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp b/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp >index 722aa3577a334fe8f08de24398824d831311e2cb..f7936ec663d50043cc22c2016126616796fb551a 100644 >--- a/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp >@@ -44,7 +44,7 @@ v8::Handle<v8::Value> V8SQLResultSetRowList::itemCallback(const v8::Arguments& a > INC_STATS("DOM.SQLResultSetRowList.item()"); > > if (args.Length() == 0) { >- V8Proxy::throwError(V8Proxy::SyntaxError, "Item index is required."); >+ V8Proxy::throwError(V8Proxy::SyntaxError, "Item index is required.", args.GetIsolate()); > return v8::Undefined(); > } > >@@ -57,7 +57,7 @@ v8::Handle<v8::Value> V8SQLResultSetRowList::itemCallback(const v8::Arguments& a > > unsigned long index = args[0]->IntegerValue(); > if (index >= rowList->length()) { >- V8Proxy::throwError(V8Proxy::RangeError, "Item index is out of range."); >+ V8Proxy::throwError(V8Proxy::RangeError, "Item index is out of range.", args.GetIsolate()); > return v8::Undefined(); > } > >diff --git a/Source/WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp b/Source/WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp >index f8520f01ead098b266e43f0842733e39b6afd2b1..71c4f3bd34ba6fa2e231bd5e20afaf19e7ca276a 100644 >--- a/Source/WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp >@@ -53,7 +53,7 @@ v8::Handle<v8::Value> V8SQLTransaction::executeSqlCallback(const v8::Arguments& > INC_STATS("DOM.SQLTransaction.executeSql()"); > > if (args.Length() == 0) >- return throwError(SYNTAX_ERR); >+ return throwError(SYNTAX_ERR, args.GetIsolate()); > > STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, statement, args[0]); > >@@ -61,7 +61,7 @@ v8::Handle<v8::Value> V8SQLTransaction::executeSqlCallback(const v8::Arguments& > > if (args.Length() > 1 && !isUndefinedOrNull(args[1])) { > if (!args[1]->IsObject()) >- return throwError(TYPE_MISMATCH_ERR); >+ return throwError(TYPE_MISMATCH_ERR, args.GetIsolate()); > > uint32_t sqlArgsLength = 0; > v8::Local<v8::Object> sqlArgsObject = args[1]->ToObject(); >@@ -97,14 +97,14 @@ v8::Handle<v8::Value> V8SQLTransaction::executeSqlCallback(const v8::Arguments& > RefPtr<SQLStatementCallback> callback; > if (args.Length() > 2 && !isUndefinedOrNull(args[2])) { > if (!args[2]->IsObject()) >- return throwError(TYPE_MISMATCH_ERR); >+ return throwError(TYPE_MISMATCH_ERR, args.GetIsolate()); > callback = V8SQLStatementCallback::create(args[2], scriptExecutionContext); > } > > RefPtr<SQLStatementErrorCallback> errorCallback; > if (args.Length() > 3 && !isUndefinedOrNull(args[3])) { > if (!args[3]->IsObject()) >- return throwError(TYPE_MISMATCH_ERR); >+ return throwError(TYPE_MISMATCH_ERR, args.GetIsolate()); > errorCallback = V8SQLStatementErrorCallback::create(args[3], scriptExecutionContext); > } > >diff --git a/Source/WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp b/Source/WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp >index 59e4c0de0409890a91d2043d1b433ca27a1487c8..707b0d8b6bf139f837a10a3080c271d42e37acb8 100644 >--- a/Source/WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp >@@ -53,7 +53,7 @@ v8::Handle<v8::Value> V8SQLTransactionSync::executeSqlCallback(const v8::Argumen > INC_STATS("DOM.SQLTransactionSync.executeSql()"); > > if (!args.Length()) >- return throwError(SYNTAX_ERR); >+ return throwError(SYNTAX_ERR, args.GetIsolate()); > > STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, statement, args[0]); > >@@ -61,7 +61,7 @@ v8::Handle<v8::Value> V8SQLTransactionSync::executeSqlCallback(const v8::Argumen > > if (args.Length() > 1 && !isUndefinedOrNull(args[1])) { > if (!args[1]->IsObject()) >- return throwError(TYPE_MISMATCH_ERR); >+ return throwError(TYPE_MISMATCH_ERR, args.GetIsolate()); > > uint32_t sqlArgsLength = 0; > v8::Local<v8::Object> sqlArgsObject = args[1]->ToObject(); >diff --git a/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp b/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp >index 4247fde98990518f5b9882298ab6304efe4add41..dcc3466a79adf6e0e817b8bf7807ed4ed3a4bdb2 100644 >--- a/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp >@@ -108,7 +108,7 @@ static v8::Handle<v8::Value> storageSetter(v8::Local<v8::String> v8Name, v8::Loc > ExceptionCode ec = 0; > storage->setItem(name, value, ec); > if (ec) >- return throwError(ec); >+ return throwError(ec, info.GetIsolate()); > > return v8Value; > } >diff --git a/Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp b/Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp >index 771529e3eab039e855c1ee6e0062946d376cc72e..7c5395096cc6f2d423dc5d7f760f56feeb3279d6 100644 >--- a/Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp >@@ -65,11 +65,11 @@ v8::Handle<v8::Value> V8WebKitMutationObserver::constructorCallback(const v8::Ar > > v8::Local<v8::Value> arg = args[0]; > if (!arg->IsObject()) >- return throwError(TYPE_MISMATCH_ERR); >+ return throwError(TYPE_MISMATCH_ERR, args.GetIsolate()); > > ScriptExecutionContext* context = getScriptExecutionContext(); > if (!context) >- return V8Proxy::throwError(V8Proxy::ReferenceError, "WebKitMutationObserver constructor's associated frame unavailable"); >+ return V8Proxy::throwError(V8Proxy::ReferenceError, "WebKitMutationObserver constructor's associated frame unavailable", args.GetIsolate()); > > RefPtr<MutationCallback> callback = V8MutationCallback::create(arg, context); > RefPtr<WebKitMutationObserver> observer = WebKitMutationObserver::create(callback.release()); >@@ -88,7 +88,7 @@ v8::Handle<v8::Value> V8WebKitMutationObserver::observeCallback(const v8::Argume > EXCEPTION_BLOCK(Node*, target, V8Node::HasInstance(args[0]) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0); > > if (!args[1]->IsObject()) >- return throwError(TYPE_MISMATCH_ERR); >+ return throwError(TYPE_MISMATCH_ERR, args.GetIsolate()); > > Dictionary optionsObject(args[1]); > unsigned options = 0; >diff --git a/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp b/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp >index 3b11437993dff8847368f00e982ec5e37e6859c8..4950b208b1f3a4cb8a32726294fec346415fdf48 100644 >--- a/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp >@@ -67,14 +67,14 @@ v8::Handle<v8::Value> V8WebSocket::constructorCallback(const v8::Arguments& args > v8::TryCatch tryCatch; > v8::Handle<v8::String> urlstring = args[0]->ToString(); > if (tryCatch.HasCaught()) >- return throwError(tryCatch.Exception()); >+ return throwError(tryCatch.Exception(), args.GetIsolate()); > if (urlstring.IsEmpty()) >- return V8Proxy::throwError(V8Proxy::SyntaxError, "Empty URL"); >+ return V8Proxy::throwError(V8Proxy::SyntaxError, "Empty URL", args.GetIsolate()); > > // Get the script execution context. > ScriptExecutionContext* context = getScriptExecutionContext(); > if (!context) >- return V8Proxy::throwError(V8Proxy::ReferenceError, "WebSocket constructor's associated frame is not available"); >+ return V8Proxy::throwError(V8Proxy::ReferenceError, "WebSocket constructor's associated frame is not available", args.GetIsolate()); > > const KURL& url = context->completeURL(toWebCoreString(urlstring)); > >@@ -92,7 +92,7 @@ v8::Handle<v8::Value> V8WebSocket::constructorCallback(const v8::Arguments& args > v8::TryCatch tryCatchProtocol; > v8::Handle<v8::String> protocol = protocolsArray->Get(v8::Int32::New(i))->ToString(); > if (tryCatchProtocol.HasCaught()) >- return throwError(tryCatchProtocol.Exception()); >+ return throwError(tryCatchProtocol.Exception(), args.GetIsolate()); > protocols.append(toWebCoreString(protocol)); > } > webSocket->connect(url, protocols, ec); >@@ -100,12 +100,12 @@ v8::Handle<v8::Value> V8WebSocket::constructorCallback(const v8::Arguments& args > v8::TryCatch tryCatchProtocol; > v8::Handle<v8::String> protocol = protocolsValue->ToString(); > if (tryCatchProtocol.HasCaught()) >- return throwError(tryCatchProtocol.Exception()); >+ return throwError(tryCatchProtocol.Exception(), args.GetIsolate()); > webSocket->connect(url, toWebCoreString(protocol), ec); > } > } > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > V8DOMWrapper::setDOMWrapper(args.Holder(), &info, webSocket.get()); > V8DOMWrapper::setJSWrapperForActiveDOMObject(webSocket.release(), v8::Persistent<v8::Object>::New(args.Holder())); >@@ -135,11 +135,11 @@ v8::Handle<v8::Value> V8WebSocket::sendCallback(const v8::Arguments& args) > v8::TryCatch tryCatch; > v8::Handle<v8::String> stringMessage = message->ToString(); > if (tryCatch.HasCaught()) >- return throwError(tryCatch.Exception()); >+ return throwError(tryCatch.Exception(), args.GetIsolate()); > result = webSocket->send(toWebCoreString(stringMessage), ec); > } > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > return v8Boolean(result); > } >@@ -165,14 +165,14 @@ v8::Handle<v8::Value> V8WebSocket::closeCallback(const v8::Arguments& args) > v8::TryCatch tryCatch; > v8::Handle<v8::String> reasonValue = args[1]->ToString(); > if (tryCatch.HasCaught()) >- return throwError(tryCatch.Exception()); >+ return throwError(tryCatch.Exception(), args.GetIsolate()); > reason = toWebCoreString(reasonValue); > } > } > ExceptionCode ec = 0; > webSocket->close(code, reason, ec); > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > return v8::Undefined(); > } > >diff --git a/Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp b/Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp >index 91ba0077cba6bbed578535e997cf69d42ee060ea..78d94a4029766fc6056921d9de67b61e9c0e2f92 100644 >--- a/Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp >@@ -107,7 +107,7 @@ v8::Handle<v8::Value> V8WorkerContext::importScriptsCallback(const v8::Arguments > workerContext->importScripts(urls, ec); > > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > return v8::Undefined(); > } >diff --git a/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp b/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp >index 60e5bbe4741ef76432ce901cce353546ffe27879..654bf8afd33e6f5168e5948796d2f3dca63ce1cc 100644 >--- a/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp >@@ -68,7 +68,7 @@ static v8::Handle<v8::Value> handlePostMessageCallback(const v8::Arguments& args > return v8::Undefined(); > ExceptionCode ec = 0; > worker->postMessage(message.release(), &ports, ec); >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > } > > v8::Handle<v8::Value> V8Worker::postMessageCallback(const v8::Arguments& args) >diff --git a/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp b/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp >index 87d054ff82ed9964d63adb5366bd8f89482c2d02..435db80eb3e9908f2ade401c4305de7431c036de 100644 >--- a/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp >@@ -57,7 +57,7 @@ v8::Handle<v8::Value> V8XMLHttpRequest::constructorCallback(const v8::Arguments& > // Allocate a XMLHttpRequest object as its internal field. > ScriptExecutionContext* context = getScriptExecutionContext(); > if (!context) >- return V8Proxy::throwError(V8Proxy::ReferenceError, "XMLHttpRequest constructor's associated context is not available"); >+ return V8Proxy::throwError(V8Proxy::ReferenceError, "XMLHttpRequest constructor's associated context is not available", args.GetIsolate()); > > RefPtr<SecurityOrigin> securityOrigin; > if (V8IsolatedContext* isolatedContext = V8IsolatedContext::getEntered()) >diff --git a/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp b/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp >index 199a5944a38236ba10e0734e3e062d944ea990c4..37539b680fa19f811d1ef506e51ff3122a66618f 100644 >--- a/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp >@@ -56,7 +56,7 @@ v8::Handle<v8::Value> V8XMLHttpRequest::responseTextAccessorGetter(v8::Local<v8: > ExceptionCode ec = 0; > const String& text = xmlHttpRequest->responseText(ec); > if (ec) >- return throwError(ec); >+ return throwError(ec, info.GetIsolate()); > return v8String(text); > } > >@@ -152,7 +152,7 @@ v8::Handle<v8::Value> V8XMLHttpRequest::openCallback(const v8::Arguments& args) > xmlHttpRequest->open(method, url, ec); > > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > return v8::Undefined(); > } >@@ -204,7 +204,7 @@ v8::Handle<v8::Value> V8XMLHttpRequest::sendCallback(const v8::Arguments& args) > } > > if (ec) >- return throwError(ec); >+ return throwError(ec, args.GetIsolate()); > > return v8::Undefined(); > }
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=142936">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 86981
: 142936