Attachment 142874 Details for Bug 15494 – Patch

[patch] Patch

bug-15494-20120519203855.patch (text/plain), 18.30 KB, created by Nikolas Zimmermann on 2012-05-19 11:38:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikolas Zimmermann

Created: 2012-05-19 11:38:19 PDT

Size: 18.30 KB

patch

obsolete

>Subversion Revision: 117694
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8eb2a0400bdd5e4b4324fb49ea9230a3b7d3ebd3..c38359292bceab196d8818b1199fbc3f5953f612 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,33 @@
>+2012-05-19  Nikolas Zimmermann  <nzimmermann@rim.com>
>+
>+        SVGZoomAndPan constants are missing from window object
>+        https://bugs.webkit.org/show_bug.cgi?id=15494
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Generate the SVGZoomAndPanConstructor, so that the constants defined in the IDL
>+        can be reached from the bindings. Provide a stub-implementation of ref/deref
>+        that's never used, as we don't actually use JSSVGZoomAndPan which needs this, but
>+        only the JSSVGZoomAndPanConstructor.
>+
>+        * DerivedSources.cpp:
>+        * GNUmakefile.list.am:
>+        * WebCore.vcproj/WebCore.vcproj:
>+        * WebCore.xcodeproj/project.pbxproj:
>+        * page/DOMWindow.idl:
>+        * svg/SVGSVGElement.h:
>+        (SVGSVGElement):
>+        * svg/SVGViewElement.h:
>+        (SVGViewElement):
>+        * svg/SVGZoomAndPan.cpp:
>+        (WebCore::SVGZoomAndPan::parseZoomAndPan):
>+        (WebCore):
>+        (WebCore::SVGZoomAndPan::ref):
>+        (WebCore::SVGZoomAndPan::deref):
>+        * svg/SVGZoomAndPan.h:
>+        (WebCore::SVGZoomAndPan::setZoomAndPan):
>+        (SVGZoomAndPan):
>+
> 2012-05-19  Joe Thomas  <joethomas@motorola.com>
> 
>         The order of CSS properties is wrong in background shorthand
>diff --git a/Source/WebCore/DerivedSources.cpp b/Source/WebCore/DerivedSources.cpp
>index 988d58267d7e935ef6b027c49129fad81b8b10dc..ff343440d9c4720b76978c96face9254b168a449 100644
>--- a/Source/WebCore/DerivedSources.cpp
>+++ b/Source/WebCore/DerivedSources.cpp
>@@ -438,6 +438,7 @@
> #include "JSSVGUseElement.cpp"
> #include "JSSVGViewElement.cpp"
> #include "JSSVGVKernElement.cpp"
>+#include "JSSVGZoomAndPan.cpp"
> #include "JSSVGZoomEvent.cpp"
> #include "JSText.cpp"
> #include "JSTextEvent.cpp"
>diff --git a/Source/WebCore/GNUmakefile.list.am b/Source/WebCore/GNUmakefile.list.am
>index d71db595a4c94f22ab7ebbbae25291daf3a782c4..ea413cf7c440b45b959a301061143125e248a2ab 100644
>--- a/Source/WebCore/GNUmakefile.list.am
>+++ b/Source/WebCore/GNUmakefile.list.am
>@@ -5382,6 +5382,7 @@ webcore_built_sources += \
> 	DerivedSources/WebCore/JSSVGViewSpec.h \
> 	DerivedSources/WebCore/JSSVGVKernElement.cpp \
> 	DerivedSources/WebCore/JSSVGVKernElement.h \
>+	DerivedSources/WebCore/JSSVGZoomAndPan.cpp \
> 	DerivedSources/WebCore/JSSVGZoomAndPan.h \
> 	DerivedSources/WebCore/JSSVGZoomEvent.cpp \
> 	DerivedSources/WebCore/JSSVGZoomEvent.h
>diff --git a/Source/WebCore/WebCore.vcproj/WebCore.vcproj b/Source/WebCore/WebCore.vcproj/WebCore.vcproj
>index 213d93bfaa36f8c6c0279891fe3ddbde66812b0a..5558014183d1247df5b1b4d5911b12f76e239471 100755
>--- a/Source/WebCore/WebCore.vcproj/WebCore.vcproj
>+++ b/Source/WebCore/WebCore.vcproj/WebCore.vcproj
>@@ -21834,6 +21834,63 @@
> 				>
> 			</File>
> 			<File
>+				RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGZoomAndPan.cpp"
>+				>
>+				<FileConfiguration
>+					Name="Debug|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Release|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Debug_Cairo_CFLite|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Release_Cairo_CFLite|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Debug_All|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Production|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+			</File>
>+			<File
>+				RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGZoomAndPan.h"
>+				>
>+			</File>
>+
>+			<File
> 				RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGZoomEvent.cpp"
> 				>
> 				<FileConfiguration
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index 4c6fe67ee9c9ef7906752611c4249e5b731ae233..193652a914cf0be50697d1b646182c38b646aae7 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -1808,6 +1808,8 @@
> 		71A57DF1154BE25C0009D120 /* SVGPathUtilities.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 71A57DEF154BE25C0009D120 /* SVGPathUtilities.cpp */; };
> 		71A57DF2154BE25C0009D120 /* SVGPathUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 71A57DF0154BE25C0009D120 /* SVGPathUtilities.h */; };
> 		71CC7A20152A0BFE009EEAF9 /* SVGAnimatedEnumeration.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 71CC7A1F152A0BFE009EEAF9 /* SVGAnimatedEnumeration.cpp */; };
>+		71DCB7011568197600862271 /* JSSVGZoomAndPan.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 71DCB6FF1568197600862271 /* JSSVGZoomAndPan.cpp */; };
>+		71DCB7021568197600862271 /* JSSVGZoomAndPan.h in Headers */ = {isa = PBXBuildFile; fileRef = 71DCB7001568197600862271 /* JSSVGZoomAndPan.h */; };
> 		71E623D1151F72A60036E2F4 /* SVGAnimatedIntegerOptionalInteger.h in Headers */ = {isa = PBXBuildFile; fileRef = 71E623CF151F72A60036E2F4 /* SVGAnimatedIntegerOptionalInteger.h */; };
> 		71FB967B1383D64600AC8A4C /* SVGAnimatedEnumerationPropertyTearOff.h in Headers */ = {isa = PBXBuildFile; fileRef = 71FB967A1383D64600AC8A4C /* SVGAnimatedEnumerationPropertyTearOff.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		72626E020EF022FE00A07E20 /* FontFastPath.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72626E010EF022FE00A07E20 /* FontFastPath.cpp */; };
>@@ -8847,6 +8849,8 @@
> 		71A57DEF154BE25C0009D120 /* SVGPathUtilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SVGPathUtilities.cpp; sourceTree = "<group>"; };
> 		71A57DF0154BE25C0009D120 /* SVGPathUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGPathUtilities.h; sourceTree = "<group>"; };
> 		71CC7A1F152A0BFE009EEAF9 /* SVGAnimatedEnumeration.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SVGAnimatedEnumeration.cpp; sourceTree = "<group>"; };
>+		71DCB6FF1568197600862271 /* JSSVGZoomAndPan.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSSVGZoomAndPan.cpp; path = JSSVGZoomAndPan.cpp; sourceTree = "<group>"; };
>+		71DCB7001568197600862271 /* JSSVGZoomAndPan.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSSVGZoomAndPan.h; path = JSSVGZoomAndPan.h; sourceTree = "<group>"; };
> 		71E623CE151F72A60036E2F4 /* SVGAnimatedIntegerOptionalInteger.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SVGAnimatedIntegerOptionalInteger.cpp; sourceTree = "<group>"; };
> 		71E623CF151F72A60036E2F4 /* SVGAnimatedIntegerOptionalInteger.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedIntegerOptionalInteger.h; sourceTree = "<group>"; };
> 		71FB967A1383D64600AC8A4C /* SVGAnimatedEnumerationPropertyTearOff.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedEnumerationPropertyTearOff.h; sourceTree = "<group>"; };
>@@ -18360,6 +18364,8 @@
> 				B2FA3D2F0AB75A6F000E5AC4 /* JSSVGViewElement.h */,
> 				848522791190162C006EDC7F /* JSSVGVKernElement.cpp */,
> 				8485227A1190162C006EDC7F /* JSSVGVKernElement.h */,
>+				71DCB6FF1568197600862271 /* JSSVGZoomAndPan.cpp */,
>+				71DCB7001568197600862271 /* JSSVGZoomAndPan.h */,
> 				B2FA3D300AB75A6F000E5AC4 /* JSSVGZoomEvent.cpp */,
> 				B2FA3D310AB75A6F000E5AC4 /* JSSVGZoomEvent.h */,
> 			);
>@@ -24913,6 +24919,7 @@
> 				29A309B11561CAC400BBD8E5 /* VisitedLinks.h in Headers */,
> 				FDB052E01561A42C00B500D6 /* AudioSummingJunction.h in Headers */,
> 				371941971566B37200A276D8 /* WebCoreNSCellExtras.h in Headers */,
>+				71DCB7021568197600862271 /* JSSVGZoomAndPan.h in Headers */,
> 			);
> 			runOnlyForDeploymentPostprocessing = 0;
> 		};
>@@ -27937,6 +27944,7 @@
> 				29A309B01561CAC400BBD8E5 /* VisitedLinks.cpp in Sources */,
> 				FDB052DF1561A42C00B500D6 /* AudioSummingJunction.cpp in Sources */,
> 				371941961566B37200A276D8 /* WebCoreNSCellExtras.m in Sources */,
>+				71DCB7011568197600862271 /* JSSVGZoomAndPan.cpp in Sources */,
> 			);
> 			runOnlyForDeploymentPostprocessing = 0;
> 		};
>diff --git a/Source/WebCore/page/DOMWindow.idl b/Source/WebCore/page/DOMWindow.idl
>index 9a512d07665a1a81c45917b9f805a60bd189bdc0..ee54714dc5df6f9c06e853b9a74be66f72b82c08 100644
>--- a/Source/WebCore/page/DOMWindow.idl
>+++ b/Source/WebCore/page/DOMWindow.idl
>@@ -709,6 +709,7 @@ module window {
>         attribute SVGUseElementConstructor SVGUseElement;
>         attribute SVGViewElementConstructor SVGViewElement;
> //      attribute SVGViewSpecConstructor SVGViewSpec;
>+        attribute SVGZoomAndPanConstructor SVGZoomAndPan;
> 
>         attribute SVGAnimateColorElementConstructor SVGAnimateColorElement;
>         attribute SVGAnimateElementConstructor SVGAnimateElement;
>diff --git a/Source/WebCore/svg/SVGSVGElement.h b/Source/WebCore/svg/SVGSVGElement.h
>index 6ead78bd2840d5898619665f8d2ca22b1c8c7c43..173ebe200bb634ae3c7969f19455121d51122212 100644
>--- a/Source/WebCore/svg/SVGSVGElement.h
>+++ b/Source/WebCore/svg/SVGSVGElement.h
>@@ -51,6 +51,9 @@ class SVGSVGElement : public SVGStyledLocatableElement,
> public:
>     static PassRefPtr<SVGSVGElement> create(const QualifiedName&, Document*);
> 
>+    using SVGStyledLocatableElement::ref;
>+    using SVGStyledLocatableElement::deref;
>+
>     virtual bool isValid() const { return SVGTests::isValid(); }
>     virtual bool supportsFocus() const { return true; }
> 
>diff --git a/Source/WebCore/svg/SVGViewElement.h b/Source/WebCore/svg/SVGViewElement.h
>index 6d8089ea2efa8b7c828e9a6d2d02ff8db9f1c681..c5a668da2921bcc10f0b442b80d511cb05433348 100644
>--- a/Source/WebCore/svg/SVGViewElement.h
>+++ b/Source/WebCore/svg/SVGViewElement.h
>@@ -42,6 +42,9 @@ public:
> 
>     SVGStringList& viewTarget() { return m_viewTarget; }
> 
>+    using SVGStyledElement::ref;
>+    using SVGStyledElement::deref;
>+
> private:
>     SVGViewElement(const QualifiedName&, Document*);
> 
>diff --git a/Source/WebCore/svg/SVGZoomAndPan.cpp b/Source/WebCore/svg/SVGZoomAndPan.cpp
>index e706affda3013ec48a361eefd11741cbccf58ee4..e2afbac4942e711d79a242ac383ac1cbecc80c15 100644
>--- a/Source/WebCore/svg/SVGZoomAndPan.cpp
>+++ b/Source/WebCore/svg/SVGZoomAndPan.cpp
>@@ -29,11 +29,6 @@
> 
> namespace WebCore {
> 
>-void SVGZoomAndPan::setZoomAndPan(unsigned short zoomAndPan)
>-{
>-    m_zoomAndPan = zoomAndPan;
>-}
>-
> bool SVGZoomAndPan::parseAttribute(const Attribute& attribute)
> {
>     if (attribute.name() == SVGNames::zoomAndPanAttr) {
>@@ -61,14 +56,25 @@ static const UChar magnify[] =  {'m', 'a', 'g', 'n', 'i', 'f', 'y'};
> 
> bool SVGZoomAndPan::parseZoomAndPan(const UChar*& start, const UChar* end)
> {
>-    if (skipString(start, end, disable, WTF_ARRAY_LENGTH(disable)))
>+    if (skipString(start, end, disable, WTF_ARRAY_LENGTH(disable))) {
>         setZoomAndPan(SVG_ZOOMANDPAN_DISABLE);
>-    else if (skipString(start, end, magnify, WTF_ARRAY_LENGTH(magnify)))
>+        return true;
>+    }
>+    if (skipString(start, end, magnify, WTF_ARRAY_LENGTH(magnify))) {
>         setZoomAndPan(SVG_ZOOMANDPAN_MAGNIFY);
>-    else
>-        return false;
>+        return true;
>+    }
>+    return false;
>+}
>+
>+NO_RETURN void SVGZoomAndPan::ref()
>+{
>+    ASSERT_NOT_REACHED();
>+}
> 
>-    return true;
>+NO_RETURN void SVGZoomAndPan::deref()
>+{
>+    ASSERT_NOT_REACHED();
> }
> 
> }
>diff --git a/Source/WebCore/svg/SVGZoomAndPan.h b/Source/WebCore/svg/SVGZoomAndPan.h
>index e2d52f64dc3d40ef14cd739a5dcfabefa04b2772..2e75b2fd20ca5eb070e193f31b0bfb4b7d124d92 100644
>--- a/Source/WebCore/svg/SVGZoomAndPan.h
>+++ b/Source/WebCore/svg/SVGZoomAndPan.h
>@@ -39,10 +39,9 @@ public:
>     };
> 
>     SVGZoomAndPan() : m_zoomAndPan(SVG_ZOOMANDPAN_MAGNIFY) { }
>-    virtual ~SVGZoomAndPan() { }
> 
>     unsigned short zoomAndPan() const { return m_zoomAndPan; }
>-    virtual void setZoomAndPan(unsigned short zoomAndPan);
>+    void setZoomAndPan(unsigned short zoomAndPan) { m_zoomAndPan = zoomAndPan; }
> 
>     bool parseAttribute(const Attribute&);
>     bool isKnownAttribute(const QualifiedName&);
>@@ -50,6 +49,9 @@ public:
> 
>     bool parseZoomAndPan(const UChar*& start, const UChar* end);
> 
>+    void ref();
>+    void deref();
>+
> private:
>     unsigned short m_zoomAndPan;
> };
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 33917a600118d69075bea532dd435fa99187819b..6460966501271101a7021120fb9f509c4cfbb0a8 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2012-05-19  Nikolas Zimmermann  <nzimmermann@rim.com>
>+
>+        SVGZoomAndPan constants are missing from window object
>+        https://bugs.webkit.org/show_bug.cgi?id=15494
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        SVGZoomAndPan is now available as global constructor, rebaseline results.
>+
>+        * svg/custom/global-constructors-expected.txt:
>+        * svg/custom/js-svg-constructors-expected.txt:
>+        * svg/custom/js-svg-constructors.svg:
>+
> 2012-05-19  Joe Thomas  <joethomas@motorola.com>
> 
>         The order of CSS properties is wrong in background shorthand
>diff --git a/LayoutTests/svg/custom/global-constructors-expected.txt b/LayoutTests/svg/custom/global-constructors-expected.txt
>index b0bfc681351ea8f79e38a80774306bb09f35154c..72deff592840eaae7c6ba09240b2a4ed9a1253b4 100644
>--- a/LayoutTests/svg/custom/global-constructors-expected.txt
>+++ b/LayoutTests/svg/custom/global-constructors-expected.txt
>@@ -31,7 +31,7 @@ FAIL SVGTests.toString() should be [object SVGTestsConstructor]. Threw exception
> FAIL SVGLangSpace.toString() should be [object SVGLangSpaceConstructor]. Threw exception ReferenceError: Can't find variable: SVGLangSpace
> FAIL SVGExternalResourcesRequired.toString() should be [object SVGExternalResourcesRequiredConstructor]. Threw exception ReferenceError: Can't find variable: SVGExternalResourcesRequired
> FAIL SVGFitToViewBox.toString() should be [object SVGFitToViewBoxConstructor]. Threw exception ReferenceError: Can't find variable: SVGFitToViewBox
>-FAIL SVGZoomAndPan.toString() should be [object SVGZoomAndPanConstructor]. Threw exception ReferenceError: Can't find variable: SVGZoomAndPan
>+PASS SVGZoomAndPan.toString() is '[object SVGZoomAndPanConstructor]'
> FAIL SVGViewSpec.toString() should be [object SVGViewSpecConstructor]. Threw exception ReferenceError: Can't find variable: SVGViewSpec
> FAIL SVGURIReference.toString() should be [object SVGURIReferenceConstructor]. Threw exception ReferenceError: Can't find variable: SVGURIReference
> FAIL SVGCSSRule.toString() should be [object SVGCSSRuleConstructor]. Threw exception ReferenceError: Can't find variable: SVGCSSRule
>diff --git a/LayoutTests/svg/custom/js-svg-constructors-expected.txt b/LayoutTests/svg/custom/js-svg-constructors-expected.txt
>index ab7e638eb0d07b0652ec595166c0520d45fd66d6..1b72283ecf1f3b7b758f1416f12274edf3790615 100644
>--- a/LayoutTests/svg/custom/js-svg-constructors-expected.txt
>+++ b/LayoutTests/svg/custom/js-svg-constructors-expected.txt
>@@ -44,9 +44,9 @@ SVGFEDisplacementMapElement.SVG_CHANNEL_R PASSED
> SVGFEDisplacementMapElement.SVG_CHANNEL_G PASSED
> SVGFEDisplacementMapElement.SVG_CHANNEL_B PASSED
> SVGFEDisplacementMapElement.SVG_CHANNEL_A PASSED
>-SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_UNKNOWN EXPECTED FAILURE (actual: '0' expected: '0')
>-SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_ERODE EXPECTED FAILURE (actual: '1' expected: '1')
>-SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_DILATE EXPECTED FAILURE (actual: '2' expected: '2')
>+SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_UNKNOWN PASSED
>+SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_ERODE PASSED
>+SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_DILATE PASSED
> SVGFETurbulenceElement.SVG_TURBULENCE_TYPE_UNKNOWN PASSED
> SVGFETurbulenceElement.SVG_TURBULENCE_TYPE_FRACTALNOISE PASSED
> SVGFETurbulenceElement.SVG_TURBULENCE_TYPE_TURBULENCE PASSED
>@@ -143,6 +143,6 @@ SVGTransform.SVG_TRANSFORM_SKEWY PASSED
> SVGUnitTypes.SVG_UNIT_TYPE_UNKNOWN PASSED
> SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE PASSED
> SVGUnitTypes.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX PASSED
>-SVGZoomAndPan.SVG_ZOOMANDPAN_UNKNOWN EXPECTED FAILURE (actual: 'undefined' expected: '0')
>-SVGZoomAndPan.SVG_ZOOMANDPAN_DISABLE EXPECTED FAILURE (actual: 'undefined' expected: '1')
>-SVGZoomAndPan.SVG_ZOOMANDPAN_MAGNIFY EXPECTED FAILURE (actual: 'undefined' expected: '2')
>+SVGZoomAndPan.SVG_ZOOMANDPAN_UNKNOWN PASSED
>+SVGZoomAndPan.SVG_ZOOMANDPAN_DISABLE PASSED
>+SVGZoomAndPan.SVG_ZOOMANDPAN_MAGNIFY PASSED
>diff --git a/LayoutTests/svg/custom/js-svg-constructors.svg b/LayoutTests/svg/custom/js-svg-constructors.svg
>index 35631cdcea079c6e6a150241c32ee033c50c2fc1..85871371bac097484a7a7e13e6f9b58f25e0bb7c 100644
>--- a/LayoutTests/svg/custom/js-svg-constructors.svg
>+++ b/LayoutTests/svg/custom/js-svg-constructors.svg
>@@ -93,9 +93,9 @@
>       }
> 
>       if (window.SVGFEMorphologyElement) {
>-          expect_failure("SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_UNKNOWN", 0);
>-          expect_failure("SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_ERODE", 1);
>-          expect_failure("SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_DILATE", 2);
>+          expect("SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_UNKNOWN", 0);
>+          expect("SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_ERODE", 1);
>+          expect("SVGFEMorphologyElement.SVG_MORPHOLOGY_OPERATOR_DILATE", 2);
>       }
> 
>       if (window.SVGFETurbulenceElement) {
>@@ -208,9 +208,9 @@
>       expect("SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE", 1);
>       expect("SVGUnitTypes.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX", 2);
> 
>-      expect_failure("SVGZoomAndPan.SVG_ZOOMANDPAN_UNKNOWN", 0);
>-      expect_failure("SVGZoomAndPan.SVG_ZOOMANDPAN_DISABLE", 1);
>-      expect_failure("SVGZoomAndPan.SVG_ZOOMANDPAN_MAGNIFY", 2);
>+      expect("SVGZoomAndPan.SVG_ZOOMANDPAN_UNKNOWN", 0);
>+      expect("SVGZoomAndPan.SVG_ZOOMANDPAN_DISABLE", 1);
>+      expect("SVGZoomAndPan.SVG_ZOOMANDPAN_MAGNIFY", 2);
>     }
>   ]]></script>  
> </svg>

Actions: View | Formatted Diff | Diff

Attachments on bug 15494: 142874 | 142883 | 143244 | 143301 | 143311 | 143488 | 143499