WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-86893-20120518163809.patch (text/plain), 22.14 KB, created by
Mark Pilgrim (Google)
on 2012-05-18 13:38:27 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Mark Pilgrim (Google)
Created:
2012-05-18 13:38:27 PDT
Size:
22.14 KB
patch
obsolete
>Index: Source/Platform/ChangeLog >=================================================================== >--- Source/Platform/ChangeLog (revision 117618) >+++ Source/Platform/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2012-05-18 Mark Pilgrim <pilgrim@chromium.org> >+ >+ [Chromium] Call canAccelerate2dCanvas directly >+ https://bugs.webkit.org/show_bug.cgi?id=86893 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Part of a refactoring series. See tracking bug 82948. >+ >+ * chromium/public/Platform.h: >+ (Platform): >+ (WebKit::Platform::canAccelerate2dCanvas): >+ > 2012-05-17 Mark Pilgrim <pilgrim@chromium.org> > > [Chromium] Move Web Workers methods to Platform.h >Index: Source/Platform/chromium/public/Platform.h >=================================================================== >--- Source/Platform/chromium/public/Platform.h (revision 117613) >+++ Source/Platform/chromium/public/Platform.h (working copy) >@@ -313,7 +313,14 @@ public: > // Returns newly allocated and initialized offscreen WebGraphicsContext3D instance. > virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&) { return 0; } > >+ // Returns true if the platform is capable of producing an offscreen context suitable for accelerating 2d canvas. >+ // This will return false if the platform cannot promise that contexts will be preserved across operations like >+ // locking the screen or if the platform cannot provide a context with suitable performance characteristics. >+ // >+ // This value must be checked again after a context loss event as the platform's capabilities may have changed. >+ virtual bool canAccelerate2dCanvas() { return false; } > >+ > // WebRTC ---------------------------------------------------------- > > // DEPRECATED >Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 117618) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,33 @@ >+2012-05-18 Mark Pilgrim <pilgrim@chromium.org> >+ >+ [Chromium] Call canAccelerate2dCanvas directly >+ https://bugs.webkit.org/show_bug.cgi?id=86893 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ No new tests. (OOPS!) >+ >+ Part of a refactoring series. See tracking bug 82948. >+ >+ * CMakeLists.txt: >+ * GNUmakefile.list.am: >+ * Target.pri: >+ * WebCore.gypi: >+ * WebCore.vcproj/WebCore.vcproj: >+ * WebCore.xcodeproj/project.pbxproj: >+ * html/HTMLCanvasElement.cpp: >+ (WebCore::HTMLCanvasElement::shouldAccelerate): >+ * platform/GPUSupport.cpp: Added. >+ (WebCore): >+ (WebCore::GPUSupport::canAccelerate2dCanvas): >+ * platform/GPUSupport.h: Added. >+ (WebCore): >+ (GPUSupport): >+ * platform/chromium/GPUSupportChromium.cpp: Added. >+ (WebCore): >+ (WebCore::GPUSupport::canAccelerate2dCanvas): >+ * platform/chromium/PlatformSupport.h: >+ > 2012-05-18 Tony Chang <tony@chromium.org> > > remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off >Index: Source/WebCore/CMakeLists.txt >=================================================================== >--- Source/WebCore/CMakeLists.txt (revision 117613) >+++ Source/WebCore/CMakeLists.txt (working copy) >@@ -1108,6 +1108,7 @@ SET(WebCore_SOURCES > platform/FileIconLoader.cpp > platform/FileSystem.cpp > platform/ClockGeneric.cpp >+ platform/GPUSupport.cpp > platform/HistogramSupport.cpp > platform/KURL.cpp > platform/KillRingNone.cpp >Index: Source/WebCore/GNUmakefile.list.am >=================================================================== >--- Source/WebCore/GNUmakefile.list.am (revision 117613) >+++ Source/WebCore/GNUmakefile.list.am (working copy) >@@ -3124,6 +3124,8 @@ webcore_sources += \ > Source/WebCore/platform/FileSystem.h \ > Source/WebCore/platform/FloatConversion.h \ > Source/WebCore/platform/FractionalLayoutUnit.h \ >+ Source/WebCore/platform/GPUSupport.cpp \ >+ Source/WebCore/platform/GPUSupport.h \ > Source/WebCore/platform/HashTools.h \ > Source/WebCore/platform/HistogramSupport.cpp \ > Source/WebCore/platform/HistogramSupport.h \ >Index: Source/WebCore/Target.pri >=================================================================== >--- Source/WebCore/Target.pri (revision 117613) >+++ Source/WebCore/Target.pri (working copy) >@@ -1086,6 +1086,7 @@ SOURCES += \ > platform/FileIconLoader.cpp \ > platform/FileStream.cpp \ > platform/FileSystem.cpp \ >+ platform/GPUSupport.cpp \ > platform/HistogramSupport.cpp \ > platform/image-decoders/qt/ImageFrameQt.cpp \ > platform/graphics/FontDescription.cpp \ >@@ -2196,6 +2197,7 @@ HEADERS += \ > platform/FileStream.h \ > platform/FileStreamClient.h \ > platform/FileSystem.h \ >+ platform/GPUSupport.h \ > platform/HistogramSupport.h \ > platform/image-decoders/ImageDecoder.h \ > platform/mock/DeviceOrientationClientMock.h \ >Index: Source/WebCore/WebCore.gypi >=================================================================== >--- Source/WebCore/WebCore.gypi (revision 117613) >+++ Source/WebCore/WebCore.gypi (working copy) >@@ -278,6 +278,7 @@ > 'platform/FileStream.h', > 'platform/FileStreamClient.h', > 'platform/FileSystem.h', >+ 'platform/GPUSupport.h', > 'platform/HostWindow.h', > 'platform/HistogramSupport.h', > 'platform/KURL.h', >@@ -3323,6 +3324,7 @@ > 'platform/chromium/FramelessScrollView.h', > 'platform/chromium/FramelessScrollViewClient.h', > 'platform/chromium/GamepadsChromium.cpp', >+ 'platform/chromium/GPUSupportChromium.cpp', > 'platform/chromium/HistogramSupportChromium.cpp', > 'platform/chromium/KeyCodeConversion.h', > 'platform/chromium/KeyCodeConversionAndroid.cpp', >Index: Source/WebCore/WebCore.vcproj/WebCore.vcproj >=================================================================== >--- Source/WebCore/WebCore.vcproj/WebCore.vcproj (revision 117613) >+++ Source/WebCore/WebCore.vcproj/WebCore.vcproj (working copy) >@@ -27798,6 +27798,14 @@ > > > </File> > <File >+ RelativePath="..\platform\GPUSupport.cpp" >+ > >+ </File> >+ <File >+ RelativePath="..\platform\GPUSupport.h" >+ > >+ </File> >+ <File > RelativePath="..\platform\HistogramSupport.cpp" > > > </File> >Index: Source/WebCore/WebCore.xcodeproj/project.pbxproj >=================================================================== >--- Source/WebCore/WebCore.xcodeproj/project.pbxproj (revision 117613) >+++ Source/WebCore/WebCore.xcodeproj/project.pbxproj (working copy) >@@ -5826,6 +5826,7 @@ > D630E2AC149BF344005B2F94 /* StatsCounter.h in Headers */ = {isa = PBXBuildFile; fileRef = D630E2AB149BF344005B2F94 /* StatsCounter.h */; }; > D630E2AC149BF344005B2F95 /* MemoryUsageSupport.h in Headers */ = {isa = PBXBuildFile; fileRef = D630E2AB149BF344005B2F95 /* MemoryUsageSupport.h */; }; > D630E2AC149BF344005B2F96 /* EventTracer.h in Headers */ = {isa = PBXBuildFile; fileRef = D630E2AB149BF344005B2F96 /* EventTracer.h */; }; >+ D630E2AC149BF344005B2F97 /* GPUSupport.h in Headers */ = {isa = PBXBuildFile; fileRef = D630E2AB149BF344005B2F97 /* GPUSupport.h */; }; > D6E276AF14637455001D280A /* MutationObserverRegistration.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6E276AD14637455001D280A /* MutationObserverRegistration.cpp */; }; > D6E276B014637455001D280A /* MutationObserverRegistration.h in Headers */ = {isa = PBXBuildFile; fileRef = D6E276AE14637455001D280A /* MutationObserverRegistration.h */; }; > D6E528A3149A926D00EFE1F3 /* MutationObserverInterestGroup.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6E528A1149A926D00EFE1F3 /* MutationObserverInterestGroup.cpp */; }; >@@ -5834,6 +5835,7 @@ > D6FDAEF3149C06190037B1E2 /* StatsCounter.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6FDAEF2149C06190037B1E2 /* StatsCounter.cpp */; }; > D6FDAEF3149C06190037B1E3 /* MemoryUsageSupport.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6FDAEF2149C06190037B1E3 /* MemoryUsageSupport.cpp */; }; > D6FDAEF3149C06190037B1E4 /* EventTracer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6FDAEF2149C06190037B1E4 /* EventTracer.cpp */; }; >+ D6FDAEF3149C06190037B1E5 /* GPUSupport.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6FDAEF2149C06190037B1E5 /* GPUSupport.cpp */; }; > D70AD65713E1342B005B50B4 /* RenderRegion.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D70AD65513E1342B005B50B4 /* RenderRegion.cpp */; }; > D70AD65813E1342B005B50B4 /* RenderRegion.h in Headers */ = {isa = PBXBuildFile; fileRef = D70AD65613E1342B005B50B4 /* RenderRegion.h */; }; > D72F6D79153159A3001EE44E /* FlowThreadController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D72F6D77153159A3001EE44E /* FlowThreadController.cpp */; }; >@@ -12987,6 +12989,7 @@ > D630E2AB149BF344005B2F94 /* StatsCounter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StatsCounter.h; sourceTree = "<group>"; }; > D630E2AB149BF344005B2F95 /* MemoryUsageSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MemoryUsageSupport.h; sourceTree = "<group>"; }; > D630E2AB149BF344005B2F96 /* EventTracer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EventTracer.h; sourceTree = "<group>"; }; >+ D630E2AB149BF344005B2F97 /* GPUSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GPUSupport.h; sourceTree = "<group>"; }; > D6E276AD14637455001D280A /* MutationObserverRegistration.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MutationObserverRegistration.cpp; sourceTree = "<group>"; }; > D6E276AE14637455001D280A /* MutationObserverRegistration.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MutationObserverRegistration.h; sourceTree = "<group>"; }; > D6E528A1149A926D00EFE1F3 /* MutationObserverInterestGroup.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MutationObserverInterestGroup.cpp; sourceTree = "<group>"; }; >@@ -12995,6 +12998,7 @@ > D6FDAEF2149C06190037B1E2 /* StatsCounter.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StatsCounter.cpp; sourceTree = "<group>"; }; > D6FDAEF2149C06190037B1E3 /* MemoryUsageSupport.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MemoryUsageSupport.cpp; sourceTree = "<group>"; }; > D6FDAEF2149C06190037B1E4 /* EventTracer.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = EventTracer.cpp; sourceTree = "<group>"; }; >+ D6FDAEF2149C06190037B1E5 /* GPUSupport.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GPUSupport.cpp; sourceTree = "<group>"; }; > D70AD65513E1342B005B50B4 /* RenderRegion.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderRegion.cpp; sourceTree = "<group>"; }; > D70AD65613E1342B005B50B4 /* RenderRegion.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderRegion.h; sourceTree = "<group>"; }; > D72F6D77153159A3001EE44E /* FlowThreadController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FlowThreadController.cpp; sourceTree = "<group>"; }; >@@ -20313,6 +20317,8 @@ > 514B3F720C722047000530DF /* FileSystem.h */, > BC073BA90C399B1F000F5979 /* FloatConversion.h */, > 144FCE5114EC79BC000D17A3 /* FractionalLayoutUnit.h */, >+ D6FDAEF2149C06190037B1E5 /* GPUSupport.cpp */, >+ D630E2AB149BF344005B2F97 /* GPUSupport.h */, > A8748BDF12CBF2DC001FBA41 /* HashTools.h */, > D6FDAEF2149C06190037B1E1 /* HistogramSupport.cpp */, > D630E2AB149BF344005B2F93 /* HistogramSupport.h */, >@@ -22920,6 +22926,7 @@ > C5D4AA7A116BAFB60069CA93 /* GlyphMetricsMap.h in Headers */, > 0873B86B136064EA00A522C2 /* GlyphPage.h in Headers */, > B2C3DA6E0D006CD600EF6F26 /* GlyphPageTreeNode.h in Headers */, >+ D630E2AC149BF344005B2F97 /* GPUSupport.h in Headers */, > BC53C5F50DA56B920021EB5D /* Gradient.h in Headers */, > B22279640D00BF220071B782 /* GradientAttributes.h in Headers */, > B2A015A90AF6CD53006BCE0E /* GraphicsContext.h in Headers */, >@@ -26060,6 +26067,7 @@ > 9746AF2614F4DDE6003E7A70 /* GeolocationController.cpp in Sources */, > B2C3DA6D0D006CD600EF6F26 /* GlyphPageTreeNode.cpp in Sources */, > B2AFFC830D00A5C10030074D /* GlyphPageTreeNodeMac.cpp in Sources */, >+ D6FDAEF3149C06190037B1E5 /* GPUSupport.cpp in Sources */, > BC53C6080DA56C570021EB5D /* Gradient.cpp in Sources */, > BC53C60B0DA56CF10021EB5D /* GradientCG.cpp in Sources */, > B2A015A80AF6CD53006BCE0E /* GraphicsContext.cpp in Sources */, >Index: Source/WebCore/html/HTMLCanvasElement.cpp >=================================================================== >--- Source/WebCore/html/HTMLCanvasElement.cpp (revision 117613) >+++ Source/WebCore/html/HTMLCanvasElement.cpp (working copy) >@@ -59,7 +59,7 @@ > #endif > > #if PLATFORM(CHROMIUM) >-#include "PlatformSupport.h" >+#include "GPUSupport.h" > #endif > > namespace WebCore { >@@ -485,7 +485,7 @@ bool HTMLCanvasElement::shouldAccelerate > return false; > > #if PLATFORM(CHROMIUM) >- if (!PlatformSupport::canAccelerate2dCanvas()) >+ if (!GPUSupport::canAccelerate2dCanvas()) > return false; > #endif > >Index: Source/WebCore/platform/GPUSupport.cpp >=================================================================== >--- Source/WebCore/platform/GPUSupport.cpp (revision 0) >+++ Source/WebCore/platform/GPUSupport.cpp (revision 0) >@@ -0,0 +1,41 @@ >+/* >+ * Copyright (C) 2012 Google Inc. All rights reserved. >+ * >+ * Redistribution and use in source and binary forms, with or without >+ * modification, are permitted provided that the following conditions are >+ * met: >+ * >+ * * Redistributions of source code must retain the above copyright >+ * notice, this list of conditions and the following disclaimer. >+ * * Redistributions in binary form must reproduce the above >+ * copyright notice, this list of conditions and the following disclaimer >+ * in the documentation and/or other materials provided with the >+ * distribution. >+ * * Neither the name of Google Inc. nor the names of its >+ * contributors may be used to endorse or promote products derived from >+ * this software without specific prior written permission. >+ * >+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS >+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR >+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT >+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, >+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT >+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, >+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY >+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT >+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE >+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >+ */ >+ >+#include "config.h" >+#include "GPUSupport.h" >+ >+namespace WebCore { >+ >+bool GPUSupport::canAccelerate2dCanvas() >+{ >+ return false; >+} >+ >+} // namespace WebCore >Index: Source/WebCore/platform/GPUSupport.h >=================================================================== >--- Source/WebCore/platform/GPUSupport.h (revision 0) >+++ Source/WebCore/platform/GPUSupport.h (revision 0) >@@ -0,0 +1,43 @@ >+/* >+ * Copyright (C) 2012 Google Inc. All rights reserved. >+ * >+ * Redistribution and use in source and binary forms, with or without >+ * modification, are permitted provided that the following conditions are >+ * met: >+ * >+ * * Redistributions of source code must retain the above copyright >+ * notice, this list of conditions and the following disclaimer. >+ * * Redistributions in binary form must reproduce the above >+ * copyright notice, this list of conditions and the following disclaimer >+ * in the documentation and/or other materials provided with the >+ * distribution. >+ * * Neither the name of Google Inc. nor the names of its >+ * contributors may be used to endorse or promote products derived from >+ * this software without specific prior written permission. >+ * >+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS >+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR >+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT >+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, >+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT >+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, >+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY >+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT >+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE >+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >+ */ >+ >+#ifndef GPUSupport_h >+#define GPUSupport_h >+ >+namespace WebCore { >+ >+class GPUSupport { >+public: >+ static bool canAccelerate2dCanvas(); >+}; >+ >+} // namespace WebCore >+ >+#endif // GPUSupport_h >Index: Source/WebCore/platform/chromium/GPUSupportChromium.cpp >=================================================================== >--- Source/WebCore/platform/chromium/GPUSupportChromium.cpp (revision 0) >+++ Source/WebCore/platform/chromium/GPUSupportChromium.cpp (revision 0) >@@ -0,0 +1,43 @@ >+/* >+ * Copyright (C) 2012 Google Inc. All rights reserved. >+ * >+ * Redistribution and use in source and binary forms, with or without >+ * modification, are permitted provided that the following conditions are >+ * met: >+ * >+ * * Redistributions of source code must retain the above copyright >+ * notice, this list of conditions and the following disclaimer. >+ * * Redistributions in binary form must reproduce the above >+ * copyright notice, this list of conditions and the following disclaimer >+ * in the documentation and/or other materials provided with the >+ * distribution. >+ * * Neither the name of Google Inc. nor the names of its >+ * contributors may be used to endorse or promote products derived from >+ * this software without specific prior written permission. >+ * >+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS >+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR >+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT >+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, >+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT >+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, >+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY >+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT >+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE >+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >+ */ >+ >+#include "config.h" >+#include "GPUSupport.h" >+ >+#include <public/Platform.h> >+ >+namespace WebCore { >+ >+bool GPUSupport::canAccelerate2dCanvas() >+{ >+ return WebKit::Platform::current()->canAccelerate2dCanvas(); >+} >+ >+} // namespace WebCore >Index: Source/WebCore/platform/chromium/PlatformSupport.h >=================================================================== >--- Source/WebCore/platform/chromium/PlatformSupport.h (revision 117613) >+++ Source/WebCore/platform/chromium/PlatformSupport.h (working copy) >@@ -371,8 +371,6 @@ public: > > static void didStartWorkerRunLoop(WorkerRunLoop*); > static void didStopWorkerRunLoop(WorkerRunLoop*); >- >- static bool canAccelerate2dCanvas(); > }; > > } // namespace WebCore >Index: Source/WebKit/chromium/ChangeLog >=================================================================== >--- Source/WebKit/chromium/ChangeLog (revision 117618) >+++ Source/WebKit/chromium/ChangeLog (working copy) >@@ -1,3 +1,17 @@ >+2012-05-18 Mark Pilgrim <pilgrim@chromium.org> >+ >+ [Chromium] Call canAccelerate2dCanvas directly >+ https://bugs.webkit.org/show_bug.cgi?id=86893 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Part of a refactoring series. See tracking bug 82948. >+ >+ * public/platform/WebKitPlatformSupport.h: >+ (WebKitPlatformSupport): >+ * src/PlatformSupport.cpp: >+ (WebCore): >+ > 2012-05-18 Greg Billock <gbillock@google.com> > > Enable web intents flag for chromium build >Index: Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h >=================================================================== >--- Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (revision 117613) >+++ Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (working copy) >@@ -147,15 +147,6 @@ public: > > virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; } > >- // GPU ---------------------------------------------------------------- >- >- // Returns true if the platform is capable of producing an offscreen context suitable for accelerating 2d canvas. >- // This will return false if the platform cannot promise that contexts will be preserved across operations like >- // locking the screen or if the platform cannot provide a context with suitable performance characteristics. >- // >- // This value must be checked again after a context loss event as the platform's capabilities may have changed. >- virtual bool canAccelerate2dCanvas() { return false; } >- > > protected: > ~WebKitPlatformSupport() { } >Index: Source/WebKit/chromium/src/PlatformSupport.cpp >=================================================================== >--- Source/WebKit/chromium/src/PlatformSupport.cpp (revision 117613) >+++ Source/WebKit/chromium/src/PlatformSupport.cpp (working copy) >@@ -920,9 +920,4 @@ WorkerContextProxy* WorkerContextProxy:: > } > #endif > >-bool PlatformSupport::canAccelerate2dCanvas() >-{ >- return webKitPlatformSupport()->canAccelerate2dCanvas(); >-} >- > } // namespace WebCore
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=142780">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 86893
:
142780
|
142781
|
143409