WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-86831-20120518182617.patch (text/plain), 35.79 KB, created by
Kentaro Hara
on 2012-05-18 02:26:18 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Kentaro Hara
Created:
2012-05-18 02:26:18 PDT
Size:
35.79 KB
patch
obsolete
>Subversion Revision: 117559 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index a1bffb9f4b868d3bee615846531598f8216fe464..d28abc0253c5b8d0f60f9f86d84c696fee9bf6e1 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,82 @@ >+2012-05-18 Kentaro Hara <haraken@chromium.org> >+ >+ [V8] Remove V8Proxy::notHandledByInterceptor() >+ https://bugs.webkit.org/show_bug.cgi?id=86831 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This patch replaces 'return V8Proxy::notHandledByInterceptor()' >+ with 'return v8::Handle<v8::Value>()'. See the discussion in >+ https://bugs.webkit.org/show_bug.cgi?id=85330 for more details. >+ >+ No tests. No change in behavior. >+ >+ * bindings/scripts/CodeGeneratorV8.pm: >+ (GenerateOverloadedFunctionCallback): >+ (GenerateParametersCheck): >+ * bindings/scripts/test/V8/V8TestObj.cpp: >+ (WebCore::TestObjV8Internal::overloadedMethodCallback): >+ (WebCore::TestObjV8Internal::overloadedMethod1Callback): >+ * bindings/v8/V8Collection.h: >+ (WebCore::collectionNamedPropertyGetter): >+ * bindings/v8/V8DOMWrapper.cpp: >+ (WebCore::V8DOMWrapper::convertEventTargetToV8Object): >+ * bindings/v8/V8NPObject.cpp: >+ (WebCore::npObjectSetProperty): >+ * bindings/v8/V8Proxy.cpp: >+ (WebCore::V8Proxy::runScript): >+ (WebCore::V8Proxy::throwError): >+ * bindings/v8/V8Proxy.h: >+ (WebCore): >+ * bindings/v8/custom/V8ArrayBufferViewCustom.h: >+ (WebCore::constructWebGLArrayWithArrayBufferArgument): >+ (WebCore::setWebGLArrayHelper): >+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: >+ (WebCore::V8CSSStyleDeclaration::namedPropertyGetter): >+ (WebCore::V8CSSStyleDeclaration::namedPropertySetter): >+ * bindings/v8/custom/V8DOMStringMapCustom.cpp: >+ (WebCore::V8DOMStringMap::namedPropertyGetter): >+ * bindings/v8/custom/V8DOMWindowCustom.cpp: >+ (WebCore::V8DOMWindow::indexedPropertyGetter): >+ (WebCore::V8DOMWindow::namedPropertyGetter): >+ * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: >+ (WebCore::V8HTMLAllCollection::namedPropertyGetter): >+ * bindings/v8/custom/V8HTMLCollectionCustom.cpp: >+ (WebCore::V8HTMLCollection::namedPropertyGetter): >+ * bindings/v8/custom/V8HTMLFormElementCustom.cpp: >+ (WebCore::V8HTMLFormElement::indexedPropertyGetter): >+ (WebCore::V8HTMLFormElement::namedPropertyGetter): >+ * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: >+ (WebCore::V8HTMLFrameSetElement::namedPropertyGetter): >+ * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: >+ (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter): >+ * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: >+ (WebCore::npObjectNamedGetter): >+ (WebCore::npObjectNamedSetter): >+ (WebCore::npObjectIndexedGetter): >+ (WebCore::npObjectIndexedSetter): >+ * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: >+ (WebCore::V8HTMLSelectElement::indexedPropertyGetter): >+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp: >+ (WebCore::V8NamedNodeMap::indexedPropertyGetter): >+ (WebCore::V8NamedNodeMap::namedPropertyGetter): >+ * bindings/v8/custom/V8NodeListCustom.cpp: >+ (WebCore::V8NodeList::namedPropertyGetter): >+ * bindings/v8/custom/V8StorageCustom.cpp: >+ (WebCore::storageGetter): >+ (WebCore::V8Storage::namedPropertyGetter): >+ (WebCore::storageSetter): >+ * bindings/v8/custom/V8StyleSheetListCustom.cpp: >+ (WebCore::V8StyleSheetList::namedPropertyGetter): >+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: >+ (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback): >+ (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): >+ (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): >+ (WebCore::V8WebGLRenderingContext::getUniformCallback): >+ (WebCore::vertexAttribAndUniformHelperf): >+ (WebCore::uniformHelperi): >+ (WebCore::uniformMatrixHelper): >+ > 2012-05-17 Ryosuke Niwa <rniwa@webkit.org> > > WebKit erroneously add 1px padding in input elements >diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm b/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm >index d66f84e0c732428de0e90546d9844123924cbc34..f26dca66bb278c4be40b26e061cf66f94e2c407c 100644 >--- a/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm >+++ b/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm >@@ -1347,7 +1347,7 @@ END > } > push(@implContentDecls, <<END); > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > END > push(@implContentDecls, "}\n\n"); > push(@implContentDecls, "#endif // ${conditionalString}\n\n") if $conditionalString; >@@ -1659,7 +1659,7 @@ sub GenerateParametersCheck > if (IsWrapperType($argType)) { > $parameterCheckString .= " if (args.Length() > $paramIndex && !isUndefinedOrNull($argValue) && !V8${argType}::HasInstance($argValue)) {\n"; > $parameterCheckString .= " V8Proxy::throwTypeError();\n"; >- $parameterCheckString .= " return notHandledByInterceptor();\n"; >+ $parameterCheckString .= " return v8::Handle<v8::Value>();\n"; > $parameterCheckString .= " }\n"; > } > } >diff --git a/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp b/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp >index e2d10cfbc71e727493ef8385a9977d94b009fb56..e557def5e63773f4fb0a05058b23b9373981dbf0 100644 >--- a/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp >+++ b/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp >@@ -1796,7 +1796,7 @@ static v8::Handle<v8::Value> overloadedMethodCallback(const v8::Arguments& args) > if ((args.Length() == 1 && (args[0]->IsNull() || args[0]->IsArray()))) > return overloadedMethod7Callback(args); > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > static v8::Handle<v8::Value> classMethodCallback(const v8::Arguments& args) >@@ -1854,7 +1854,7 @@ static v8::Handle<v8::Value> overloadedMethod1Callback(const v8::Arguments& args > if ((args.Length() == 1 && (args[0]->IsNull() || args[0]->IsUndefined() || args[0]->IsString() || args[0]->IsObject()))) > return overloadedMethod12Callback(args); > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > #endif // ENABLE(Condition1) >diff --git a/Source/WebCore/bindings/v8/V8Collection.h b/Source/WebCore/bindings/v8/V8Collection.h >index 136204d029df4a1a2c8158779157ae453b942c7e..6eade960e3504643bd5846b6acb47bb389d54fde 100644 >--- a/Source/WebCore/bindings/v8/V8Collection.h >+++ b/Source/WebCore/bindings/v8/V8Collection.h >@@ -74,9 +74,9 @@ template<class Collection, class ItemType> static v8::Handle<v8::Value> getNamed > template<class Collection, class ItemType> static v8::Handle<v8::Value> collectionNamedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) > { > if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > if (info.Holder()->HasRealNamedCallbackProperty(name)) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return getNamedPropertyOfCollection<Collection, ItemType>(name, info.Holder(), info.GetIsolate()); > } >diff --git a/Source/WebCore/bindings/v8/V8DOMWrapper.cpp b/Source/WebCore/bindings/v8/V8DOMWrapper.cpp >index 2cd79a97299e7b64049253eb46869a502056c04b..2c4b9ff2470b903c23d32ce15b9d1739a4db1400 100644 >--- a/Source/WebCore/bindings/v8/V8DOMWrapper.cpp >+++ b/Source/WebCore/bindings/v8/V8DOMWrapper.cpp >@@ -265,7 +265,7 @@ v8::Handle<v8::Value> V8DOMWrapper::convertEventTargetToV8Object(EventTarget* ta > DOM_EVENT_TARGET_INTERFACES_FOR_EACH(TRY_TO_WRAP_WITH_INTERFACE) > > ASSERT_NOT_REACHED(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > PassRefPtr<EventListener> V8DOMWrapper::getEventListener(v8::Local<v8::Value> value, bool isAttribute, ListenerLookupType lookup) >diff --git a/Source/WebCore/bindings/v8/V8NPObject.cpp b/Source/WebCore/bindings/v8/V8NPObject.cpp >index 5a58d827226a9276fa87bd874199ba19c358eea3..50bb57eb899065c4affa436483b82488548a00cd 100644 >--- a/Source/WebCore/bindings/v8/V8NPObject.cpp >+++ b/Source/WebCore/bindings/v8/V8NPObject.cpp >@@ -289,7 +289,7 @@ static v8::Handle<v8::Value> npObjectSetProperty(v8::Local<v8::Object> self, NPI > if (success) > return value; // Intercept the call. > } >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > >diff --git a/Source/WebCore/bindings/v8/V8Proxy.cpp b/Source/WebCore/bindings/v8/V8Proxy.cpp >index bd2c078c146fb6739bd71bb7f950da5a68428bb7..e813caa846ba123416cf54b106af0ab7fada11ef 100644 >--- a/Source/WebCore/bindings/v8/V8Proxy.cpp >+++ b/Source/WebCore/bindings/v8/V8Proxy.cpp >@@ -342,7 +342,7 @@ v8::Local<v8::Value> V8Proxy::evaluate(const ScriptSourceCode& source, Node* nod > v8::Local<v8::Value> V8Proxy::runScript(v8::Handle<v8::Script> script) > { > if (script.IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Local<v8::Value>(); > > V8GCController::checkMemoryUsage(); > if (V8RecursionScope::recursionLevel() >= kMaxRecursionDepth) >@@ -369,11 +369,11 @@ v8::Local<v8::Value> V8Proxy::runScript(v8::Handle<v8::Script> script) > // Handle V8 internal error situation (Out-of-memory). > if (tryCatch.HasCaught()) { > ASSERT(result.IsEmpty()); >- return notHandledByInterceptor(); >+ return v8::Local<v8::Value>(); > } > > if (result.IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Local<v8::Value>(); > > if (v8::V8::IsDead()) > handleFatalErrorInV8(); >@@ -627,7 +627,7 @@ v8::Handle<v8::Value> V8Proxy::throwError(ErrorType type, const char* message, v > return v8::ThrowException(v8::Exception::Error(v8String(message, isolate))); > default: > ASSERT_NOT_REACHED(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > } > >diff --git a/Source/WebCore/bindings/v8/V8Proxy.h b/Source/WebCore/bindings/v8/V8Proxy.h >index e5e947103c153a9e99568cc8de76de0a9a56b8f9..4bc6905a2fb606808958056325a230767be2d684 100644 >--- a/Source/WebCore/bindings/v8/V8Proxy.h >+++ b/Source/WebCore/bindings/v8/V8Proxy.h >@@ -313,13 +313,6 @@ namespace WebCore { > > v8::Local<v8::Context> toV8Context(ScriptExecutionContext*, const WorldContextHandle& worldContext); > >- // Used by an interceptor callback that it hasn't found anything to >- // intercept. >- inline static v8::Local<v8::Object> notHandledByInterceptor() >- { >- return v8::Local<v8::Object>(); >- } >- > inline v8::Handle<v8::Primitive> throwError(const char* message, V8Proxy::ErrorType type, v8::Isolate* isolate = 0) > { > if (!v8::V8::IsExecutionTerminating()) >diff --git a/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h b/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h >index e3c23124218fdc1e211dd313ee7ab0a8163d9128..37f7c66c70251b6b0011304ef151d774b84ec9d0 100644 >--- a/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h >+++ b/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h >@@ -82,7 +82,7 @@ v8::Handle<v8::Value> constructWebGLArrayWithArrayBufferArgument(const v8::Argum > RefPtr<ArrayClass> array = ArrayClass::create(buf, offset, length); > if (!array) { > V8Proxy::setDOMException(INDEX_SIZE_ERR, args.GetIsolate()); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > // Transform the holder into a wrapper object for the array. > V8DOMWrapper::setDOMWrapper(args.Holder(), type, array.get()); >@@ -190,7 +190,7 @@ v8::Handle<v8::Value> setWebGLArrayHelper(const v8::Arguments& args) > { > if (args.Length() < 1) { > V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate()); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > CPlusPlusArrayType* impl = JavaScriptWrapperArrayType::toNative(args.Holder()); >@@ -231,7 +231,7 @@ v8::Handle<v8::Value> setWebGLArrayHelper(const v8::Arguments& args) > } > > V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate()); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > } >diff --git a/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp b/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp >index 5308efe50399d8a55b8263682b6334be4c50d025..ec7330ff8c476fd217b0f14cee640c522937c208 100644 >--- a/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp >@@ -195,14 +195,14 @@ v8::Handle<v8::Value> V8CSSStyleDeclaration::namedPropertyGetter(v8::Local<v8::S > INC_STATS("DOM.CSSStyleDeclaration.NamedPropertyGetter"); > // First look for API defined attributes on the style declaration object. > if (info.Holder()->HasRealNamedCallbackProperty(name)) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > // Search the style declaration. > CSSPropertyInfo* propInfo = cssPropertyInfo(name); > > // Do not handle non-property names. > if (!propInfo) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder()); > RefPtr<CSSValue> cssValue = imp->getPropertyCSSValueInternal(static_cast<CSSPropertyID>(propInfo->propID)); >@@ -228,7 +228,7 @@ v8::Handle<v8::Value> V8CSSStyleDeclaration::namedPropertySetter(v8::Local<v8::S > CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder()); > CSSPropertyInfo* propInfo = cssPropertyInfo(name); > if (!propInfo) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > String propertyValue = toWebCoreStringWithNullCheck(value); > if (propInfo->hadPixelOrPosPrefix) >diff --git a/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp b/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp >index 9335e09801609b8a1c8f8b9ead84bf69e1515ac1..284c73ecc1b8cef16a5223ebdf55e5661e6b8028 100644 >--- a/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp >@@ -51,7 +51,7 @@ v8::Handle<v8::Value> V8DOMStringMap::namedPropertyGetter(v8::Local<v8::String> > INC_STATS("DOM.DOMStringMap.NamedPropertyGetter"); > String value = V8DOMStringMap::toNative(info.Holder())->item(toWebCoreString(name)); > if (value.isNull()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > return v8StringOrUndefined(value); > } > >diff --git a/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp b/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp >index 2abcf3ca6218b9bf2d35679d8186bc080f8b9094..73208ab50eba004082801a60cff37c59a64ce9e3 100644 >--- a/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp >@@ -473,17 +473,17 @@ v8::Handle<v8::Value> V8DOMWindow::indexedPropertyGetter(uint32_t index, const v > > DOMWindow* window = V8DOMWindow::toNative(info.Holder()); > if (!window) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > Frame* frame = window->frame(); > if (!frame) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > Frame* child = frame->tree()->scopedChild(index); > if (child) > return toV8(child->domWindow(), info.GetIsolate()); > >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > >@@ -493,12 +493,12 @@ v8::Handle<v8::Value> V8DOMWindow::namedPropertyGetter(v8::Local<v8::String> nam > > DOMWindow* window = V8DOMWindow::toNative(info.Holder()); > if (!window) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > Frame* frame = window->frame(); > // window is detached from a frame. > if (!frame) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > // Search sub-frames. > AtomicString propName = v8StringToAtomicWebCoreString(name); >@@ -508,7 +508,7 @@ v8::Handle<v8::Value> V8DOMWindow::namedPropertyGetter(v8::Local<v8::String> nam > > // Search IDL functions defined in the prototype > if (!info.Holder()->GetRealNamedProperty(name).IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > // Search named items in the document. > Document* doc = frame->document(); >@@ -524,7 +524,7 @@ v8::Handle<v8::Value> V8DOMWindow::namedPropertyGetter(v8::Local<v8::String> nam > } > } > >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp >index 0a0594833e6b7bb337f3bed9ad2c189e5ef7d6f3..c97a612d7c6aa301a33e93167e8a82e91f0708d6 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp >@@ -76,9 +76,9 @@ v8::Handle<v8::Value> V8HTMLAllCollection::namedPropertyGetter(v8::Local<v8::Str > INC_STATS("DOM.HTMLAllCollection.NamedPropertyGetter"); > > if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > if (info.Holder()->HasRealNamedCallbackProperty(name)) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > HTMLAllCollection* imp = V8HTMLAllCollection::toNative(info.Holder()); > return getNamedItems(imp, v8StringToAtomicWebCoreString(name), info.GetIsolate()); >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp >index 2f1ea54e8e26e9c63c3a22683ee2339ac36746e2..910747bedef6ccfc618c97324a0f36251922e327 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp >@@ -65,9 +65,9 @@ v8::Handle<v8::Value> V8HTMLCollection::namedPropertyGetter(v8::Local<v8::String > INC_STATS("DOM.HTMLCollection.NamedPropertyGetter"); > > if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > if (info.Holder()->HasRealNamedCallbackProperty(name)) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > HTMLCollection* imp = V8HTMLCollection::toNative(info.Holder()); > return getNamedItems(imp, v8StringToAtomicWebCoreString(name), info.GetIsolate()); >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp >index f8524c1600aac241578e665d4df5785dfef6387b..4e6292db7b6e62e7ec1a8238095dbbf529180f83 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp >@@ -48,7 +48,7 @@ v8::Handle<v8::Value> V8HTMLFormElement::indexedPropertyGetter(uint32_t index, c > > RefPtr<Node> formElement = form->elements()->item(index); > if (!formElement) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > return toV8(formElement.release(), info.GetIsolate()); > } > >@@ -65,7 +65,7 @@ v8::Handle<v8::Value> V8HTMLFormElement::namedPropertyGetter(v8::Local<v8::Strin > Vector<RefPtr<Node> > elements; > imp->getNamedElements(v, elements); > if (elements.isEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > // Second call may return different results from the first call, >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp >index 16cd59daaaf06ade0c457807d34f955de39a5264..137f91bbf3b00fed064490d16f9635a4ea03779c 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp >@@ -57,7 +57,7 @@ v8::Handle<v8::Value> V8HTMLFrameSetElement::namedPropertyGetter(v8::Local<v8::S > if (Frame* frame = doc->frame()) > return toV8(frame->domWindow(), info.GetIsolate()); > } >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > } // namespace WebCore >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp >index d595d0eec24ebce4a9ed8fc851bb85241f06be4d..2ec6f119bcba3a6afdf7c1ae056bb123c325176e 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp >@@ -121,7 +121,7 @@ v8::Handle<v8::Value> V8HTMLOptionsCollection::indexedPropertyGetter(uint32_t in > > RefPtr<Node> result = collection->item(index); > if (!result) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return toV8(result.release(), info.GetIsolate()); > } >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp >index 1c114c5f350cc422d10416cb3b2b295e3d3e4e51..b3f7d32c618fa469470611be645bff3bae37b205 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp >@@ -50,11 +50,11 @@ static v8::Handle<v8::Value> npObjectNamedGetter(v8::Local<v8::String> name, con > HTMLPlugInElement* imp = C::toNative(info.Holder()); > ScriptInstance scriptInstance = imp->getInstance(); > if (!scriptInstance) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance()); > if (instance.IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return npObjectGetNamedProperty(instance, name); > } >@@ -65,11 +65,11 @@ static v8::Handle<v8::Value> npObjectNamedSetter(v8::Local<v8::String> name, v8: > HTMLPlugInElement* imp = C::toNative(info.Holder()); > ScriptInstance scriptInstance = imp->getInstance(); > if (!scriptInstance) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance()); > if (instance.IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return npObjectSetNamedProperty(instance, name, value); > } >@@ -135,11 +135,11 @@ v8::Handle<v8::Value> npObjectIndexedGetter(uint32_t index, const v8::AccessorIn > HTMLPlugInElement* imp = C::toNative(info.Holder()); > ScriptInstance scriptInstance = imp->getInstance(); > if (!scriptInstance) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance()); > if (instance.IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return npObjectGetIndexedProperty(instance, index); > } >@@ -151,11 +151,11 @@ v8::Handle<v8::Value> npObjectIndexedSetter(uint32_t index, v8::Local<v8::Value> > HTMLPlugInElement* imp = C::toNative(info.Holder()); > ScriptInstance scriptInstance = imp->getInstance(); > if (!scriptInstance) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance()); > if (instance.IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return npObjectSetIndexedProperty(instance, index, value); > } >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp >index e1d5914aa701def9f850cbca506707243444a56a..015be3a0c6221b146586834508772a302955a031 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp >@@ -51,7 +51,7 @@ v8::Handle<v8::Value> V8HTMLSelectElement::indexedPropertyGetter(uint32_t index, > ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder())); > RefPtr<Node> result = V8HTMLSelectElement::toNative(info.Holder())->item(index); > if (!result) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return toV8(result.release(), info.GetIsolate()); > } >diff --git a/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp b/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp >index d869dc3b609a1f4e359df3c86df4c794ab87f321..47feb043551845c65cc230b5a8f9db711d2fb37d 100644 >--- a/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp >@@ -49,7 +49,7 @@ v8::Handle<v8::Value> V8NamedNodeMap::indexedPropertyGetter(uint32_t index, cons > NamedNodeMap* imp = V8NamedNodeMap::toNative(info.Holder()); > RefPtr<Node> result = imp->item(index); > if (!result) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return toV8(result.release(), info.GetIsolate()); > } >@@ -59,14 +59,14 @@ v8::Handle<v8::Value> V8NamedNodeMap::namedPropertyGetter(v8::Local<v8::String> > INC_STATS("DOM.NamedNodeMap.NamedPropertyGetter"); > > if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > if (info.Holder()->HasRealNamedCallbackProperty(name)) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > NamedNodeMap* imp = V8NamedNodeMap::toNative(info.Holder()); > RefPtr<Node> result = imp->getNamedItem(toWebCoreString(name)); > if (!result) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return toV8(result.release(), info.GetIsolate()); > } >diff --git a/Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp b/Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp >index b1e58261a2a977242e1ebb1239c4faafff05a141..656b9d5105d224f2032dd24234b1a3bb95739f0f 100644 >--- a/Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp >@@ -54,7 +54,7 @@ v8::Handle<v8::Value> V8NodeList::namedPropertyGetter(v8::Local<v8::String> name > > RefPtr<Node> result = list->itemWithName(key); > if (!result) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return toV8(result.release(), info.GetIsolate()); > } >diff --git a/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp b/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp >index 4247fde98990518f5b9882298ab6304efe4add41..f2793489b595bc43be0847ff8e93837f0580f7ca 100644 >--- a/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp >@@ -61,7 +61,7 @@ static v8::Handle<v8::Value> storageGetter(v8::Local<v8::String> v8Name, const v > if (name != "length" && storage->contains(name)) > return v8String(storage->getItem(name)); > >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > > v8::Handle<v8::Value> V8Storage::indexedPropertyGetter(uint32_t index, const v8::AccessorInfo& info) >@@ -75,7 +75,7 @@ v8::Handle<v8::Value> V8Storage::namedPropertyGetter(v8::Local<v8::String> name, > { > INC_STATS("DOM.Storage.NamedPropertyGetter"); > if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > return storageGetter(name, info); > } > >@@ -103,7 +103,7 @@ static v8::Handle<v8::Value> storageSetter(v8::Local<v8::String> v8Name, v8::Loc > return v8Value; > > if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(v8Name).IsEmpty()) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > ExceptionCode ec = 0; > storage->setItem(name, value, ec); >diff --git a/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp b/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp >index e28665490f8c8dbb68a62fe475936c9b2ecdcb4f..879449043ddb560750a9955d52244458c87c97ba 100644 >--- a/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp >@@ -44,13 +44,13 @@ v8::Handle<v8::Value> V8StyleSheetList::namedPropertyGetter(v8::Local<v8::String > INC_STATS("DOM.StyleSheetList.NamedPropertyGetter"); > > if (info.Holder()->HasRealNamedProperty(name)) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > // Search style sheet. > StyleSheetList* imp = V8StyleSheetList::toNative(info.Holder()); > HTMLStyleElement* item = imp->getNamedItem(toWebCoreString(name)); > if (!item) >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > > return toV8(item->sheet(), info.GetIsolate()); > } >diff --git a/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp b/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp >index 47a32e593afd8f7d6fa0aff25bf29c48afb51b3e..b1cf203d897e2af2eb5fd9c33e945cdaf5a52197 100644 >--- a/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp >@@ -275,7 +275,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getAttachedShadersCallback(const > WebGLRenderingContext* context = V8WebGLRenderingContext::toNative(args.Holder()); > if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLProgram::HasInstance(args[0])) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > WebGLProgram* program = V8WebGLProgram::HasInstance(args[0]) ? V8WebGLProgram::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0; > Vector<RefPtr<WebGLShader> > shaders; >@@ -358,7 +358,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getProgramParameterCallback(const > WebGLRenderingContext* context = V8WebGLRenderingContext::toNative(args.Holder()); > if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLProgram::HasInstance(args[0])) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > WebGLProgram* program = V8WebGLProgram::HasInstance(args[0]) ? V8WebGLProgram::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0; > unsigned pname = toInt32(args[1]); >@@ -387,7 +387,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getShaderParameterCallback(const > WebGLRenderingContext* context = V8WebGLRenderingContext::toNative(args.Holder()); > if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLShader::HasInstance(args[0])) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > WebGLShader* shader = V8WebGLShader::HasInstance(args[0]) ? V8WebGLShader::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0; > unsigned pname = toInt32(args[1]); >@@ -430,13 +430,13 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getUniformCallback(const v8::Argu > WebGLRenderingContext* context = V8WebGLRenderingContext::toNative(args.Holder()); > if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLProgram::HasInstance(args[0])) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > WebGLProgram* program = V8WebGLProgram::HasInstance(args[0]) ? V8WebGLProgram::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0; > > if (args.Length() > 1 && !isUndefinedOrNull(args[1]) && !V8WebGLUniformLocation::HasInstance(args[1])) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > bool ok = false; > WebGLUniformLocation* location = toWebGLUniformLocation(args[1], ok); >@@ -506,7 +506,7 @@ static v8::Handle<v8::Value> vertexAttribAndUniformHelperf(const v8::Arguments& > else { > if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLUniformLocation::HasInstance(args[0])) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > location = toWebGLUniformLocation(args[0], ok); > } >@@ -535,7 +535,7 @@ static v8::Handle<v8::Value> vertexAttribAndUniformHelperf(const v8::Arguments& > > if (args[1].IsEmpty() || !args[1]->IsArray()) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > v8::Handle<v8::Array> array = > v8::Local<v8::Array>::Cast(args[1]); >@@ -544,7 +544,7 @@ static v8::Handle<v8::Value> vertexAttribAndUniformHelperf(const v8::Arguments& > if (!data) { > // FIXME: consider different / better exception type. > V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate()); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > ExceptionCode ec = 0; > switch (functionToCall) { >@@ -582,7 +582,7 @@ static v8::Handle<v8::Value> uniformHelperi(const v8::Arguments& args, > WebGLRenderingContext* context = V8WebGLRenderingContext::toNative(args.Holder()); > if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLUniformLocation::HasInstance(args[0])) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > bool ok = false; > WebGLUniformLocation* location = toWebGLUniformLocation(args[0], ok); >@@ -605,7 +605,7 @@ static v8::Handle<v8::Value> uniformHelperi(const v8::Arguments& args, > > if (args[1].IsEmpty() || !args[1]->IsArray()) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > v8::Handle<v8::Array> array = > v8::Local<v8::Array>::Cast(args[1]); >@@ -614,7 +614,7 @@ static v8::Handle<v8::Value> uniformHelperi(const v8::Arguments& args, > if (!data) { > // FIXME: consider different / better exception type. > V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate()); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > ExceptionCode ec = 0; > switch (functionToCall) { >@@ -697,7 +697,7 @@ static v8::Handle<v8::Value> uniformMatrixHelper(const v8::Arguments& args, > > if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLUniformLocation::HasInstance(args[0])) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > bool ok = false; > WebGLUniformLocation* location = toWebGLUniformLocation(args[0], ok); >@@ -720,7 +720,7 @@ static v8::Handle<v8::Value> uniformMatrixHelper(const v8::Arguments& args, > > if (args[2].IsEmpty() || !args[2]->IsArray()) { > V8Proxy::throwTypeError(); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > v8::Handle<v8::Array> array = > v8::Local<v8::Array>::Cast(args[2]); >@@ -729,7 +729,7 @@ static v8::Handle<v8::Value> uniformMatrixHelper(const v8::Arguments& args, > if (!data) { > // FIXME: consider different / better exception type. > V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate()); >- return notHandledByInterceptor(); >+ return v8::Handle<v8::Value>(); > } > ExceptionCode ec = 0; > switch (matrixSize) {
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=142672">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
abarth
:
review+
webkit.review.bot
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 86831
: 142672 |
142929