Attachment 141368 Details for Bug 85870 – Patch.

[patch] Patch.

fullscreen05.patch (text/plain), 13.83 KB, created by Kihong Kwon on 2012-05-11 03:13:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kihong Kwon

Created: 2012-05-11 03:13:04 PDT

Size: 13.83 KB

patch

obsolete

>diff --git a/ChangeLog b/ChangeLog
>index 37dad73..5478e1b 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,14 @@
>+2012-05-11  Kihong Kwon  <kihong.kwon@samsung.com>
>+
>+        [EFL] Enable Fullscreen API
>+        https://bugs.webkit.org/show_bug.cgi?id=85870
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable FULLSCREEN_API on the Efl port.
>+
>+        * Source/cmake/OptionsEfl.cmake:
>+
> 2012-05-10  MORITA Hajime  <morrita@google.com>
> 
>         ElementShadow should minimize the usage of "ShadowRoot" name
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 8f1a399..fce1b37 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,23 @@
>+2012-05-11  Kihong Kwon  <kihong.kwon@samsung.com>
>+
>+        [EFL] Enable Fullscreen API
>+        https://bugs.webkit.org/show_bug.cgi?id=85870
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/efl/Skipped: Remove fullscreen/video-controls-override.html.
>+        * platform/efl/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
>+        * platform/efl/fullscreen/full-screen-placeholder-expected.txt: Added.
>+        * platform/efl/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
>+        * platform/efl/fullscreen/full-screen-render-inline-expected.txt: Added.
>+        * platform/efl/fullscreen/full-screen-stacking-context-expected.png: Added.
>+        * platform/efl/fullscreen/full-screen-zIndex-after-expected.png: Added.
>+        * platform/efl/fullscreen/full-screen-zIndex-expected.png: Added.
>+        * platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
>+        * platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
>+        * platform/efl/test_expectations.txt: Remove fullscreen and media/video-play-require-user-gesture.html
>+          - Add full-screen-keyboard-disabled.html and video-controls-drag.html to the efl's test_expectation.txt
>+
> 2012-05-10  Andrey Kosyakov  <caseq@chromium.org>
> 
>         Web Inspector: [Extensions API] add audit formatters for remote objects and DOM elements
>diff --git a/LayoutTests/platform/efl/Skipped b/LayoutTests/platform/efl/Skipped
>index fddd07e..c2acd95 100644
>--- a/LayoutTests/platform/efl/Skipped
>+++ b/LayoutTests/platform/efl/Skipped
>@@ -346,7 +346,6 @@ editing/spelling/spellcheck-paste-disabled.html
> http/tests/globalhistory/history-delegate-basic-visited-links.html
> 
> # EFL's LayoutTestController does not implement shadowPseudoId
>-fullscreen/video-controls-override.html
> media/video-controls-transformed.html
> media/video-controls-visible-audio-only.html
> media/video-controls-zoomed.html
>diff --git a/LayoutTests/platform/efl/fullscreen/full-screen-iframe-zIndex-expected.png b/LayoutTests/platform/efl/fullscreen/full-screen-iframe-zIndex-expected.png
>new file mode 100644
>index 0000000..b6acda8
>Binary files /dev/null and b/LayoutTests/platform/efl/fullscreen/full-screen-iframe-zIndex-expected.png differ
>diff --git a/LayoutTests/platform/efl/fullscreen/full-screen-placeholder-expected.txt b/LayoutTests/platform/efl/fullscreen/full-screen-placeholder-expected.txt
>new file mode 100644
>index 0000000..1f13896
>--- /dev/null
>+++ b/LayoutTests/platform/efl/fullscreen/full-screen-placeholder-expected.txt
>@@ -0,0 +1,17 @@
>+This layout test checks that the offset positions of the blue and green divs does not change when the red div enters full-screen mode. Press go full-screen to begin.
>+One
>+Two
>+EVENT(webkitfullscreenchange)
>+EXPECTED (document.webkitCurrentFullScreenElement == '[object HTMLDivElement]') OK
>+EXPECTED (one.offsetLeft == '68') OK
>+EXPECTED (one.offsetTop == '70') OK
>+EXPECTED (two.offsetLeft == '8') OK
>+EXPECTED (two.offsetTop == '130') OK
>+EVENT(webkitfullscreenchange)
>+EXPECTED (document.webkitCurrentFullScreenElement == 'null') OK
>+EXPECTED (one.offsetLeft == '68') OK
>+EXPECTED (one.offsetTop == '70') OK
>+EXPECTED (two.offsetLeft == '8') OK
>+EXPECTED (two.offsetTop == '130') OK
>+END OF TEST
>+
>diff --git a/LayoutTests/platform/efl/fullscreen/full-screen-remove-ancestor-after-expected.png b/LayoutTests/platform/efl/fullscreen/full-screen-remove-ancestor-after-expected.png
>new file mode 100644
>index 0000000..61afbf6
>Binary files /dev/null and b/LayoutTests/platform/efl/fullscreen/full-screen-remove-ancestor-after-expected.png differ
>diff --git a/LayoutTests/platform/efl/fullscreen/full-screen-render-inline-expected.txt b/LayoutTests/platform/efl/fullscreen/full-screen-render-inline-expected.txt
>new file mode 100644
>index 0000000..7c3b817
>--- /dev/null
>+++ b/LayoutTests/platform/efl/fullscreen/full-screen-render-inline-expected.txt
>@@ -0,0 +1,24 @@
>+layer at (0,0) size 800x600
>+  RenderView at (0,0) size 800x600
>+layer at (0,0) size 800x600
>+  RenderBlock {HTML} at (0,0) size 800x600
>+    RenderBody {BODY} at (8,8) size 784x584
>+      RenderBlock {SUMMARY} at (0,0) size 784x48
>+        RenderBlock (anonymous) at (0,0) size 784x0
>+        RenderBlock (anonymous) at (0,0) size 784x0
>+        RenderBlock (anonymous) at (0,0) size 784x16
>+          RenderText {#text} at (0,0) size 16x17
>+            text run at (0,0) width 16: "a"
>+          RenderInline {SPAN} at (0,0) size 16x17
>+            RenderText {#text} at (16,0) size 16x17
>+              text run at (16,0) width 16: "b"
>+        RenderBlock (anonymous) at (0,16) size 784x16
>+          RenderBlock {DIV} at (0,0) size 784x16
>+            RenderText {#text} at (0,0) size 16x17
>+              text run at (0,0) width 16: "c"
>+        RenderBlock (anonymous) at (0,32) size 784x16
>+          RenderInline {SPAN} at (0,0) size 16x17
>+            RenderText {#text} at (0,0) size 16x17
>+              text run at (0,0) width 16: "d"
>+          RenderText {#text} at (16,0) size 16x17
>+            text run at (16,0) width 16: "e"
>diff --git a/LayoutTests/platform/efl/fullscreen/full-screen-stacking-context-expected.png b/LayoutTests/platform/efl/fullscreen/full-screen-stacking-context-expected.png
>new file mode 100644
>index 0000000..4a32e0b
>Binary files /dev/null and b/LayoutTests/platform/efl/fullscreen/full-screen-stacking-context-expected.png differ
>diff --git a/LayoutTests/platform/efl/fullscreen/full-screen-zIndex-after-expected.png b/LayoutTests/platform/efl/fullscreen/full-screen-zIndex-after-expected.png
>new file mode 100644
>index 0000000..317f380
>Binary files /dev/null and b/LayoutTests/platform/efl/fullscreen/full-screen-zIndex-after-expected.png differ
>diff --git a/LayoutTests/platform/efl/fullscreen/full-screen-zIndex-expected.png b/LayoutTests/platform/efl/fullscreen/full-screen-zIndex-expected.png
>new file mode 100644
>index 0000000..d4c6b33
>Binary files /dev/null and b/LayoutTests/platform/efl/fullscreen/full-screen-zIndex-expected.png differ
>diff --git a/LayoutTests/platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png b/LayoutTests/platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png
>new file mode 100644
>index 0000000..6f86141
>Binary files /dev/null and b/LayoutTests/platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png differ
>diff --git a/LayoutTests/platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt b/LayoutTests/platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt
>new file mode 100644
>index 0000000..4097911
>--- /dev/null
>+++ b/LayoutTests/platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt
>@@ -0,0 +1,21 @@
>+layer at (0,0) size 800x600
>+  RenderView at (0,0) size 800x600
>+layer at (0,0) size 800x600
>+  RenderBlock {HTML} at (0,0) size 800x600
>+    RenderBody {BODY} at (8,8) size 784x584
>+      RenderBlock {DIV} at (0,0) size 784x32
>+        RenderBlock (anonymous) at (0,0) size 784x16
>+          RenderInline {SPAN} at (0,0) size 16x17
>+            RenderText {#text} at (0,0) size 16x17
>+              text run at (0,0) width 16: "1"
>+          RenderText {#text} at (0,0) size 0x0
>+        RenderBlock (anonymous) at (0,16) size 784x16
>+          RenderInline {SPAN} at (0,0) size 16x17
>+            RenderText {#text} at (0,0) size 16x17
>+              text run at (0,0) width 16: "2"
>+        RenderBlock (anonymous) at (0,32) size 784x0
>+          RenderBlock {DIV} at (0,0) size 784x0
>+        RenderBlock (anonymous) at (0,32) size 784x0
>+          RenderInline {SPAN} at (0,0) size 0x0
>+        RenderBlock (anonymous) at (0,32) size 784x0
>+          RenderText {#text} at (0,0) size 0x0
>diff --git a/LayoutTests/platform/efl/test_expectations.txt b/LayoutTests/platform/efl/test_expectations.txt
>index c9096d8..8199354 100644
>--- a/LayoutTests/platform/efl/test_expectations.txt
>+++ b/LayoutTests/platform/efl/test_expectations.txt
>@@ -364,10 +364,6 @@ BUGWK84839 : editing/execCommand/selectAll.html = MISSING
> // EFL's DRT does not print didFailProvisionalLoadWithError messages
> BUGWK85956 : http/tests/loading/pdf-commit-load-callbacks.html = TEXT
> 
>-// The EFL port has no support for the Fullscreen API
>-BUGWK85870 SKIP : fullscreen = FAIL
>-BUGWK85870 : media/video-play-require-user-gesture.html = TEXT
>-
> // Input attribute placeholder reftests are failing.
> BUGWK85603 : fast/forms/placeholder-with-positioned-element.html = IMAGE
> BUGWK85603 : fast/forms/isindex-placeholder.html = IMAGE
>@@ -423,3 +419,7 @@ BUGWK86084 : svg/dom/SVGScriptElement/script-onerror-bubbling.svg = TEXT PASS
> // Tests imported in r116658
> BUGWK85308 : ietestcenter/css3/valuesandunits/units-000.htm = CRASH
> BUGWK85310 : ietestcenter/css3/valuesandunits/units-010.htm = IMAGE
>+
>+// There are not proper result with FULLSCREN_API enabling.
>+BUGWK85870 : fullscreen/full-screen-keyboard-disabled.html = TEXT
>+BUGWK85870 : fullscreen/video-controls-drag.html = TEXT
>diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
>index c7d6d8c..1da780e 100644
>--- a/Source/WebKit/efl/ChangeLog
>+++ b/Source/WebKit/efl/ChangeLog
>@@ -1,3 +1,18 @@
>+2012-05-11  Kihong Kwon  <kihong.kwon@samsung.com>
>+
>+        [EFL] Enable Fullscreen API
>+        https://bugs.webkit.org/show_bug.cgi?id=85870
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebCoreSupport/ChromeClientEfl.cpp:
>+        (WebCore::ChromeClientEfl::supportsFullScreenForElement):
>+        Add check routine if the full screen is enabled by page setting.
>+        * ewk/ewk_view.cpp:
>+        (_Ewk_View_Private_Data):
>+        (_ewk_view_priv_new):
>+        Add full screen setting to be true.
>+
> 2012-05-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
> 
>         Move resumeAnimations to use Internals interface
>diff --git a/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp b/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp
>index 1e7610a..b7e9e72 100644
>--- a/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp
>+++ b/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp
>@@ -68,6 +68,10 @@
> #include "ColorChooserEfl.h"
> #endif
> 
>+#if ENABLE(FULLSCREEN_API)
>+#include "Settings.h"
>+#endif
>+
> using namespace WebCore;
> 
> static inline Evas_Object* kit(Frame* frame)
>@@ -597,10 +601,9 @@ ChromeClient::CompositingTriggerFlags ChromeClientEfl::allowedCompositingTrigger
> #if ENABLE(FULLSCREEN_API)
> bool ChromeClientEfl::supportsFullScreenForElement(const WebCore::Element* element, bool withKeyboard)
> {
>-    if (withKeyboard)
>+    if (!element->document()->page())
>         return false;
>-
>-    return true;
>+    return element->document()->page()->settings()->fullScreenEnabled();
> }
> 
> void ChromeClientEfl::enterFullScreenForElement(WebCore::Element* element)
>diff --git a/Source/WebKit/efl/ewk/ewk_view.cpp b/Source/WebKit/efl/ewk/ewk_view.cpp
>index 8ec867d..0efcbec 100644
>--- a/Source/WebKit/efl/ewk/ewk_view.cpp
>+++ b/Source/WebKit/efl/ewk/ewk_view.cpp
>@@ -694,6 +694,9 @@ static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* smartData)
> #endif
>     priv->pageSettings->setWebGLEnabled(true);
>     priv->pageSettings->setXSSAuditorEnabled(true);
>+#if ENABLE(FULLSCREEN_API)
>+    priv->pageSettings->setFullScreenEnabled(true);
>+#endif
> 
>     url = priv->pageSettings->userStyleSheetLocation();
>     priv->settings.userStylesheet = eina_stringshare_add(url.string().utf8().data());
>diff --git a/Source/cmake/OptionsEfl.cmake b/Source/cmake/OptionsEfl.cmake
>index 983ff65..d848c98 100644
>--- a/Source/cmake/OptionsEfl.cmake
>+++ b/Source/cmake/OptionsEfl.cmake
>@@ -69,6 +69,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FAST_MOBILE_SCROLLING ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS ON)
>+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GLIB_SUPPORT ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API OFF)
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 126ebe7..4ee9fe9 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2012-05-11  Kihong Kwon  <kihong.kwon@samsung.com>
>+
>+        [EFL] Enable Fullscreen API
>+        https://bugs.webkit.org/show_bug.cgi?id=85870
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable FULLSCREEN_API on the Efl port.
>+
>+        * Scripts/webkitperl/FeatureList.pm:
>+
> 2012-05-10  Ojan Vafai  <ojan@chromium.org>
> 
>         Add a perf tab to garden-o-matic
>diff --git a/Tools/Scripts/webkitperl/FeatureList.pm b/Tools/Scripts/webkitperl/FeatureList.pm
>index a4fb535..3bab775 100644
>--- a/Tools/Scripts/webkitperl/FeatureList.pm
>+++ b/Tools/Scripts/webkitperl/FeatureList.pm
>@@ -178,7 +178,7 @@ my @features = (
>       define => "ENABLE_FTPDIR", default => !isWinCE(), value => \$ftpDirSupport },
> 
>     { option => "fullscreen-api", desc => "Toggle Fullscreen API support",
>-      define => "ENABLE_FULLSCREEN_API", default => (isAppleMacWebKit() || isGtk() || isBlackBerry() || isQt()), value => \$fullscreenAPISupport },
>+      define => "ENABLE_FULLSCREEN_API", default => (isAppleMacWebKit() || isEfl() || isGtk() || isBlackBerry() || isQt()), value => \$fullscreenAPISupport },
> 
>     { option => "gamepad", desc => "Toggle Gamepad support",
>       define => "ENABLE_GAMEPAD", default => 0, value => \$gamepadSupport },

Actions: View | Formatted Diff | Diff

Attachments on bug 85870: 140840 | 141130 | 141133 | 141353 | 141368 | 141369 | 141893