Attachment 141005 Details for Bug 85879 – preliminary patch

[patch] preliminary patch

bug85879 (text/plain), 1.79 KB, created by Mikhail Pozdnyakov on 2012-05-09 13:27:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mikhail Pozdnyakov

Created: 2012-05-09 13:27:06 PDT

Size: 1.79 KB

patch

obsolete

>commit b2cf3197e422269c041ca159c59d678be5f6c0b4
>Author: Mikhail Pozdnyakov <pozdnyakov.mikhail@gmail.com>
>Date:   Wed May 9 23:07:10 2012 +0300
>
>    bug85879
>
>diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
>index 776715b..d60bd69 100644
>--- a/Source/WebKit/efl/ChangeLog
>+++ b/Source/WebKit/efl/ChangeLog
>@@ -1,3 +1,17 @@
>+2012-05-09  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
>+
>+        [EFL] fast/frames/frame-crash-with-page-cache.html is crashing
>+        https://bugs.webkit.org/show_bug.cgi?id=85879
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        _ewk_frame_smart_del() is considering now that the frame can be present in cache.
>+        loader()->detachFromParent() is only applied for the main frame.
>+        loader()->cancelAndClear() is not used anymore.
>+
>+        * ewk/ewk_frame.cpp:
>+        (_ewk_frame_smart_del):
>+
> 2012-05-08  Kangil Han  <kangil.han@samsung.com>
> 
>         [EFL][DRT] Implement TextInputController.
>diff --git a/Source/WebKit/efl/ewk/ewk_frame.cpp b/Source/WebKit/efl/ewk/ewk_frame.cpp
>index 24a12ea..23ff58b 100644
>--- a/Source/WebKit/efl/ewk/ewk_frame.cpp
>+++ b/Source/WebKit/efl/ewk/ewk_frame.cpp
>@@ -229,8 +229,9 @@ static void _ewk_frame_smart_del(Evas_Object* ewkFrame)
>         if (smartData->frame) {
>             WebCore::FrameLoaderClientEfl* flc = _ewk_frame_loader_efl_get(smartData->frame);
>             flc->setWebFrame(0);
>-            smartData->frame->loader()->detachFromParent();
>-            smartData->frame->loader()->cancelAndClear();
>+            EWK_FRAME_SD_GET(ewk_view_frame_main_get(smartData->view), msd);
>+            if (msd->frame == smartData->frame) // only for main frame is enough (will traverse through frame tree)
>+                smartData->frame->loader()->detachFromParent();
>             smartData->frame = 0;
>         }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 85879: 141005 | 141114 | 142421