Attachment 140461 Details for Bug 85767 – Patch

[patch] Patch

bug-85767-20120506230345.patch (text/plain), 4.99 KB, created by Mark Pilgrim (Google) on 2012-05-06 20:04:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Pilgrim (Google)

Created: 2012-05-06 20:04:29 PDT

Size: 4.99 KB

patch

obsolete

>Index: Source/Platform/ChangeLog
>===================================================================
>--- Source/Platform/ChangeLog	(revision 116262)
>+++ Source/Platform/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2012-05-06  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Move createOffscreenGraphicsContext3D to Platform.h
>+        https://bugs.webkit.org/show_bug.cgi?id=85767
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part of a refactoring series. See tracking bug 82948.
>+
>+        * chromium/public/Platform.h:
>+        (WebKit):
>+        (Platform):
>+        (WebKit::Platform::createOffscreenGraphicsContext3D):
>+
> 2012-05-04  Tommy Widenflycht  <tommyw@google.com>
> 
>         MediaStream API: Make PeerConnection00's API fully compliant with the draft
>Index: Source/Platform/chromium/public/Platform.h
>===================================================================
>--- Source/Platform/chromium/public/Platform.h	(revision 116255)
>+++ Source/Platform/chromium/public/Platform.h	(working copy)
>@@ -35,11 +35,13 @@
> #include "WebCommon.h"
> #include "WebData.h"
> #include "WebGamepads.h"
>+#include "WebGraphicsContext3D.h"
> #include "WebString.h"
> 
> namespace WebKit {
> 
> class WebAudioBus;
>+class WebGraphicsContext3D;
> class WebMediaStreamCenter;
> class WebMediaStreamCenterClient;
> class WebMimeRegistry;
>@@ -74,6 +76,13 @@ public:
>     virtual void sampleGamepads(WebGamepads& into) { into.length = 0; }
> 
> 
>+    // GPU ----------------------------------------------------------------
>+    //
>+    // May return null if GPU is not supported.
>+    // Returns newly allocated and initialized offscreen WebGraphicsContext3D instance.
>+    virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&) { return 0; }
>+
>+
>     // History -------------------------------------------------------------
> 
>     // Returns the hash for the given canonicalized URL for use in visited
>Index: Source/WebKit/chromium/ChangeLog
>===================================================================
>--- Source/WebKit/chromium/ChangeLog	(revision 116262)
>+++ Source/WebKit/chromium/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2012-05-06  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Move createOffscreenGraphicsContext3D to Platform.h
>+        https://bugs.webkit.org/show_bug.cgi?id=85767
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part of a refactoring series. See tracking bug 82948.
>+
>+        * public/platform/WebKitPlatformSupport.h:
>+        (WebKitPlatformSupport):
>+        * src/GraphicsContext3DChromium.cpp:
>+        (WebCore::GraphicsContext3D::create):
>+
> 2012-05-06  Keishi Hattori  <keishi@webkit.org>
> 
>         [chromium] Add WebKit API to access multiple attribute of input element
>Index: Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
>===================================================================
>--- Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	(revision 116255)
>+++ Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	(working copy)
>@@ -33,7 +33,6 @@
> 
> #include "../WebIDBKeyPath.h" // FIXME: Remove with: http://webkit.org/b/84207
> #include "WebCommon.h"
>-#include "WebGraphicsContext3D.h"
> #include "WebLocalizedString.h"
> #include "WebSerializedScriptValue.h"
> #include "WebString.h"
>@@ -164,10 +163,6 @@ public:
>     virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
> 
>     // GPU ----------------------------------------------------------------
>-    //
>-    // May return null if GPU is not supported.
>-    // Returns newly allocated and initialized offscreen WebGraphicsContext3D instance.
>-    virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&) { return 0; }
> 
>     // Returns true if the platform is capable of producing an offscreen context suitable for accelerating 2d canvas.
>     // This will return false if the platform cannot promise that contexts will be preserved across operations like
>Index: Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
>===================================================================
>--- Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	(revision 116255)
>+++ Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	(working copy)
>@@ -49,8 +49,8 @@
> #include "WebViewClient.h"
> #include "WebViewImpl.h"
> #include "platform/WebGraphicsContext3D.h"
>-#include "platform/WebKitPlatformSupport.h"
> 
>+#include <public/Platform.h>
> #include <stdio.h>
> #include <wtf/FastMalloc.h>
> #include <wtf/text/CString.h>
>@@ -1043,7 +1043,7 @@ PassRefPtr<GraphicsContext3D> GraphicsCo
>     webAttributes.shareResources = attrs.shareResources;
>     webAttributes.preferDiscreteGPU = attrs.preferDiscreteGPU;
> 
>-    OwnPtr<WebKit::WebGraphicsContext3D> webContext = adoptPtr(WebKit::webKitPlatformSupport()->createOffscreenGraphicsContext3D(webAttributes));
>+    OwnPtr<WebKit::WebGraphicsContext3D> webContext = adoptPtr(WebKit::Platform::current()->createOffscreenGraphicsContext3D(webAttributes));
>     if (!webContext)
>         return 0;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 85767: 140461