Attachment 140168 Details for Bug 85503 – EFL' PlatformKeyboardEvent: figures, letters and printscreen key handling

[patch] EFL' PlatformKeyboardEvent: figures, letters and printscreen key handling

bug85503_v2 (text/plain), 4.48 KB, created by Mikhail Pozdnyakov on 2012-05-03 23:45:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mikhail Pozdnyakov

Created: 2012-05-03 23:45:56 PDT

Size: 4.48 KB

patch

obsolete

>commit c7a203e5cbcf5121d92e81d8fd04ddc7106c9d2e
>Author: Mikhail Pozdnyakov <pozdnyakov.mikhail@gmail.com>
>Date:   Thu May 3 18:56:45 2012 +0300
>
>    bug85503
>
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 9afb70d..ceeee64 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2012-05-03  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
>+
>+        [EFL]PlatformKeyboardEvent: figures, letters and printscreen key handling
>+        https://bugs.webkit.org/show_bug.cgi?id=85503
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Bug-related testcases are unskipped.
>+
>+        * platform/efl/Skipped:
>+
> 2012-05-02  Dongwoo Im  <dw.im@samsung.com>
> 
>         [EFL] Implement the Web Audio API feature.
>diff --git a/LayoutTests/platform/efl/Skipped b/LayoutTests/platform/efl/Skipped
>index 89cfbb8..00428fd 100644
>--- a/LayoutTests/platform/efl/Skipped
>+++ b/LayoutTests/platform/efl/Skipped
>@@ -1040,8 +1040,6 @@ fast/events/key-events-in-input-button.html
> fast/events/key-events-in-input-text.html
> fast/events/keydown-numpad-keys.html
> fast/events/option-tab.html
>-fast/events/special-key-events-in-input-text.html
>-fast/forms/enter-clicks-buttons.html
> fast/forms/input-search-press-escape-key.html
> 
> # BUG: not scrolling correctly
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 75f9079..6c3faa8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2012-05-03  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
>+
>+        [EFL]PlatformKeyboardEvent: figures, letters and printscreen key handling
>+        https://bugs.webkit.org/show_bug.cgi?id=85503
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Figures and letters keys are added to the keyMap.
>+        Corrected valure for printscreen key in the windowsKeyMap.
>+        Capital letters keys are added to the windowsKeyMap.
>+
>+        * platform/efl/EflKeyboardUtilities.cpp:
>+        (WebCore::createKeyMap):
>+        (WebCore::createWindowsKeyMap):
>+        (WebCore::singleCharacterString):
>+
> 2012-05-02  Dongwoo Im  <dw.im@samsung.com>
> 
>         [EFL] Implement the Web Audio API feature.
>diff --git a/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp b/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp
>index aa1b5e8..eb9eb76 100644
>--- a/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp
>+++ b/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp
>@@ -78,6 +78,23 @@ static void createKeyMap()
>     keyMap().set("ISO_Left_Tab", "U+0009");
>     keyMap().set("BackSpace", "U+0008");
>     keyMap().set("space", "U+0020");
>+    keyMap().set("Print", "PrintScreen");
>+
>+    // Set alphabet to the keyMap.
>+    const char* lows = "abcdefghijklmnopqrstuvwxyz";
>+    const char* caps = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
>+    const int lowsBase = static_cast<int>(*lows);
>+    const int capsBase = static_cast<int>(*caps);
>+
>+    for (unsigned int i = 0; i < 26; i++) {
>+        keyMap().set(String(lows + i, 1), String::format("U+%04X", lowsBase + i));
>+        keyMap().set(String(caps + i, 1), String::format("U+%04X", capsBase + i));
>+    }
>+
>+    // Set digits to the keyMap
>+    const int digitBase = static_cast<int>('0');
>+    for (unsigned int i = 0; i < 10; i++)
>+        keyMap().set(String::number(i), String::format("U+%04X", digitBase + i));
> }
> 
> static void createWindowsKeyMap()
>@@ -109,7 +126,7 @@ static void createWindowsKeyMap()
>     windowsKeyMap().set("Left", VK_LEFT);
>     windowsKeyMap().set("Up", VK_UP);
>     windowsKeyMap().set("Down", VK_DOWN);
>-    windowsKeyMap().set("Print", VK_PRINT);
>+    windowsKeyMap().set("Print", VK_SNAPSHOT);
>     windowsKeyMap().set("Insert", VK_INSERT);
>     windowsKeyMap().set("Delete", VK_DELETE);
> 
>@@ -133,10 +150,11 @@ static void createWindowsKeyMap()
>     windowsKeyMap().set("quotedbl", VK_OEM_7);
> 
>     // Set alphabet to the windowsKeyMap.
>-    const char* alphabet = "abcdefghijklmnopqrstuvwxyz";
>+    const char* lows = "abcdefghijklmnopqrstuvwxyz";
>+    const char* caps = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
>     for (unsigned int i = 0; i < 26; i++) {
>-        String key(alphabet + i, 1);
>-        windowsKeyMap().set(key, VK_A + i);
>+        windowsKeyMap().set(String(lows + i, 1), VK_A + i);
>+        windowsKeyMap().set(String(caps + i, 1), VK_A + i);
>     }
> 
>     // Set digits to the windowsKeyMap.
>@@ -187,6 +205,8 @@ String singleCharacterString(const String& keyName)
>         return String("\x8");
>     if (keyName == "Tab")
>         return String("\t");
>+    if (keyName == "Print")
>+        return String("");
>     return keyName;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 85503: 140027 | 140168 | 140514 | 142176