Attachment 139756 Details for Bug 85347 – Patch

[patch] Patch

patch_drt_pagevisibility_0502_2.patch (text/plain), 8.37 KB, created by Dongwoo Joshua Im (dwim) on 2012-05-01 23:45:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dongwoo Joshua Im (dwim)

Created: 2012-05-01 23:45:23 PDT

Size: 8.37 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e7f3504..e423f74 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2012-05-01  Dongwoo Im  <dw.im@samsung.com>
>+
>+        [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
>+        https://bugs.webkit.org/show_bug.cgi?id=85347
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platformrm/efl/Skipped: Remove one test case of the Page Visibility API.
>+
> 2012-05-01  Eric Seidel  <eric@webkit.org>
> 
>         Add <iframe seamless> navigation code (and pass all the navigation tests)
>diff --git a/LayoutTests/platform/efl/Skipped b/LayoutTests/platform/efl/Skipped
>index 9492ff2..7ab6b814 100644
>--- a/LayoutTests/platform/efl/Skipped
>+++ b/LayoutTests/platform/efl/Skipped
>@@ -2042,7 +2042,6 @@ http/tests/xmlviewer/extensions-api.html
> fast/events/page-visibility-iframe-move-test.html
> fast/events/page-visibility-iframe-delete-test.html
> fast/events/page-visibility-iframe-propagation-test.html
>-fast/events/page-visibility-transition-test.html
> 
> # These test -apple- and -khtml- prefixed CSS properties, which we don't support.
> inspector/styles/vendor-prefixes.html
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 74ae371..6ec84d5 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,31 @@
>+2012-05-01  Dongwoo Im  <dw.im@samsung.com>
>+
>+        [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
>+        https://bugs.webkit.org/show_bug.cgi?id=85347
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/LayoutTestController.h:
>+        (LayoutTestController):
>+        * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
>+        (LayoutTestController::resetPageVisibility): Not implemented.
>+        (LayoutTestController::setPageVisibility): Not implemented.
>+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
>+        (LayoutTestController::resetPageVisibility): Reset the page visibility.
>+        (LayoutTestController::setPageVisibility): Set the page visibility.
>+        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
>+        (LayoutTestController::resetPageVisibility): Not implemented.
>+        (LayoutTestController::setPageVisibility): Not implemented.
>+        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
>+        (LayoutTestController::resetPageVisibility): Not implemented.
>+        (LayoutTestController::setPageVisibility): Not implemented.
>+        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
>+        (LayoutTestController::resetPageVisibility): Not implemented.
>+        (LayoutTestController::setPageVisibility): Not implemented.
>+        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
>+        (LayoutTestController::resetPageVisibility): Not implemented.
>+        (LayoutTestController::setPageVisibility): Not implemented.
>+
> 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
> 
>         webkitpy: Remove unused platform imports.
>diff --git a/Tools/DumpRenderTree/LayoutTestController.h b/Tools/DumpRenderTree/LayoutTestController.h
>index a11387d..0c23ef0 100644
>--- a/Tools/DumpRenderTree/LayoutTestController.h
>+++ b/Tools/DumpRenderTree/LayoutTestController.h
>@@ -126,9 +126,8 @@ public:
>     void setScrollbarPolicy(JSStringRef orientation, JSStringRef policy);
>     void setEditingBehavior(const char* editingBehavior);
>     void startSpeechInput(JSContextRef inputElement);
>-
>-    void setPageVisibility(const char* visibility) { }
>-    void resetPageVisibility() { }
>+    void setPageVisibility(const char*);
>+    void resetPageVisibility();
> 
>     void waitForPolicyDelegate();
>     size_t webHistoryItemCount();
>diff --git a/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp b/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp
>index a62755b..791c2af 100644
>--- a/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp
>+++ b/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp
>@@ -897,3 +897,12 @@ void LayoutTestController::simulateDesktopNotificationClick(JSStringRef title)
> {
> }
> 
>+void LayoutTestController::resetPageVisibility()
>+{
>+    notImplemented();
>+}
>+
>+void LayoutTestController::setPageVisibility(const char* visibility)
>+{
>+    notImplemented();
>+}
>diff --git a/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp b/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
>index 6c1dd73..9e049b4 100644
>--- a/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
>+++ b/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
>@@ -815,3 +815,19 @@ void LayoutTestController::setBackingScaleFactor(double)
> void LayoutTestController::simulateDesktopNotificationClick(JSStringRef title)
> {
> }
>+
>+void LayoutTestController::resetPageVisibility()
>+{
>+    ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_VISIBLE, true);
>+}
>+
>+void LayoutTestController::setPageVisibility(const char* visibility)
>+{
>+    String newVisibility(visibility);
>+    if (newVisibility == "visible")
>+        ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_VISIBLE, false);
>+    else if (newVisibility == "hidden")
>+        ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_HIDDEN, false);
>+    else if (newVisibility == "prerender")
>+        ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_PRERENDER, false);
>+}
>diff --git a/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp b/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
>index ebeddc3..d8c89e1 100644
>--- a/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
>+++ b/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
>@@ -1031,3 +1031,13 @@ void LayoutTestController::setBackingScaleFactor(double)
> void LayoutTestController::simulateDesktopNotificationClick(JSStringRef title)
> {
> }
>+
>+void LayoutTestController::resetPageVisibility()
>+{
>+    // FIXME: Implement this.
>+}
>+
>+void LayoutTestController::setPageVisibility(const char* visibility)
>+{
>+    // FIXME: Implement this.
>+}
>diff --git a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
>index 0309d0a..bc6bad2 100644
>--- a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
>+++ b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
>@@ -983,6 +983,16 @@ void LayoutTestController::syncLocalStorage()
>     // FIXME: Implement.
> }
> 
>+void LayoutTestController::resetPageVisibility()
>+{
>+    // FIXME: Implement this.
>+}
>+
>+void LayoutTestController::setPageVisibility(const char* visibility)
>+{
>+    // FIXME: Implement this.
>+}
>+
> QString LayoutTestController::layerTreeAsText()
> {
>     return DumpRenderTreeSupportQt::layerTreeAsText(m_drt->webPage()->mainFrame());
>diff --git a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h
>index ebd2279..7a7e952 100644
>--- a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h
>+++ b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h
>@@ -239,6 +239,9 @@ public slots:
>     void setMockSpeechInputDumpRect(bool flag);
>     void startSpeechInput(const QString& inputElement);
> 
>+    void setPageVisibility(const char*);
>+    void resetPageVisibility();
>+
>     // Empty stub method to keep parity with object model exposed by global LayoutTestController.
>     void abortModal() {}
> 
>diff --git a/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp b/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp
>index ae7e09c..9deed0c 100644
>--- a/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp
>+++ b/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp
>@@ -1542,3 +1542,13 @@ void LayoutTestController::simulateDesktopNotificationClick(JSStringRef title)
> {
>     // FIXME: Implement.
> }
>+
>+void LayoutTestController::resetPageVisibility()
>+{
>+    // FIXME: Implement this.
>+}
>+
>+void LayoutTestController::setPageVisibility(const char* visibility)
>+{
>+    // FIXME: Implement this.
>+}
>diff --git a/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp b/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp
>index 5a0fc72..c44bccd 100644
>--- a/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp
>+++ b/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp
>@@ -653,3 +653,13 @@ void LayoutTestController::simulateDesktopNotificationClick(JSStringRef title)
> {
>     // FIXME: Implement.
> }
>+
>+void LayoutTestController::resetPageVisibility()
>+{
>+    // FIXME: Implement this.
>+}
>+
>+void LayoutTestController::setPageVisibility(const char* visibility)
>+{
>+    // FIXME: Implement this.
>+}

Actions: View | Formatted Diff | Diff

Attachments on bug 85347: 139748 | 139751 | 139756