Attachment 139114 Details for Bug 85023 – Patch

[patch] Patch

bug-85023-20120426180216.patch (text/plain), 2.08 KB, created by Kentaro Hara on 2012-04-26 18:02:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-04-26 18:02:17 PDT

Size: 2.08 KB

patch

obsolete

>Subversion Revision: 115388
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 9cfd8be06760a7f45c26eab4c96266d0ab6e7305..9cdb71fba4535226919c8fba38d5c0228bc5220b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2012-04-26  Kentaro Hara  <haraken@chromium.org>
>+
>+        [V8] Pass Isolate to V8BindingPerIsolateData::current()
>+        https://bugs.webkit.org/show_bug.cgi?id=85023
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The objective is to pass Isolate around in V8 bindings.
>+        This patch passes Isolate to V8BindingPerIsolateData::current().
>+
>+        No tests. No change in behavior.
>+
>+        * bindings/v8/V8Binding.h:
>+        (WebCore::V8BindingPerIsolateData::current):
>+        (WebCore::v8ExternalString):
>+
> 2012-04-26  Shawn Singh  <shawnsingh@chromium.org>
> 
>         Re-implement backFaceVisibility to avoid dealing with perspective w < 0 problem
>diff --git a/Source/WebCore/bindings/v8/V8Binding.h b/Source/WebCore/bindings/v8/V8Binding.h
>index ed9d62a5da9903afc5284810312dfc373b8b1c06..1196191d84198d7a1041dd76c5399a39f71122eb 100644
>--- a/Source/WebCore/bindings/v8/V8Binding.h
>+++ b/Source/WebCore/bindings/v8/V8Binding.h
>@@ -105,9 +105,9 @@ namespace WebCore {
>             return static_cast<V8BindingPerIsolateData*>(isolate->GetData()); 
>         }
> 
>-        static V8BindingPerIsolateData* current()
>+        static V8BindingPerIsolateData* current(v8::Isolate* isolate = 0)
>         {
>-            return get(v8::Isolate::GetCurrent());
>+            return isolate ? static_cast<V8BindingPerIsolateData*>(isolate->GetData()) : get(v8::Isolate::GetCurrent());
>         }
>         static void dispose(v8::Isolate*);
> 
>@@ -250,7 +250,7 @@ namespace WebCore {
>         if (!stringImpl)
>             return v8::String::Empty();
> 
>-        V8BindingPerIsolateData* data = isolate ? static_cast<V8BindingPerIsolateData*>(isolate->GetData()) : V8BindingPerIsolateData::current();
>+        V8BindingPerIsolateData* data = V8BindingPerIsolateData::current(isolate);
>         return data->stringCache()->v8ExternalString(stringImpl);
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 85023: 139114