Attachment 138637 Details for Bug 84758 – Patch

[patch] Patch

bug-84758-20120424140229.patch (text/plain), 4.48 KB, created by Kentaro Hara on 2012-04-24 14:02:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-04-24 14:02:30 PDT

Size: 4.48 KB

patch

obsolete

>Subversion Revision: 115078
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index da9352cb1c187c1ffac3affe31e896ef56ab5c85..2b7b5868e02355d49a14a78584d4bb8a35be8ee1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,5 +1,26 @@
> 2012-04-24  Kentaro Hara  <haraken@chromium.org>
> 
>+        [V8] Pass Isolate to SerializedScriptValue::deserialize()
>+        https://bugs.webkit.org/show_bug.cgi?id=84758
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The objective is to pass Isolate around. This patch passes
>+        Isolate to SerializedScriptValue::deserialize().
>+
>+        No tests. No change in behavior.
>+
>+        * bindings/v8/custom/V8HistoryCustom.cpp:
>+        (WebCore::V8History::stateAccessorGetter):
>+        * bindings/v8/custom/V8IDBAnyCustom.cpp:
>+        (WebCore::toV8):
>+        * bindings/v8/custom/V8MessageEventCustom.cpp:
>+        (WebCore::V8MessageEvent::dataAccessorGetter):
>+        * bindings/v8/custom/V8PopStateEventCustom.cpp:
>+        (WebCore::V8PopStateEvent::stateAccessorGetter):
>+
>+2012-04-24  Kentaro Hara  <haraken@chromium.org>
>+
>         [V8] Pass Isolate around in SerializedScriptValue.cpp (Part1)
>         https://bugs.webkit.org/show_bug.cgi?id=84663
> 
>diff --git a/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp
>index abaddcaa155106c8da6bba6ba337fe08541a9849..3c01f1375a931166d151836b046ea147d0fecb24 100644
>--- a/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp
>+++ b/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp
>@@ -53,7 +53,7 @@ v8::Handle<v8::Value> V8History::stateAccessorGetter(v8::Local<v8::String> name,
>         return value;
> 
>     SerializedScriptValue* serialized = history->state();
>-    value = serialized ? serialized->deserialize() : v8::Handle<v8::Value>(v8::Null());
>+    value = serialized ? serialized->deserialize(0, info.GetIsolate()) : v8::Handle<v8::Value>(v8::Null());
>     info.Holder()->SetHiddenValue(V8HiddenPropertyName::state(), value);
> 
>     return value;
>diff --git a/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp b/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp
>index 75edd48d82c3c50010346336483ff7e64c331434..1733ec8bcda3a47e3fb0fa4facf590c66cabcadb 100644
>--- a/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp
>+++ b/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp
>@@ -73,7 +73,7 @@ v8::Handle<v8::Value> toV8(IDBAny* impl, v8::Isolate* isolate)
>     case IDBAny::IDBTransactionType:
>         return toV8(impl->idbTransaction());
>     case IDBAny::SerializedScriptValueType:
>-        return impl->serializedScriptValue()->deserialize();
>+        return impl->serializedScriptValue()->deserialize(0, isolate);
>     }
> 
>     ASSERT_NOT_REACHED();
>diff --git a/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp b/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
>index 3be1b412e9bd3515f6caefda0ff57665a32a2986..5bb0187ae0a80c183de6d900ee63981c60e2e7f9 100644
>--- a/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
>+++ b/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
>@@ -61,7 +61,7 @@ v8::Handle<v8::Value> V8MessageEvent::dataAccessorGetter(v8::Local<v8::String> n
> 
>     case MessageEvent::DataTypeSerializedScriptValue:
>         if (SerializedScriptValue* serializedValue = event->dataAsSerializedScriptValue())
>-            result = serializedValue->deserialize(event->ports());
>+            result = serializedValue->deserialize(event->ports(), info.GetIsolate());
>         else
>             result = v8::Null();
>         break;
>diff --git a/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp b/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp
>index e3700eb900c513389b5d3bfd7a9d001a5f2b24c4..b3d90f4d20b6815e4745433a48105365702b69e7 100644
>--- a/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp
>+++ b/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp
>@@ -79,10 +79,10 @@ v8::Handle<v8::Value> V8PopStateEvent::stateAccessorGetter(v8::Local<v8::String>
>             if (!result.IsEmpty())
>                 return cacheState(info.Holder(), result);
>         }
>-        result = event->serializedState()->deserialize();
>+        result = event->serializedState()->deserialize(0, info.GetIsolate());
>         v8History->SetHiddenValue(V8HiddenPropertyName::state(), result);
>     } else
>-        result = event->serializedState()->deserialize();
>+        result = event->serializedState()->deserialize(0, info.GetIsolate());
> 
>     return cacheState(info.Holder(), result);
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 84758: 138637