Attachment 138413 Details for Bug 84627 – Patch

[patch] Patch

bug-84627-20120423132805.patch (text/plain), 2.04 KB, created by Kentaro Hara on 2012-04-23 13:28:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-04-23 13:28:06 PDT

Size: 2.04 KB

patch

obsolete

>Subversion Revision: 114936
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 04ad9ee672ec64c133c2e8d63963c4716a595537..d3d025e4d0263e7a8e056c79c460b6d046e94e09 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2012-04-23  Kentaro Hara  <haraken@chromium.org>
>+
>+        [V8][Refactoring] Remove V8Proxy::throwSyntaxError()
>+        https://bugs.webkit.org/show_bug.cgi?id=84627
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch removes V8Proxy::throwSyntaxError()
>+        since it is no longer used.
>+
>+        No tests. No change in behavior.
>+
>+        * bindings/v8/V8Proxy.cpp:
>+        * bindings/v8/V8Proxy.h:
>+        (V8Proxy):
>+
> 2012-04-23  Emil A Eklund  <eae@chromium.org>
> 
>         Crash in RenderInline::clippedOverflowRectForRepaint for PrintPreview
>diff --git a/Source/WebCore/bindings/v8/V8Proxy.cpp b/Source/WebCore/bindings/v8/V8Proxy.cpp
>index 82d740aa195f807bf2d613f60bde352270fa7383..72c1d8bcd77a6ca628c44f0f57abda640b1cab7d 100644
>--- a/Source/WebCore/bindings/v8/V8Proxy.cpp
>+++ b/Source/WebCore/bindings/v8/V8Proxy.cpp
>@@ -587,11 +587,6 @@ v8::Handle<v8::Value> V8Proxy::throwTypeError()
>     return throwError(TypeError, "Type error");
> }
> 
>-v8::Handle<v8::Value> V8Proxy::throwSyntaxError()
>-{
>-    return throwError(SyntaxError, "Syntax error");
>-}
>-
> v8::Local<v8::Context> V8Proxy::context(Frame* frame)
> {
>     v8::Local<v8::Context> context = V8Proxy::mainWorldContext(frame);
>diff --git a/Source/WebCore/bindings/v8/V8Proxy.h b/Source/WebCore/bindings/v8/V8Proxy.h
>index 4f542b391b24322a31bb95889e43438d93f547c0..16e2369dc8ffdd9aeb4444c9d9150b82df1c725a 100644
>--- a/Source/WebCore/bindings/v8/V8Proxy.h
>+++ b/Source/WebCore/bindings/v8/V8Proxy.h
>@@ -242,7 +242,6 @@ namespace WebCore {
> 
>         // Helpers for throwing syntax and type errors with predefined messages.
>         static v8::Handle<v8::Value> throwTypeError();
>-        static v8::Handle<v8::Value> throwSyntaxError();
> 
>         v8::Local<v8::Context> context();
>         v8::Local<v8::Context> mainWorldContext();

Actions: View | Formatted Diff | Diff

Attachments on bug 84627: 138413