WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-84273-20120418140038.patch (text/plain), 26.40 KB, created by
Kentaro Hara
on 2012-04-18 14:00:39 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Kentaro Hara
Created:
2012-04-18 14:00:39 PDT
Size:
26.40 KB
patch
obsolete
>Subversion Revision: 114523 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 5d136771b6b30fffb370a9c17c0b9d57755f755b..9f95958c04bafbb26e71c6aa8cef3001e47e1399 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,53 @@ >+2012-04-18 Kentaro Hara <haraken@chromium.org> >+ >+ [V8] Pass Isolate to toV8() (Part6) >+ https://bugs.webkit.org/show_bug.cgi?id=84273 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The objective is to pass Isolate to all toV8()s. >+ Since there are a lot of toV8()s, I'll make the change >+ step by step. This patch passes Isolate to toV8() in >+ several custom bindings. >+ >+ No tests. No change in behavior. >+ >+ * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: >+ (WebCore::getNamedItems): >+ (WebCore::getItem): >+ (WebCore::V8HTMLAllCollection::namedPropertyGetter): >+ (WebCore::V8HTMLAllCollection::itemCallback): >+ (WebCore::V8HTMLAllCollection::namedItemCallback): >+ (WebCore::V8HTMLAllCollection::callAsFunctionCallback): >+ * bindings/v8/custom/V8HTMLCollectionCustom.cpp: >+ (WebCore::getNamedItems): >+ (WebCore::V8HTMLCollection::namedPropertyGetter): >+ (WebCore::V8HTMLCollection::namedItemCallback): >+ (WebCore::toV8): >+ * bindings/v8/custom/V8SVGPathSegCustom.cpp: >+ (WebCore::toV8): >+ * bindings/v8/custom/V8StyleSheetCustom.cpp: >+ (WebCore::toV8): >+ * bindings/v8/custom/V8StyleSheetListCustom.cpp: >+ (WebCore::V8StyleSheetList::namedPropertyGetter): >+ * bindings/v8/custom/V8TrackEventCustom.cpp: >+ (WebCore::V8TrackEvent::trackAccessorGetter): >+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: >+ (WebCore::toV8Object): >+ (WebCore::getObjectParameter): >+ (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback): >+ (WebCore::V8WebGLRenderingContext::getExtensionCallback): >+ (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback): >+ (WebCore::V8WebGLRenderingContext::getParameterCallback): >+ (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): >+ (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): >+ (WebCore::V8WebGLRenderingContext::getUniformCallback): >+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: >+ (WebCore::V8XMLHttpRequest::responseAccessorGetter): >+ * bindings/v8/custom/V8XSLTProcessorCustom.cpp: >+ (WebCore::V8XSLTProcessor::transformToFragmentCallback): >+ (WebCore::V8XSLTProcessor::transformToDocumentCallback): >+ > 2012-04-18 Dominik Röttsches <dominik.rottsches@linux.intel.com> > > [EFL][DRT] @font-face support fails on EFL >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp >index 1dc7836e402403512f57f5f875ece5a699234bb4..0a0594833e6b7bb337f3bed9ad2c189e5ef7d6f3 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp >@@ -41,7 +41,7 @@ > > namespace WebCore { > >-static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, AtomicString name) >+static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, AtomicString name, v8::Isolate* isolate) > { > Vector<RefPtr<Node> > namedItems; > collection->namedItems(name, namedItems); >@@ -50,16 +50,16 @@ static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, Atomic > return v8::Handle<v8::Value>(); > > if (namedItems.size() == 1) >- return toV8(namedItems.at(0).release()); >+ return toV8(namedItems.at(0).release(), isolate); > >- return toV8(V8NamedNodesCollection::create(namedItems)); >+ return toV8(V8NamedNodesCollection::create(namedItems), isolate); > } > >-static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v8::Value> argument) >+static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v8::Value> argument, v8::Isolate* isolate) > { > v8::Local<v8::Uint32> index = argument->ToArrayIndex(); > if (index.IsEmpty()) { >- v8::Handle<v8::Value> result = getNamedItems(collection, toWebCoreString(argument->ToString())); >+ v8::Handle<v8::Value> result = getNamedItems(collection, toWebCoreString(argument->ToString()), isolate); > > if (result.IsEmpty()) > return v8::Undefined(); >@@ -68,7 +68,7 @@ static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v > } > > RefPtr<Node> result = collection->item(index->Uint32Value()); >- return toV8(result.release()); >+ return toV8(result.release(), isolate); > } > > v8::Handle<v8::Value> V8HTMLAllCollection::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) >@@ -81,21 +81,21 @@ v8::Handle<v8::Value> V8HTMLAllCollection::namedPropertyGetter(v8::Local<v8::Str > return notHandledByInterceptor(); > > HTMLAllCollection* imp = V8HTMLAllCollection::toNative(info.Holder()); >- return getNamedItems(imp, v8StringToAtomicWebCoreString(name)); >+ return getNamedItems(imp, v8StringToAtomicWebCoreString(name), info.GetIsolate()); > } > > v8::Handle<v8::Value> V8HTMLAllCollection::itemCallback(const v8::Arguments& args) > { > INC_STATS("DOM.HTMLAllCollection.item()"); > HTMLAllCollection* imp = V8HTMLAllCollection::toNative(args.Holder()); >- return getItem(imp, args[0]); >+ return getItem(imp, args[0], args.GetIsolate()); > } > > v8::Handle<v8::Value> V8HTMLAllCollection::namedItemCallback(const v8::Arguments& args) > { > INC_STATS("DOM.HTMLAllCollection.namedItem()"); > HTMLAllCollection* imp = V8HTMLAllCollection::toNative(args.Holder()); >- v8::Handle<v8::Value> result = getNamedItems(imp, toWebCoreString(args[0])); >+ v8::Handle<v8::Value> result = getNamedItems(imp, toWebCoreString(args[0]), args.GetIsolate()); > > if (result.IsEmpty()) > return v8::Undefined(); >@@ -112,7 +112,7 @@ v8::Handle<v8::Value> V8HTMLAllCollection::callAsFunctionCallback(const v8::Argu > HTMLAllCollection* imp = V8HTMLAllCollection::toNative(args.Holder()); > > if (args.Length() == 1) >- return getItem(imp, args[0]); >+ return getItem(imp, args[0], args.GetIsolate()); > > // If there is a second argument it is the index of the item we want. > String name = toWebCoreString(args[0]); >@@ -121,7 +121,7 @@ v8::Handle<v8::Value> V8HTMLAllCollection::callAsFunctionCallback(const v8::Argu > return v8::Undefined(); > > if (Node* node = imp->namedItemWithIndex(name, index->Uint32Value())) >- return toV8(node); >+ return toV8(node, args.GetIsolate()); > > return v8::Undefined(); > } >diff --git a/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp b/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp >index 2e2255c644c66b7cfed430e8ae942cf8cb501833..b2cdacb62d2c42cb998b6e93ef9c9a4ba7b3b9c0 100644 >--- a/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp >@@ -41,7 +41,7 @@ > > namespace WebCore { > >-static v8::Handle<v8::Value> getNamedItems(HTMLCollection* collection, AtomicString name) >+static v8::Handle<v8::Value> getNamedItems(HTMLCollection* collection, AtomicString name, v8::Isolate* isolate) > { > Vector<RefPtr<Node> > namedItems; > collection->namedItems(name, namedItems); >@@ -50,9 +50,9 @@ static v8::Handle<v8::Value> getNamedItems(HTMLCollection* collection, AtomicStr > return v8::Handle<v8::Value>(); > > if (namedItems.size() == 1) >- return toV8(namedItems.at(0).release()); >+ return toV8(namedItems.at(0).release(), isolate); > >- return toV8(V8NamedNodesCollection::create(namedItems)); >+ return toV8(V8NamedNodesCollection::create(namedItems), isolate); > } > > v8::Handle<v8::Value> V8HTMLCollection::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) >@@ -65,14 +65,14 @@ v8::Handle<v8::Value> V8HTMLCollection::namedPropertyGetter(v8::Local<v8::String > return notHandledByInterceptor(); > > HTMLCollection* imp = V8HTMLCollection::toNative(info.Holder()); >- return getNamedItems(imp, v8StringToAtomicWebCoreString(name)); >+ return getNamedItems(imp, v8StringToAtomicWebCoreString(name), info.GetIsolate()); > } > > v8::Handle<v8::Value> V8HTMLCollection::namedItemCallback(const v8::Arguments& args) > { > INC_STATS("DOM.HTMLCollection.namedItem()"); > HTMLCollection* imp = V8HTMLCollection::toNative(args.Holder()); >- v8::Handle<v8::Value> result = getNamedItems(imp, toWebCoreString(args[0])); >+ v8::Handle<v8::Value> result = getNamedItems(imp, toWebCoreString(args[0]), args.GetIsolate()); > > if (result.IsEmpty()) > return v8::Undefined(); >@@ -83,7 +83,7 @@ v8::Handle<v8::Value> V8HTMLCollection::namedItemCallback(const v8::Arguments& a > v8::Handle<v8::Value> toV8(HTMLCollection* impl, v8::Isolate* isolate) > { > if (impl->type() == DocAll) >- return toV8(static_cast<HTMLAllCollection*>(impl)); >+ return toV8(static_cast<HTMLAllCollection*>(impl), isolate); > return V8HTMLCollection::wrap(impl); > } > >diff --git a/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp b/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp >index bc7d9fd1b0ee8dcbd1a181b8736864330ec07260..2dbd165cb7fb5a0afa070c838f411bba67d3fb1d 100644 >--- a/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp >@@ -63,43 +63,43 @@ v8::Handle<v8::Value> toV8(SVGPathSeg* impl, v8::Isolate* isolate) > return v8::Null(); > switch (impl->pathSegType()) { > case SVGPathSeg::PATHSEG_CLOSEPATH: >- return toV8(static_cast<SVGPathSegClosePath*>(impl)); >+ return toV8(static_cast<SVGPathSegClosePath*>(impl), isolate); > case SVGPathSeg::PATHSEG_MOVETO_ABS: >- return toV8(static_cast<SVGPathSegMovetoAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegMovetoAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_MOVETO_REL: >- return toV8(static_cast<SVGPathSegMovetoRel*>(impl)); >+ return toV8(static_cast<SVGPathSegMovetoRel*>(impl), isolate); > case SVGPathSeg::PATHSEG_LINETO_ABS: >- return toV8(static_cast<SVGPathSegLinetoAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegLinetoAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_LINETO_REL: >- return toV8(static_cast<SVGPathSegLinetoRel*>(impl)); >+ return toV8(static_cast<SVGPathSegLinetoRel*>(impl), isolate); > case SVGPathSeg::PATHSEG_CURVETO_CUBIC_ABS: >- return toV8(static_cast<SVGPathSegCurvetoCubicAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegCurvetoCubicAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_CURVETO_CUBIC_REL: >- return toV8(static_cast<SVGPathSegCurvetoCubicRel*>(impl)); >+ return toV8(static_cast<SVGPathSegCurvetoCubicRel*>(impl), isolate); > case SVGPathSeg::PATHSEG_CURVETO_QUADRATIC_ABS: >- return toV8(static_cast<SVGPathSegCurvetoQuadraticAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegCurvetoQuadraticAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_CURVETO_QUADRATIC_REL: >- return toV8(static_cast<SVGPathSegCurvetoQuadraticRel*>(impl)); >+ return toV8(static_cast<SVGPathSegCurvetoQuadraticRel*>(impl), isolate); > case SVGPathSeg::PATHSEG_ARC_ABS: >- return toV8(static_cast<SVGPathSegArcAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegArcAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_ARC_REL: >- return toV8(static_cast<SVGPathSegArcRel*>(impl)); >+ return toV8(static_cast<SVGPathSegArcRel*>(impl), isolate); > case SVGPathSeg::PATHSEG_LINETO_HORIZONTAL_ABS: >- return toV8(static_cast<SVGPathSegLinetoHorizontalAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegLinetoHorizontalAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_LINETO_HORIZONTAL_REL: >- return toV8(static_cast<SVGPathSegLinetoHorizontalRel*>(impl)); >+ return toV8(static_cast<SVGPathSegLinetoHorizontalRel*>(impl), isolate); > case SVGPathSeg::PATHSEG_LINETO_VERTICAL_ABS: >- return toV8(static_cast<SVGPathSegLinetoVerticalAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegLinetoVerticalAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_LINETO_VERTICAL_REL: >- return toV8(static_cast<SVGPathSegLinetoVerticalRel*>(impl)); >+ return toV8(static_cast<SVGPathSegLinetoVerticalRel*>(impl), isolate); > case SVGPathSeg::PATHSEG_CURVETO_CUBIC_SMOOTH_ABS: >- return toV8(static_cast<SVGPathSegCurvetoCubicSmoothAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegCurvetoCubicSmoothAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_CURVETO_CUBIC_SMOOTH_REL: >- return toV8(static_cast<SVGPathSegCurvetoCubicSmoothRel*>(impl)); >+ return toV8(static_cast<SVGPathSegCurvetoCubicSmoothRel*>(impl), isolate); > case SVGPathSeg::PATHSEG_CURVETO_QUADRATIC_SMOOTH_ABS: >- return toV8(static_cast<SVGPathSegCurvetoQuadraticSmoothAbs*>(impl)); >+ return toV8(static_cast<SVGPathSegCurvetoQuadraticSmoothAbs*>(impl), isolate); > case SVGPathSeg::PATHSEG_CURVETO_QUADRATIC_SMOOTH_REL: >- return toV8(static_cast<SVGPathSegCurvetoQuadraticSmoothRel*>(impl)); >+ return toV8(static_cast<SVGPathSegCurvetoQuadraticSmoothRel*>(impl), isolate); > } > ASSERT_NOT_REACHED(); > return V8SVGPathSeg::wrap(impl); >diff --git a/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp b/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp >index edc7e09d79a409c62d4b1eb210826d9db829e11d..b607637ad5c6fd5aeb1e43cfd12a9c5a895dc780 100644 >--- a/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp >@@ -42,12 +42,12 @@ v8::Handle<v8::Value> toV8(StyleSheet* impl, v8::Isolate* isolate) > if (!impl) > return v8::Null(); > if (impl->isCSSStyleSheet()) >- return toV8(static_cast<CSSStyleSheet*>(impl)); >+ return toV8(static_cast<CSSStyleSheet*>(impl), isolate); > v8::Handle<v8::Object> wrapper = V8StyleSheet::wrap(impl); > // Add a hidden reference from stylesheet object to its owner node. > Node* ownerNode = impl->ownerNode(); > if (ownerNode && !wrapper.IsEmpty()) >- V8DOMWrapper::setNamedHiddenReference(wrapper, "ownerNode", toV8(ownerNode)); >+ V8DOMWrapper::setNamedHiddenReference(wrapper, "ownerNode", toV8(ownerNode, isolate)); > return wrapper; > } > >diff --git a/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp b/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp >index cee18383a4d985552a568c08d11fcf2ce6c764ea..e28665490f8c8dbb68a62fe475936c9b2ecdcb4f 100644 >--- a/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp >@@ -52,7 +52,7 @@ v8::Handle<v8::Value> V8StyleSheetList::namedPropertyGetter(v8::Local<v8::String > if (!item) > return notHandledByInterceptor(); > >- return toV8(item->sheet()); >+ return toV8(item->sheet(), info.GetIsolate()); > } > > } // namespace WebCore >diff --git a/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp b/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp >index 37fd3db8b361bc2734601731776a608ba6f93ffe..5942f5c4de10c156434902120e817c87cdc01cf1 100644 >--- a/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp >@@ -57,7 +57,7 @@ v8::Handle<v8::Value> V8TrackEvent::trackAccessorGetter(v8::Local<v8::String> na > break; > > case TrackBase::TextTrack: >- return toV8(static_cast<TextTrack*>(track)); >+ return toV8(static_cast<TextTrack*>(track), info.GetIsolate()); > break; > > case TrackBase::AudioTrack: >diff --git a/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp b/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp >index 7dcedbe25475b23061f96b0d1a864d6f89a89225..70121d5183585c14fd486c696bc817138f73df4f 100644 >--- a/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp >@@ -115,7 +115,7 @@ static int* jsArrayToIntArray(v8::Handle<v8::Array> array, uint32_t len) > return data; > } > >-static v8::Handle<v8::Value> toV8Object(const WebGLGetInfo& info) >+static v8::Handle<v8::Value> toV8Object(const WebGLGetInfo& info, v8::Isolate* isolate) > { > switch (info.getType()) { > case WebGLGetInfo::kTypeBool: >@@ -138,34 +138,34 @@ static v8::Handle<v8::Value> toV8Object(const WebGLGetInfo& info) > case WebGLGetInfo::kTypeUnsignedInt: > return v8::Integer::NewFromUnsigned(info.getUnsignedInt()); > case WebGLGetInfo::kTypeWebGLBuffer: >- return toV8(info.getWebGLBuffer()); >+ return toV8(info.getWebGLBuffer(), isolate); > case WebGLGetInfo::kTypeWebGLFloatArray: >- return toV8(info.getWebGLFloatArray()); >+ return toV8(info.getWebGLFloatArray(), isolate); > case WebGLGetInfo::kTypeWebGLFramebuffer: >- return toV8(info.getWebGLFramebuffer()); >+ return toV8(info.getWebGLFramebuffer(), isolate); > case WebGLGetInfo::kTypeWebGLIntArray: >- return toV8(info.getWebGLIntArray()); >+ return toV8(info.getWebGLIntArray(), isolate); > // FIXME: implement WebGLObjectArray > // case WebGLGetInfo::kTypeWebGLObjectArray: > case WebGLGetInfo::kTypeWebGLProgram: >- return toV8(info.getWebGLProgram()); >+ return toV8(info.getWebGLProgram(), isolate); > case WebGLGetInfo::kTypeWebGLRenderbuffer: >- return toV8(info.getWebGLRenderbuffer()); >+ return toV8(info.getWebGLRenderbuffer(), isolate); > case WebGLGetInfo::kTypeWebGLTexture: >- return toV8(info.getWebGLTexture()); >+ return toV8(info.getWebGLTexture(), isolate); > case WebGLGetInfo::kTypeWebGLUnsignedByteArray: >- return toV8(info.getWebGLUnsignedByteArray()); >+ return toV8(info.getWebGLUnsignedByteArray(), isolate); > case WebGLGetInfo::kTypeWebGLUnsignedIntArray: >- return toV8(info.getWebGLUnsignedIntArray()); >+ return toV8(info.getWebGLUnsignedIntArray(), isolate); > case WebGLGetInfo::kTypeWebGLVertexArrayObjectOES: >- return toV8(info.getWebGLVertexArrayObjectOES()); >+ return toV8(info.getWebGLVertexArrayObjectOES(), isolate); > default: > notImplemented(); > return v8::Undefined(); > } > } > >-static v8::Handle<v8::Value> toV8Object(WebGLExtension* extension, v8::Handle<v8::Object> contextObject) >+static v8::Handle<v8::Value> toV8Object(WebGLExtension* extension, v8::Handle<v8::Object> contextObject, v8::Isolate* isolate) > { > if (!extension) > return v8::Null(); >@@ -173,35 +173,35 @@ static v8::Handle<v8::Value> toV8Object(WebGLExtension* extension, v8::Handle<v8 > const char* referenceName = 0; > switch (extension->getName()) { > case WebGLExtension::WebKitWebGLLoseContextName: >- extensionObject = toV8(static_cast<WebGLLoseContext*>(extension)); >+ extensionObject = toV8(static_cast<WebGLLoseContext*>(extension), isolate); > referenceName = "webKitWebGLLoseContextName"; > break; > case WebGLExtension::EXTTextureFilterAnisotropicName: >- extensionObject = toV8(static_cast<EXTTextureFilterAnisotropic*>(extension)); >+ extensionObject = toV8(static_cast<EXTTextureFilterAnisotropic*>(extension), isolate); > referenceName = "extTextureFilterAnisotropicName"; > break; > case WebGLExtension::OESStandardDerivativesName: >- extensionObject = toV8(static_cast<OESStandardDerivatives*>(extension)); >+ extensionObject = toV8(static_cast<OESStandardDerivatives*>(extension), isolate); > referenceName = "oesStandardDerivativesName"; > break; > case WebGLExtension::OESTextureFloatName: >- extensionObject = toV8(static_cast<OESTextureFloat*>(extension)); >+ extensionObject = toV8(static_cast<OESTextureFloat*>(extension), isolate); > referenceName = "oesTextureFloatName"; > break; > case WebGLExtension::OESVertexArrayObjectName: >- extensionObject = toV8(static_cast<OESVertexArrayObject*>(extension)); >+ extensionObject = toV8(static_cast<OESVertexArrayObject*>(extension), isolate); > referenceName = "oesVertexArrayObjectName"; > break; > case WebGLExtension::WebGLDebugRendererInfoName: >- extensionObject = toV8(static_cast<WebGLDebugRendererInfo*>(extension)); >+ extensionObject = toV8(static_cast<WebGLDebugRendererInfo*>(extension), isolate); > referenceName = "webGLDebugRendererInfoName"; > break; > case WebGLExtension::WebGLDebugShadersName: >- extensionObject = toV8(static_cast<WebGLDebugShaders*>(extension)); >+ extensionObject = toV8(static_cast<WebGLDebugShaders*>(extension), isolate); > referenceName = "webGLDebugShadersName"; > break; > case WebGLExtension::WebKitWebGLCompressedTextureS3TCName: >- extensionObject = toV8(static_cast<WebGLCompressedTextureS3TC*>(extension)); >+ extensionObject = toV8(static_cast<WebGLCompressedTextureS3TC*>(extension), isolate); > referenceName = "webKitWebGLCompressedTextureS3TCName"; > break; > } >@@ -248,7 +248,7 @@ static v8::Handle<v8::Value> getObjectParameter(const v8::Arguments& args, Objec > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8Object(info); >+ return toV8Object(info, args.GetIsolate()); > } > > static WebGLUniformLocation* toWebGLUniformLocation(v8::Handle<v8::Value> value, bool& ok) >@@ -292,7 +292,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getAttachedShadersCallback(const > return v8::Null(); > v8::Local<v8::Array> array = v8::Array::New(shaders.size()); > for (size_t ii = 0; ii < shaders.size(); ++ii) >- array->Set(v8::Integer::New(ii), toV8(shaders[ii].get())); >+ array->Set(v8::Integer::New(ii), toV8(shaders[ii].get(), args.GetIsolate())); > return array; > } > >@@ -312,7 +312,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getExtensionCallback(const v8::Ar > } > STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, name, args[0]); > WebGLExtension* extension = imp->getExtension(name); >- return toV8Object(extension, args.Holder()); >+ return toV8Object(extension, args.Holder(), args.GetIsolate()); > } > > v8::Handle<v8::Value> V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback(const v8::Arguments& args) >@@ -334,7 +334,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getFramebufferAttachmentParameter > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8Object(info); >+ return toV8Object(info, args.GetIsolate()); > } > > v8::Handle<v8::Value> V8WebGLRenderingContext::getParameterCallback(const v8::Arguments& args) >@@ -354,7 +354,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getParameterCallback(const v8::Ar > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8Object(info); >+ return toV8Object(info, args.GetIsolate()); > } > > v8::Handle<v8::Value> V8WebGLRenderingContext::getProgramParameterCallback(const v8::Arguments& args) >@@ -379,7 +379,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getProgramParameterCallback(const > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8Object(info); >+ return toV8Object(info, args.GetIsolate()); > } > > v8::Handle<v8::Value> V8WebGLRenderingContext::getRenderbufferParameterCallback(const v8::Arguments& args) >@@ -410,7 +410,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getShaderParameterCallback(const > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8Object(info); >+ return toV8Object(info, args.GetIsolate()); > } > > v8::Handle<v8::Value> V8WebGLRenderingContext::getSupportedExtensionsCallback(const v8::Arguments& args) >@@ -462,7 +462,7 @@ v8::Handle<v8::Value> V8WebGLRenderingContext::getUniformCallback(const v8::Argu > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8Object(info); >+ return toV8Object(info, args.GetIsolate()); > } > > v8::Handle<v8::Value> V8WebGLRenderingContext::getVertexAttribCallback(const v8::Arguments& args) >diff --git a/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp b/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp >index e9e3bf69e927d11aa09e852b3f92747a3a1bc10a..82c74cdb75aef3090b025f0cbf552334da809573 100644 >--- a/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp >@@ -78,7 +78,7 @@ v8::Handle<v8::Value> V8XMLHttpRequest::responseAccessorGetter(v8::Local<v8::Str > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8(document); >+ return toV8(document, info.GetIsolate()); > } > > case XMLHttpRequest::ResponseTypeBlob: >@@ -90,7 +90,7 @@ v8::Handle<v8::Value> V8XMLHttpRequest::responseAccessorGetter(v8::Local<v8::Str > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8(blob); >+ return toV8(blob, info.GetIsolate()); > } > #else > return v8::Undefined(); >@@ -104,7 +104,7 @@ v8::Handle<v8::Value> V8XMLHttpRequest::responseAccessorGetter(v8::Local<v8::Str > V8Proxy::setDOMException(ec); > return v8::Undefined(); > } >- return toV8(arrayBuffer); >+ return toV8(arrayBuffer, info.GetIsolate()); > } > } > >diff --git a/Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp b/Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp >index 680c7a151c46094e2efe2377950042b9b7c84cef..e9f951754b88a71406b936f0291c106b9a8c853c 100644 >--- a/Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp >+++ b/Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp >@@ -74,7 +74,7 @@ v8::Handle<v8::Value> V8XSLTProcessor::transformToFragmentCallback(const v8::Arg > Node* source = V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])); > Document* owner = V8Document::toNative(v8::Handle<v8::Object>::Cast(args[1])); > RefPtr<DocumentFragment> result = imp->transformToFragment(source, owner); >- return toV8(result.release()); >+ return toV8(result.release(), args.GetIsolate()); > } > > >@@ -95,7 +95,7 @@ v8::Handle<v8::Value> V8XSLTProcessor::transformToDocumentCallback(const v8::Arg > if (!result) > return v8::Undefined(); > >- return toV8(result.release()); >+ return toV8(result.release(), args.GetIsolate()); > } > >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=137762">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
webkit.review.bot
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 84273
:
137760
|
137761
| 137762 |
138404