Attachment 126673 Details for Bug 78342 – rebased patch for commit

[patch] rebased patch for commit

bug-78342-20120212181511.patch (text/plain), 3.03 KB, created by Kentaro Hara on 2012-02-12 01:15:12 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-02-12 01:15:12 PST

Size: 3.03 KB

patch

obsolete

>Subversion Revision: 107503
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index dcebeaf8844a009f0ec7b583c89c7cf50fda82ce..1b04a98c664b03b8668ed8e376c320eec0409dfb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,28 @@
>+2012-02-10  Kentaro Hara  <haraken@chromium.org>
>+
>+        Remove [CPPCustom] from CodeGeneratorCPP.pm
>+        https://bugs.webkit.org/show_bug.cgi?id=78342
>+
>+        Reviewed by Adam Barth.
>+
>+        This patch removes [CPPCustom].
>+
>+        [CPPCustom] has been used in DOMWindow.location only to indicate that
>+        DOMWindow.location should be ignored in CPP. However, there are many
>+        other attributes and methods that CPP does not support (e.g. [CallWith=...],
>+        [CustomSetter], etc), and they are not yet marked with [CPPCustom].
>+        CPP just generates "meaningless" code for those unsupported attributes
>+        and methods. Ideally we can mark all unsupported attributes and methods
>+        with [CPPCustom], but it would not be so practical. Otherwise, removing
>+        [CPPCustom] would make sense. The side effect of removing [CPPCustom]
>+        is just that CPP will generate "meaningless" code for DOMWindow.location.
>+
>+        No tests. No change in behavior.
>+
>+        * bindings/scripts/CodeGeneratorCPP.pm:
>+        (ShouldSkipType):
>+        * page/DOMWindow.idl:
>+
> 2012-02-11  Filip Pizlo  <fpizlo@apple.com>
> 
>         It should be possible to send all JSC debug logging to a file
>diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm b/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>index dcef743ada3418c1eb2b2f133978d7f4b7681c5e..5826edd523523d064699852e1bc74120a1037f58 100644
>--- a/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>+++ b/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>@@ -192,8 +192,7 @@ sub ShouldSkipType
>     my $typeInfo = shift;
> 
>     return 1 if $typeInfo->signature->extendedAttributes->{"Custom"}
>-                or $typeInfo->signature->extendedAttributes->{"CustomGetter"}
>-                or $typeInfo->signature->extendedAttributes->{"CPPCustom"};
>+                or $typeInfo->signature->extendedAttributes->{"CustomGetter"};
> 
>     # FIXME: We don't generate bindings for SVG related interfaces yet
>     return 1 if $typeInfo->signature->name =~ /getSVGDocument/;
>diff --git a/Source/WebCore/page/DOMWindow.idl b/Source/WebCore/page/DOMWindow.idl
>index ce03d42e7c73c50da5530df922c44d5c698a52a9..d0767b5a71d6de80454c3403c09a613b0760b154 100644
>--- a/Source/WebCore/page/DOMWindow.idl
>+++ b/Source/WebCore/page/DOMWindow.idl
>@@ -53,7 +53,7 @@ module window {
>         attribute [Replaceable] Navigator navigator;
>         attribute [Replaceable] Navigator clientInformation;
>         readonly attribute Crypto crypto;
>-        attribute [DoNotCheckDomainSecurity, JSCustom, V8CustomSetter, V8Unforgeable, CPPCustom] Location location;
>+        attribute [DoNotCheckDomainSecurity, JSCustom, V8CustomSetter, V8Unforgeable] Location location;
> 
>         attribute [Replaceable, CustomGetter, V8CustomSetter] Event event;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 78342: 126487 | 126673