Attachment 126487 Details for Bug 78342 – Patch

[patch] Patch

bug-78342-20120210200631.patch (text/plain), 3.10 KB, created by Kentaro Hara on 2012-02-10 03:06:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-02-10 03:06:33 PST

Size: 3.10 KB

patch

obsolete

>Subversion Revision: 107381
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bc8c21af9dcbdf50bc63b2191dea37933a7a40db..84189828fa0c9b317916b32be4464231e318e774 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,28 @@
>+2012-02-10  Kentaro Hara  <haraken@chromium.org>
>+
>+        Remove [CPPCustom] from CodeGeneratorCPP.pm
>+        https://bugs.webkit.org/show_bug.cgi?id=78342
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch removes [CPPCustom].
>+
>+        [CPPCustom] has been used in DOMWindow.location only to indicate that
>+        DOMWindow.location should be ignored in CPP. However, there are many
>+        other attributes and methods that CPP does not support (e.g. [CallWith=...],
>+        [CustomSetter], etc), and they are not yet marked with [CPPCustom].
>+        CPP just generates "meaningless" code for those unsupported attributes
>+        and methods. Ideally we can mark all unsupported attributes and methods
>+        with [CPPCustom], but it would not be so practical. Otherwise, removing
>+        [CPPCustom] would make sense. The side effect of removing [CPPCustom]
>+        is just that CPP will generate "meaningless" code for DOMWindow.location.
>+
>+        No tests. No change in behavior.
>+
>+        * bindings/scripts/CodeGeneratorCPP.pm:
>+        (ShouldSkipType):
>+        * page/DOMWindow.idl:
>+
> 2012-02-10  Pavel Feldman  <pfeldman@google.com>
> 
>         [Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
>diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm b/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>index 32928d19cf3e43f5cab06a5428c1e768ac68cb13..f00e428ce357d63f96ad35a8a55346da31f214e7 100644
>--- a/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>+++ b/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>@@ -194,8 +194,7 @@ sub ShouldSkipType
>     return 1 if $typeInfo->signature->extendedAttributes->{"Custom"};
> 
>     return 1 if $typeInfo->signature->extendedAttributes->{"CustomArgumentHandling"}
>-             or $typeInfo->signature->extendedAttributes->{"CustomGetter"}
>-             or $typeInfo->signature->extendedAttributes->{"CPPCustom"};
>+             or $typeInfo->signature->extendedAttributes->{"CustomGetter"};
> 
>     # FIXME: We don't generate bindings for SVG related interfaces yet
>     return 1 if $typeInfo->signature->name =~ /getSVGDocument/;
>diff --git a/Source/WebCore/page/DOMWindow.idl b/Source/WebCore/page/DOMWindow.idl
>index 090074c8bee5cb0e91e5cf6f9ce9a0205a507737..cd1308229f359aa3b0cf26c37353c51c6601df23 100644
>--- a/Source/WebCore/page/DOMWindow.idl
>+++ b/Source/WebCore/page/DOMWindow.idl
>@@ -53,7 +53,7 @@ module window {
>         attribute [Replaceable] Navigator navigator;
>         attribute [Replaceable] Navigator clientInformation;
>         readonly attribute Crypto crypto;
>-        attribute [DoNotCheckDomainSecurity, JSCustom, V8CustomSetter, V8Unforgeable, CPPCustom] Location location;
>+        attribute [DoNotCheckDomainSecurity, JSCustom, V8CustomSetter, V8Unforgeable] Location location;
> 
>         attribute [Replaceable, CustomGetter, V8CustomSetter] Event event;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 78342: 126487 | 126673