Attachment 126467 Details for Bug 78328 – Patch

[patch] Patch

bug-78328-20120210170436.patch (text/plain), 1.98 KB, created by Kentaro Hara on 2012-02-10 00:04:37 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-02-10 00:04:37 PST

Size: 1.98 KB

patch

obsolete

>Subversion Revision: 107371
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a6b1c37f3bffb34b542e7033f4147119efbbccf1..436ad4e945d36e36ec4f165850542fee3b02d9a7 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,5 +1,24 @@
> 2012-02-09  Kentaro Hara  <haraken@chromium.org>
> 
>+        Remove [ConvertingNullStringTo] from CloseEvent.idl
>+        https://bugs.webkit.org/show_bug.cgi?id=78328
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
>+        (although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).
>+
>+        Anyway, the spec says that "The reason attribute must return the value it was
>+        initialized to. When the object is created, this attribute must be initialized to empty string."
>+        http://dev.w3.org/html5/websockets/#event-definitions
>+        Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.
>+
>+        Test: fast/events/constructors/close-event-constructor.html
>+
>+        * websockets/CloseEvent.idl:
>+
>+2012-02-09  Kentaro Hara  <haraken@chromium.org>
>+
>         Unreviewed, rolling out r107368.
>         http://trac.webkit.org/changeset/107368
>         https://bugs.webkit.org/show_bug.cgi?id=78327
>diff --git a/Source/WebCore/websockets/CloseEvent.idl b/Source/WebCore/websockets/CloseEvent.idl
>index e36c9494a1c7ce98e29d257e960d6b126b1a5405..ea75111ac36220c1cdeecf4ee5912b82e17d5e22 100644
>--- a/Source/WebCore/websockets/CloseEvent.idl
>+++ b/Source/WebCore/websockets/CloseEvent.idl
>@@ -36,7 +36,7 @@ module events {
>     ] CloseEvent : Event {
>         readonly attribute [InitializedByEventConstructor] boolean wasClean;
>         readonly attribute [InitializedByEventConstructor] unsigned short code;
>-        readonly attribute [InitializedByEventConstructor, ConvertingNullStringTo=Undefined] DOMString reason;
>+        readonly attribute [InitializedByEventConstructor] DOMString reason;
>     };
> 
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 78328: 126464 | 126467