Attachment 126332 Details for Bug 78196 – Patch

[patch] Patch

bug-78196-20120209111051.patch (text/plain), 12.40 KB, created by Adam Klein on 2012-02-09 11:10:52 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Adam Klein

Created: 2012-02-09 11:10:52 PST

Size: 12.40 KB

patch

obsolete

>Subversion Revision: 107149
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index bbef236280e7d0190bff7e28efe969f4922ee779..3e9ad2cdda05ff5a23d498e62a4a95c8b13a92b5 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2012-02-08  Adam Klein  <adamk@chromium.org>
>+
>+        Enable MUTATION_OBSERVERS by default on all platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=78196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2012-02-08  Oliver Hunt  <oliver@apple.com>
> 
>         Whoops, fix the build.
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ae5726afc65711c0c73330b49873ccc5ae114acf..e36476ab4d0d1b3eabc89518d97760451a4b12a0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,5 +1,17 @@
> 2012-02-08  Adam Klein  <adamk@chromium.org>
> 
>+        Enable MUTATION_OBSERVERS by default on all platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=78196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests. (OOPS!)
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+        * UseV8.cmake:
>+
>+2012-02-08  Adam Klein  <adamk@chromium.org>
>+
>         Simplify and correct mutation delivery timing for JSC
>         https://bugs.webkit.org/show_bug.cgi?id=78172
> 
>diff --git a/Source/WebKit/mac/ChangeLog b/Source/WebKit/mac/ChangeLog
>index bf117372022c23bb164b2b4d983fb3d7e69e5871..4a9fbecf57e306932aa62c8742c591f2bcd7f9e3 100644
>--- a/Source/WebKit/mac/ChangeLog
>+++ b/Source/WebKit/mac/ChangeLog
>@@ -1,3 +1,12 @@
>+2012-02-08  Adam Klein  <adamk@chromium.org>
>+
>+        Enable MUTATION_OBSERVERS by default on all platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=78196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2012-02-07  Antti Koivisto  <antti@apple.com>
> 
>         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index 3d245524e8a4eba355b0f63b1f552f4609bbd7ea..980b05be535f51d270e6fb646b4e3cba2adbb3b5 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,3 +1,12 @@
>+2012-02-08  Adam Klein  <adamk@chromium.org>
>+
>+        Enable MUTATION_OBSERVERS by default on all platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=78196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2012-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
> 
>         Unreviewed, rolling out r106920, r106924, r106933, r106939,
>diff --git a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>index 6447eb7ee5c0956517e01c56e395ef4eab82f179..542024f5456679c19a6f744072ba1107c8d8a722 100644
>--- a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>+++ b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>@@ -95,7 +95,7 @@ ENABLE_MEDIA_SOURCE = ;
> ENABLE_MEDIA_STATISTICS = ;
> ENABLE_METER_TAG = ENABLE_METER_TAG;
> ENABLE_MHTML = ;
>-ENABLE_MUTATION_OBSERVERS = ;
>+ENABLE_MUTATION_OBSERVERS = ENABLE_MUTATION_OBSERVERS;
> 
> ENABLE_NOTIFICATIONS = $(ENABLE_NOTIFICATIONS_$(REAL_PLATFORM_NAME));
> ENABLE_NOTIFICATIONS_macosx = $(ENABLE_NOTIFICATIONS_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
>diff --git a/Source/WebCore/Configurations/FeatureDefines.xcconfig b/Source/WebCore/Configurations/FeatureDefines.xcconfig
>index f5bc9cf39223719060e9fa91311ec7380cdbe7fb..e1318163117335ab3b25265f8df7d8d684d6be5d 100644
>--- a/Source/WebCore/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebCore/Configurations/FeatureDefines.xcconfig
>@@ -95,7 +95,7 @@ ENABLE_MEDIA_SOURCE = ;
> ENABLE_MEDIA_STATISTICS = ;
> ENABLE_METER_TAG = ENABLE_METER_TAG;
> ENABLE_MHTML = ;
>-ENABLE_MUTATION_OBSERVERS = ;
>+ENABLE_MUTATION_OBSERVERS = ENABLE_MUTATION_OBSERVERS;
> 
> ENABLE_NOTIFICATIONS = $(ENABLE_NOTIFICATIONS_$(REAL_PLATFORM_NAME));
> ENABLE_NOTIFICATIONS_macosx = $(ENABLE_NOTIFICATIONS_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
>diff --git a/Source/WebCore/UseV8.cmake b/Source/WebCore/UseV8.cmake
>index 9b0a039b94cf37700781bd24633efc5076a73a86..468d01d0cbdd0285b3487bf4f5848dd34440cdfd 100755
>--- a/Source/WebCore/UseV8.cmake
>+++ b/Source/WebCore/UseV8.cmake
>@@ -128,6 +128,7 @@ LIST(APPEND WebCore_SOURCES
>     bindings/v8/custom/V8MessageChannelConstructor.cpp
>     bindings/v8/custom/V8MessageEventCustom.cpp
>     bindings/v8/custom/V8MessagePortCustom.cpp
>+    bindings/v8/custom/V8MutationCallbackCustom.cpp
>     bindings/v8/custom/V8NamedNodeMapCustom.cpp
>     bindings/v8/custom/V8NamedNodesCollection.cpp
>     bindings/v8/custom/V8NavigatorCustom.cpp
>@@ -147,6 +148,7 @@ LIST(APPEND WebCore_SOURCES
>     bindings/v8/custom/V8Uint8ArrayCustom.cpp
>     bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
>     bindings/v8/custom/V8WebKitAnimationCustom.cpp
>+    bindings/v8/custom/V8WebKitMutationObserverCustom.cpp
>     bindings/v8/custom/V8WebKitPointConstructor.cpp
>     bindings/v8/custom/V8WebSocketCustom.cpp
>     bindings/v8/custom/V8WorkerContextCustom.cpp
>diff --git a/Source/WebCore/WebCore.vcproj/WebCore.vcproj b/Source/WebCore/WebCore.vcproj/WebCore.vcproj
>index fc4a2183b06abc1166705ace7c849803fbc927b5..90ede9e8d53c9a1adb016f97496cfd1f6062bdda 100755
>--- a/Source/WebCore/WebCore.vcproj/WebCore.vcproj
>+++ b/Source/WebCore/WebCore.vcproj/WebCore.vcproj
>@@ -52118,6 +52118,62 @@
> 				>
> 			</File>
> 			<File
>+				RelativePath="..\dom\WebKitMutationObserver.cpp"
>+				>
>+				<FileConfiguration
>+					Name="Debug|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Release|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Debug_Cairo_CFLite|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Release_Cairo_CFLite|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Debug_All|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+				<FileConfiguration
>+					Name="Production|Win32"
>+					ExcludedFromBuild="true"
>+					>
>+					<Tool
>+						Name="VCCLCompilerTool"
>+					/>
>+				</FileConfiguration>
>+			</File>
>+			<File
>+				RelativePath="..\dom\WebKitMutationObserver.h"
>+				>
>+			</File>
>+			<File
> 				RelativePath="..\dom\WebKitNamedFlow.cpp"
> 				>
> 				<FileConfiguration
>diff --git a/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig b/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
>index f5bc9cf39223719060e9fa91311ec7380cdbe7fb..e1318163117335ab3b25265f8df7d8d684d6be5d 100644
>--- a/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
>@@ -95,7 +95,7 @@ ENABLE_MEDIA_SOURCE = ;
> ENABLE_MEDIA_STATISTICS = ;
> ENABLE_METER_TAG = ENABLE_METER_TAG;
> ENABLE_MHTML = ;
>-ENABLE_MUTATION_OBSERVERS = ;
>+ENABLE_MUTATION_OBSERVERS = ENABLE_MUTATION_OBSERVERS;
> 
> ENABLE_NOTIFICATIONS = $(ENABLE_NOTIFICATIONS_$(REAL_PLATFORM_NAME));
> ENABLE_NOTIFICATIONS_macosx = $(ENABLE_NOTIFICATIONS_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
>diff --git a/Source/WebKit2/Configurations/FeatureDefines.xcconfig b/Source/WebKit2/Configurations/FeatureDefines.xcconfig
>index f5bc9cf39223719060e9fa91311ec7380cdbe7fb..e1318163117335ab3b25265f8df7d8d684d6be5d 100644
>--- a/Source/WebKit2/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebKit2/Configurations/FeatureDefines.xcconfig
>@@ -95,7 +95,7 @@ ENABLE_MEDIA_SOURCE = ;
> ENABLE_MEDIA_STATISTICS = ;
> ENABLE_METER_TAG = ENABLE_METER_TAG;
> ENABLE_MHTML = ;
>-ENABLE_MUTATION_OBSERVERS = ;
>+ENABLE_MUTATION_OBSERVERS = ENABLE_MUTATION_OBSERVERS;
> 
> ENABLE_NOTIFICATIONS = $(ENABLE_NOTIFICATIONS_$(REAL_PLATFORM_NAME));
> ENABLE_NOTIFICATIONS_macosx = $(ENABLE_NOTIFICATIONS_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index fdb079d7e1dd830ef191c3743dfa4d8af51989fd..0958d16e8d7eac884ad05c83158ff3047aa38e0d 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,12 @@
>+2012-02-08  Adam Klein  <adamk@chromium.org>
>+
>+        Enable MUTATION_OBSERVERS by default on all platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=78196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/build-webkit:
>+
> 2012-02-08  Adam Barth  <abarth@webkit.org>
> 
>         Don't re-implement ZipFile.extractall
>diff --git a/Tools/Scripts/build-webkit b/Tools/Scripts/build-webkit
>index 021a0bb8214469b22d29e48dd754e351e61beacf..d8b36ca2e0a93b62e6c4b3cb79cbe175392d222a 100755
>--- a/Tools/Scripts/build-webkit
>+++ b/Tools/Scripts/build-webkit
>@@ -271,7 +271,7 @@ my @features = (
>       define => "ENABLE_MICRODATA", default => 0, value => \$microdataSupport },
> 
>     { option => "mutation-observers", desc => "Toggle DOM mutation observer support",
>-      define => "ENABLE_MUTATION_OBSERVERS", default => 0, value => \$mutationObserversSupport },
>+      define => "ENABLE_MUTATION_OBSERVERS", default => 1, value => \$mutationObserversSupport },
> 
>     { option => "netscape-plugin", desc => "Netscape Plugin support",
>       define => "ENABLE_NETSCAPE_PLUGIN_API", default => !isEfl(), value => \$netscapePluginSupport },
>diff --git a/ChangeLog b/ChangeLog
>index 28ee8fae8d3551906c0d454735021294935f75e9..1edf3995b443b74697205f7e1ee2df4819abbf8b 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,12 @@
>+2012-02-08  Adam Klein  <adamk@chromium.org>
>+
>+        Enable MUTATION_OBSERVERS by default on all platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=78196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * configure.ac:
>+
> 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
> 
>         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
>diff --git a/WebKitLibraries/ChangeLog b/WebKitLibraries/ChangeLog
>index 82bf1b58d30e6f635552c8a8eae69b41a9813af7..fa989790218c35c48710fd034372cd7b7130903d 100644
>--- a/WebKitLibraries/ChangeLog
>+++ b/WebKitLibraries/ChangeLog
>@@ -1,3 +1,13 @@
>+2012-02-08  Adam Klein  <adamk@chromium.org>
>+
>+        Enable MUTATION_OBSERVERS by default on all platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=78196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * win/tools/vsprops/FeatureDefines.vsprops:
>+        * win/tools/vsprops/FeatureDefinesCairo.vsprops:
>+
> 2012-02-06  Matthew Delaney  <mdelaney@apple.com>
> 
>         toDataURL() uses stale data after putImageData()
>diff --git a/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops b/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
>index 73db466508e3488255c1e992d4dcb3c433b0f707..9a9c204d21fb24d774e973a24c49d978a0bee35a 100644
>--- a/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
>+++ b/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
>@@ -208,7 +208,7 @@
> 	/>
>   <UserMacro
> 		Name="ENABLE_MUTATION_OBSERVERS"
>-		Value=""
>+		Value="ENABLE_MUTATION_OBSERVERS"
> 		PerformEnvironmentSet="true"
> 	/>
>   <UserMacro
>diff --git a/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops b/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
>index 97cf795ce2a25a9d899e0664badd5590b32028c6..b5adb8550d11f454d15506f3e485ea7faab6c612 100644
>--- a/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
>+++ b/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
>@@ -203,7 +203,7 @@
> 	/>
>   <UserMacro
> 		Name="ENABLE_MUTATION_OBSERVERS"
>-		Value=""
>+		Value="ENABLE_MUTATION_OBSERVERS"
> 		PerformEnvironmentSet="true"
> 	/>
>   <UserMacro
>diff --git a/configure.ac b/configure.ac
>index 6897f95723c3f6762d8acb03873b416e73afcb65..84bba54e498fff9f96a51e5a632a0c67e39ded2b 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -652,8 +652,8 @@ AC_MSG_RESULT([$enable_data_transfer_items])
> AC_MSG_CHECKING([whether to enable DOM mutation observer support])
> AC_ARG_ENABLE(mutation_observers,
>               AC_HELP_STRING([--enable-mutation-observers],
>-                             [enable DOM mutation observer support [default=no]]),
>-              [],[enable_mutation_observers="no"])
>+                             [enable DOM mutation observer support [default=yes]]),
>+              [],[enable_mutation_observers="yes"])
> AC_MSG_RESULT([$enable_mutation_observers])
> 
> # check whether to enable HTML5 client-side session and persitent storage support

Actions: View | Formatted Diff | Diff

Attachments on bug 78196: 126222 | 126332 | 126366 | 126369 | 126404 | 126558 | 126588