Attachment 126048 Details for Bug 78100 – Patch

[patch] Patch

bug-78100-20120208210018.patch (text/plain), 4.77 KB, created by Kentaro Hara on 2012-02-08 04:00:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-02-08 04:00:20 PST

Size: 4.77 KB

patch

obsolete

>Subversion Revision: 107063
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 38cd2c2717b6c40f39e19c7f0707e98bee953bed..943eab4e9ab28e26482cb48de9489bba846acb56 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,25 @@
>+2012-02-08  Kentaro Hara  <haraken@chromium.org>
>+
>+        Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
>+        it to [ObjCImplementedAsUnsignedLong]
>+        https://bugs.webkit.org/show_bug.cgi?id=78100
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Now [ConvertToString] is used by ObjC's HTMLElement.size only.
>+        This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
>+        and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].
>+
>+        No tests. No change in behavior.
>+
>+        * bindings/scripts/CodeGeneratorCPP.pm:
>+        (GenerateImplementation):
>+        * bindings/scripts/CodeGeneratorObjC.pm:
>+        (GenerateImplementation):
>+        * html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec
>+        says HTMLInputElement.size should be unsigned long.
>+        (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)
>+
> 2012-02-08  Alexander Pavlov  <apavlov@chromium.org>
> 
>         Web Inspector: Touch event emulation fails for iframes
>diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm b/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>index e87855c3933ebf7b0d2f8b97e2ea2cc83be34900..a909a57d05ad1fc850fcf33b660cc71f31f18298 100644
>--- a/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>+++ b/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
>@@ -748,11 +748,6 @@ sub GenerateImplementation
>                 my $argName = "new" . ucfirst($attributeName);
>                 my $arg = GetCPPTypeGetter($argName, $idlType);
> 
>-                # The definition of ConvertToString is flipped for the setter
>-                if ($attribute->signature->extendedAttributes->{"ConvertToString"}) {
>-                    $arg = "WTF::String($arg).toInt()";
>-                }
>-
>                 my $attributeType = GetCPPType($attribute->signature->type, 1);
>                 push(@implContent, "void $className\:\:$setterName($attributeType $argName)\n");
>                 push(@implContent, "{\n");
>diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm b/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
>index 6c7eda9890dee4ae7379fe1cac9480fe9ddd46b0..5a63fc33b2ed9bfc97da5daab7a80293c3d29f75 100644
>--- a/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
>+++ b/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
>@@ -1257,7 +1257,7 @@ sub GenerateImplementation
>                     }
>                 }
>                 $implIncludes{"DOMPrivate.h"} = 1;
>-            } elsif ($attribute->signature->extendedAttributes->{"ConvertToString"}) {
>+            } elsif ($attribute->signature->extendedAttributes->{"ObjCImplementedAsUnsignedLong"}) {
>                 $getterContentHead = "WTF::String::number(" . $getterContentHead;
>                 $getterContentTail .= ")";
>             } elsif ($idlType eq "Date") {
>@@ -1384,8 +1384,8 @@ sub GenerateImplementation
>                 my $argName = "new" . ucfirst($attributeInterfaceName);
>                 my $arg = GetObjCTypeGetter($argName, $idlType);
> 
>-                # The definition of ConvertToString is flipped for the setter
>-                if ($attribute->signature->extendedAttributes->{"ConvertToString"}) {
>+                # The definition of ObjCImplementedAsUnsignedLong is flipped for the setter
>+                if ($attribute->signature->extendedAttributes->{"ObjCImplementedAsUnsignedLong"}) {
>                     $arg = "WTF::String($arg).toInt()";
>                 }
> 
>diff --git a/Source/WebCore/html/HTMLInputElement.idl b/Source/WebCore/html/HTMLInputElement.idl
>index 2028d024bb7a6930a5145ab0e386512a00d527ce..4e218b96ccee2d588205f287977488c5ca6e9864 100644
>--- a/Source/WebCore/html/HTMLInputElement.idl
>+++ b/Source/WebCore/html/HTMLInputElement.idl
>@@ -50,10 +50,9 @@ module html {
>         attribute [Reflect] boolean readOnly;
>         attribute [Reflect] boolean required;
> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
>-        attribute [ConvertToString] DOMString size; // DOM level 2 changed this to a long, but our existing API is a string
>+        attribute [ObjCImplementedAsUnsignedLong] DOMString size; // DOM level 2 changed this to a long, but ObjC API is a string
> #else
>-        // FIXME: The spec says this should be a long, not an unsigned long.
>-        attribute unsigned long size; // Changed string -> long as part of DOM level 2
>+        attribute unsigned long size; // Changed string -> long -> unsigned long
> #endif
>         attribute [Reflect, URL] DOMString src;
>         attribute [Reflect] DOMString step;

Actions: View | Formatted Diff | Diff

Attachments on bug 78100: 126048