Attachment 125846 Details for Bug 58467 – Patch

[patch] Patch

bug-58467-20120207111403.patch (text/plain), 4.21 KB, created by Eugene Girard on 2012-02-07 08:14:04 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eugene Girard

Created: 2012-02-07 08:14:04 PST

Size: 4.21 KB

patch

obsolete

>Subversion Revision: 106889
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 834d8b09fd2a6537d6fdce89ee93b4ad8ddf34b0..e7abccba934f70848a36da399b8448c6ae9e7580 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2012-02-07  Eugene Girard  <girard@chromium.org>
>+
>+        IndexedDB createIndex should fail if options arg is invalid
>+        This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471
>+        Adding unit tests to verify correct operation.
>+        https://bugs.webkit.org/show_bug.cgi?id=58467
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * storage/indexeddb/index-basics-expected.txt:
>+        * storage/indexeddb/index-basics-workers-expected.txt:
>+        * storage/indexeddb/resources/index-basics.js:
>+        (deleteExisting):
>+
> 2012-02-06  David Grogan  <dgrogan@chromium.org>
> 
>         Port some indexeddb layout tests to workers.
>diff --git a/LayoutTests/storage/indexeddb/index-basics-expected.txt b/LayoutTests/storage/indexeddb/index-basics-expected.txt
>index 9853a20ecd23179642ed9e02ac125a0f8807e84b..0a8514fafd2e5de6f0c3c078c79c5a89a4f65494 100644
>--- a/LayoutTests/storage/indexeddb/index-basics-expected.txt
>+++ b/LayoutTests/storage/indexeddb/index-basics-expected.txt
>@@ -14,6 +14,14 @@ db.createObjectStore('storeName', null)
> store.createIndex('indexName', 'x')
> store.createIndex('indexName2', 'y', {unique: false})
> store.createIndex('zIndex', 'z', {unique: true})
>+PASS indexObject2.unique is false
>+PASS indexObject3.unique is true
>+Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', true)
>+PASS Exception was thrown.
>+PASS store.createIndex('failureIndex', 'zzz', true) threw TypeError: Not an object.
>+Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', 'string')
>+PASS Exception was thrown.
>+PASS store.createIndex('failureIndex', 'zzz', 'string') threw TypeError: Not an object.
> PASS 'name' in indexObject is true
> PASS indexObject.name is "indexName"
> PASS 'objectStore' in indexObject is true
>diff --git a/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt b/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt
>index 2202e0ee2791ba4eee1f7128e87cee4c2afa9afb..159b39599c24c5765452939a91b5161d307ec516 100644
>--- a/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt
>+++ b/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt
>@@ -15,6 +15,14 @@ PASS [Worker] trans !== null is true
> [Worker] store.createIndex('indexName', 'x')
> [Worker] store.createIndex('indexName2', 'y', {unique: false})
> [Worker] store.createIndex('zIndex', 'z', {unique: true})
>+PASS [Worker] indexObject2.unique is false
>+PASS [Worker] indexObject3.unique is true
>+[Worker] Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', true)
>+PASS [Worker] Exception was thrown.
>+PASS [Worker] store.createIndex('failureIndex', 'zzz', true) threw TypeError: Not an object.
>+[Worker] Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', 'string')
>+PASS [Worker] Exception was thrown.
>+PASS [Worker] store.createIndex('failureIndex', 'zzz', 'string') threw TypeError: Not an object.
> PASS [Worker] 'name' in indexObject is true
> PASS [Worker] indexObject.name is "indexName"
> PASS [Worker] 'objectStore' in indexObject is true
>diff --git a/LayoutTests/storage/indexeddb/resources/index-basics.js b/LayoutTests/storage/indexeddb/resources/index-basics.js
>index c2dec66064235b5d56153b8c7bec4b7578ad53c6..01d595a3b9e4411755df4ba8924a362f7165a297 100644
>--- a/LayoutTests/storage/indexeddb/resources/index-basics.js
>+++ b/LayoutTests/storage/indexeddb/resources/index-basics.js
>@@ -37,6 +37,10 @@ function deleteExisting(evt)
>     self.indexObject = evalAndLog("store.createIndex('indexName', 'x')");
>     self.indexObject2 = evalAndLog("store.createIndex('indexName2', 'y', {unique: false})");
>     self.indexObject3 = evalAndLog("store.createIndex('zIndex', 'z', {unique: true})");
>+    shouldBeFalse("indexObject2.unique");
>+    shouldBeTrue("indexObject3.unique");
>+    evalAndExpectExceptionClass("store.createIndex('failureIndex', 'zzz', true)", "TypeError");
>+    evalAndExpectExceptionClass("store.createIndex('failureIndex', 'zzz', 'string')", "TypeError");
>     addData();
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 58467: 89426 | 89427 | 125846 | 125875