Attachment 125073 Details for Bug 77599 – Patch

[patch] Patch

bug-77599-20120202140841.patch (text/plain), 5.14 KB, created by Kentaro Hara on 2012-02-01 21:08:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-02-01 21:08:43 PST

Size: 5.14 KB

patch

obsolete

>Subversion Revision: 106530
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1a4116c3f82183bb18e82df407f030cf4aa59876..ca3a4441b89971d243c4abbeace2a912c357d1ea 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2012-02-01  Kentaro Hara  <haraken@chromium.org>
>+
>+        Rename [V8DisallowShadowing] to [V8Unforgeable]
>+        https://bugs.webkit.org/show_bug.cgi?id=77599
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch renames [V8DisallowShadowing] to [V8Unforgeable], following the Web IDL
>+        spec (http://dev.w3.org/2006/webapi/WebIDL/#Unforgeable).
>+
>+        No tests. No change in behavior.
>+
>+        * bindings/scripts/CodeGeneratorV8.pm:
>+        (GenerateNormalAttrGetter):
>+        (GenerateSingleBatchedAttribute):
>+        (GenerateImplementation):
>+        * page/DOMWindow.idl:
>+        * page/Location.idl:
>+
> 2012-02-01  Hayato Ito  <hayato@chromium.org>
> 
>         Change class hierarycy so that ShadowRoot can inherit DocumentFragment.
>diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm b/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
>index 08d455f007cc78ae8bf17252b3c2d1dde2fcd717..f22b0871118058f1a29631fa883cfad5c0c01b8c 100644
>--- a/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
>+++ b/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
>@@ -829,7 +829,7 @@ END
> END
>             }
>         }
>-    } elsif ($attrExt->{"v8OnProto"} || $attrExt->{"V8DisallowShadowing"}) {
>+    } elsif ($attrExt->{"v8OnProto"} || $attrExt->{"V8Unforgeable"}) {
>         if ($interfaceName eq "DOMWindow") {
>             push(@implContentDecls, <<END);
>     v8::Handle<v8::Object> holder = info.Holder();
>@@ -1948,7 +1948,7 @@ sub GenerateSingleBatchedAttribute
>             $accessControl .= " | v8::ALL_CAN_WRITE";
>         }
>     }
>-    if ($attrExt->{"V8DisallowShadowing"}) {
>+    if ($attrExt->{"V8Unforgeable"}) {
>         $accessControl .= " | v8::PROHIBITS_OVERWRITING";
>     }
>     $accessControl = "static_cast<v8::AccessControl>(" . $accessControl . ")";
>@@ -1975,7 +1975,7 @@ sub GenerateSingleBatchedAttribute
>     if ($attrExt->{"DontEnum"}) {
>         $propAttr .= " | v8::DontEnum";
>     }
>-    if ($attrExt->{"V8DisallowShadowing"}) {
>+    if ($attrExt->{"V8Unforgeable"}) {
>         $propAttr .= " | v8::DontDelete";
>     }
> 
>@@ -2366,7 +2366,7 @@ sub GenerateImplementation
>     my @normal;
>     foreach my $attribute (@$attributes) {
> 
>-        if ($interfaceName eq "DOMWindow" && $attribute->signature->extendedAttributes->{"V8DisallowShadowing"}) {
>+        if ($interfaceName eq "DOMWindow" && $attribute->signature->extendedAttributes->{"V8Unforgeable"}) {
>             push(@disallowsShadowing, $attribute);
>         } elsif ($attribute->signature->extendedAttributes->{"EnabledAtRuntime"}) {
>             push(@enabledAtRuntime, $attribute);
>diff --git a/Source/WebCore/page/DOMWindow.idl b/Source/WebCore/page/DOMWindow.idl
>index 69929868780d9474acfd3347ed34f81aa2094529..b6a4bb437085911aec1ec1fb04eb9feb4ee69a4a 100644
>--- a/Source/WebCore/page/DOMWindow.idl
>+++ b/Source/WebCore/page/DOMWindow.idl
>@@ -54,7 +54,7 @@ module window {
>         attribute [Replaceable] Navigator navigator;
>         attribute [Replaceable] Navigator clientInformation;
>         readonly attribute Crypto crypto;
>-        attribute [DoNotCheckDomainSecurity, JSCCustom, V8CustomSetter, V8DisallowShadowing, CPPCustom] Location location;
>+        attribute [DoNotCheckDomainSecurity, JSCCustom, V8CustomSetter, V8Unforgeable, CPPCustom] Location location;
> 
>         attribute [Replaceable, CustomGetter, V8CustomSetter] Event event;
> 
>@@ -129,12 +129,12 @@ module window {
> 
>         // Self referential attributes
>         attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow self;
>-        readonly attribute [DoNotCheckDomainSecurity, V8DisallowShadowing] DOMWindow window;
>+        readonly attribute [DoNotCheckDomainSecurity, V8Unforgeable] DOMWindow window;
>         attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow frames;
> 
>         attribute [Replaceable, DoNotCheckDomainSecurityOnGet, V8CustomSetter] DOMWindow opener;
>         attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow parent;
>-        attribute [Replaceable, DoNotCheckDomainSecurityOnGet, V8DisallowShadowing, V8ReadOnly] DOMWindow top;
>+        attribute [Replaceable, DoNotCheckDomainSecurityOnGet, V8Unforgeable, V8ReadOnly] DOMWindow top;
> 
>         // DOM Level 2 AbstractView Interface
>         readonly attribute Document document;
>diff --git a/Source/WebCore/page/Location.idl b/Source/WebCore/page/Location.idl
>index 186c417bb3251522afc4e61f48eb884adc08d3ef..d510052c33974c543e1fb30b591fe947ded4c1b7 100644
>--- a/Source/WebCore/page/Location.idl
>+++ b/Source/WebCore/page/Location.idl
>@@ -43,7 +43,7 @@ module window {
>         OmitConstructor
>     ] Location {
> #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
>-                 attribute [DoNotCheckDomainSecurityOnSet, CustomSetter, V8DisallowShadowing] DOMString href;
>+                 attribute [DoNotCheckDomainSecurityOnSet, CustomSetter, V8Unforgeable] DOMString href;
> #endif
> 
>         [Custom, V8OnInstance] void assign(in [Optional=CallWithDefaultValue] DOMString url);

Actions: View | Formatted Diff | Diff

Attachments on bug 77599: 125073