Attachment 125070 Details for Bug 77598 – Patch

[patch] Patch

bug-77598-20120202135733.patch (text/plain), 3.73 KB, created by Kentaro Hara on 2012-02-01 20:57:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2012-02-01 20:57:34 PST

Size: 3.73 KB

patch

obsolete

>Subversion Revision: 106515
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 81bea14eac1da731706e7faf710216223e46f8f2..4022d304cc1d782574e44ac3f59cdb916ece6d25 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,26 @@
>+2012-02-01  Kentaro Hara  <haraken@chromium.org>
>+
>+        Remove [GenerateConstructor] from IDL files
>+        https://bugs.webkit.org/show_bug.cgi?id=77598
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [GenerateConstructor] is used in some IDL files but it is not implemented
>+        in code generators. I could not find any history about [GenerateConstructor]
>+        in code generators. This patch removes them from IDL files.
>+
>+        Maybe we want to replace [GenerateConstructor] with [Constructor] eventually,
>+        but currently no tests are written for their constructors (e.g. "new DOMTokenList()").
>+        So simply removing them would make sense.
>+
>+        No new tests. No change in behavior.
>+
>+        * dom/DOMStringList.idl:
>+        * html/DOMSettableTokenList.idl:
>+        * html/DOMTokenList.idl:
>+        * svg/SVGFEConvolveMatrixElement.idl:
>+        * webaudio/AudioPannerNode.idl:
>+
> 2012-02-01  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
> 
>         Avoid creating NamedNodeMap unnecessarily
>diff --git a/Source/WebCore/dom/DOMStringList.idl b/Source/WebCore/dom/DOMStringList.idl
>index 43af8259f0c0cada60d95994d375eb764c57da44..8b37aaaeb1c4a0332a26269f9c3625daf86625e1 100644
>--- a/Source/WebCore/dom/DOMStringList.idl
>+++ b/Source/WebCore/dom/DOMStringList.idl
>@@ -26,7 +26,6 @@
> module core {
> 
>     interface [
>-        GenerateConstructor,
>         HasIndexGetter
>     ] DOMStringList {
>         readonly attribute unsigned long length;
>diff --git a/Source/WebCore/html/DOMSettableTokenList.idl b/Source/WebCore/html/DOMSettableTokenList.idl
>index 6260623eeb463d7c30d96f9028191001f71a3391..02c6500b0c4b93b2de53d9ff2bbf408e976933da 100644
>--- a/Source/WebCore/html/DOMSettableTokenList.idl
>+++ b/Source/WebCore/html/DOMSettableTokenList.idl
>@@ -25,7 +25,6 @@
> module core {
> 
>     interface [
>-        GenerateConstructor,
>         HasIndexGetter,
>         GenerateToJS
>     ] DOMSettableTokenList : DOMTokenList {
>diff --git a/Source/WebCore/html/DOMTokenList.idl b/Source/WebCore/html/DOMTokenList.idl
>index f94491cbed76b3cc70e4c43287e608b37bc73bf7..0bcc4889f5148bd0a6d99cdccb333fde7b35343c 100644
>--- a/Source/WebCore/html/DOMTokenList.idl
>+++ b/Source/WebCore/html/DOMTokenList.idl
>@@ -26,7 +26,6 @@ module core {
> 
>     interface [
>         GenerateIsReachable=ImplElementRoot,
>-        GenerateConstructor,
>         HasIndexGetter
>     ] DOMTokenList {
>         readonly attribute unsigned long length;
>diff --git a/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl b/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl
>index 5fdc55c167105755d60c73850259ae076ceb5f00..d880aa77ea8cde311ab2929a480251d2b8c8c16e 100644
>--- a/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl
>+++ b/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl
>@@ -27,7 +27,6 @@ module svg {
> 
>     interface [
>         Conditional=SVG&FILTERS,
>-        GenerateConstructor,
>         DontCheckEnums
>     ] SVGFEConvolveMatrixElement : SVGElement,
>                                    SVGFilterPrimitiveStandardAttributes {
>diff --git a/Source/WebCore/webaudio/AudioPannerNode.idl b/Source/WebCore/webaudio/AudioPannerNode.idl
>index 2db093d7b503aa1e9cc45f64a717a0c1844badd7..2abe53a042eba15eac433de768ad6196dd585693 100644
>--- a/Source/WebCore/webaudio/AudioPannerNode.idl
>+++ b/Source/WebCore/webaudio/AudioPannerNode.idl
>@@ -25,7 +25,6 @@
> module audio {
>     interface [
>         Conditional=WEB_AUDIO,
>-        GenerateConstructor,
>         GenerateToJS
>     ] AudioPannerNode : AudioNode {
>         // Panning model

Actions: View | Formatted Diff | Diff

Attachments on bug 77598: 125070