Attachment 122504 Details for Bug 76311 – Patch

[patch] Patch

bug-76311-20120113142705.patch (text/plain), 3.61 KB, created by Vincent Scheib on 2012-01-13 14:27:06 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Vincent Scheib

Created: 2012-01-13 14:27:06 PST

Size: 3.61 KB

patch

obsolete

>Subversion Revision: 104968
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 96641d9acd21be2f57940e16c04a179b1eb6b77e..c058c148e2f827fd42a08bedb05310a8b1be88fd 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2012-01-13  Vincent Scheib  <scheib@chromium.org>
>+
>+        Pointer Lock: Change isLocked() from operator to attribute isLocked
>+        https://bugs.webkit.org/show_bug.cgi?id=76311
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch implements the recent Mouse Lock Specification update
>+        changing navigator.pointer.isLocked() to .isLocked.
>+
>+        Test pointer-lock/pointer-lock-api.html updated to new spec.
>+
>+        * page/PointerLock.idl:
>+
> 2012-01-13  Simon Fraser  <simon.fraser@apple.com>
> 
>         Rename GraphicsContext* argument in various RenderLayer methods
>diff --git a/Source/WebCore/page/PointerLock.idl b/Source/WebCore/page/PointerLock.idl
>index 6571b409f4f9df1ddcbabb2ae683d2091749393e..3054bcf20f17dd777986987816d4f7896ae22fe4 100644
>--- a/Source/WebCore/page/PointerLock.idl
>+++ b/Source/WebCore/page/PointerLock.idl
>@@ -30,7 +30,7 @@ module core {
>     ] PointerLock {
>         void lock(in Element target, in [Callback, Optional] VoidCallback successCallback, in [Callback, Optional] VoidCallback failureCallback);
>         void unlock();
>-        boolean isLocked();
>+        readonly attribute boolean isLocked;
>     };
> 
> }
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 3a64678e849ac8057fb12d4dca9de7c448076286..4a63cec0516e106d85e1b303550ccb1b2e46be2b 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2012-01-13  Vincent Scheib  <scheib@chromium.org>
>+
>+        Pointer Lock: Change isLocked() from operator to attribute isLocked
>+        https://bugs.webkit.org/show_bug.cgi?id=76311
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * pointer-lock/pointer-lock-api-expected.txt:
>+        * pointer-lock/pointer-lock-api.html:
>+
> 2012-01-13  Simon Fraser  <simon.fraser@apple.com>
> 
>         Fix an obviously incorrect expected result image.
>diff --git a/LayoutTests/pointer-lock/pointer-lock-api-expected.txt b/LayoutTests/pointer-lock/pointer-lock-api-expected.txt
>index 9c38b9d0bdd20dc34d4b424adb7726954755c4fa..f60af64d08ccac1495cdab18059b1d6baec1816a 100644
>--- a/LayoutTests/pointer-lock/pointer-lock-api-expected.txt
>+++ b/LayoutTests/pointer-lock/pointer-lock-api-expected.txt
>@@ -1,6 +1,6 @@
> PASS navigator.webkitPointer is defined.
>-PASS typeof navigator.webkitPointer.isLocked() is 'boolean'
>-PASS navigator.webkitPointer.isLocked() is false
>+PASS typeof navigator.webkitPointer.isLocked is 'boolean'
>+PASS navigator.webkitPointer.isLocked is false
> PASS navigator.webkitPointer.lock() threw exception TypeError: Not enough arguments.
> PASS navigator.webkitPointer.lock(document) is undefined
> PASS navigator.webkitPointer.unlock() is undefined
>diff --git a/LayoutTests/pointer-lock/pointer-lock-api.html b/LayoutTests/pointer-lock/pointer-lock-api.html
>index e840fb569a8f350273ccc881079b486fb53d699f..318b990fa257345f81f0fdda282a231255974f10 100644
>--- a/LayoutTests/pointer-lock/pointer-lock-api.html
>+++ b/LayoutTests/pointer-lock/pointer-lock-api.html
>@@ -6,7 +6,7 @@
> <body>
> <script>
>     shouldBeDefined("navigator.webkitPointer");
>-    shouldEvaluateTo("navigator.webkitPointer.isLocked()", false);
>+    shouldEvaluateTo("navigator.webkitPointer.isLocked", false);
>     shouldThrow("navigator.webkitPointer.lock()", "'TypeError: Not enough arguments'");
>     shouldEvaluateTo("navigator.webkitPointer.lock(document)", "undefined");
>     shouldEvaluateTo("navigator.webkitPointer.unlock()", "undefined");

Actions: View | Formatted Diff | Diff

Attachments on bug 76311: 122503 | 122504