Attachment 122459 Details for Bug 75996 – Patch

[patch] Patch

bug-75996-20120113105621.patch (text/plain), 3.35 KB, created by Raymond Toy on 2012-01-13 10:56:22 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Raymond Toy

Created: 2012-01-13 10:56:22 PST

Size: 3.35 KB

patch

obsolete

>Subversion Revision: 104937
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index dd7fa350dfd77b1abb567ea1c262d98120973711..d8b0cc7068e202878c84201512e39654b2dd67b0 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2012-01-13  Raymond Toy  <rtoy@google.com>
>+
>+        Typo in sample-accurate-scheduling layout test?
>+        https://bugs.webkit.org/show_bug.cgi?id=75996
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * webaudio/sample-accurate-scheduling-expected.txt: Updated
>+        * webaudio/sample-accurate-scheduling.html: Fix typo, add test for
>+        expected number of events.
>+
> 2012-01-13  Jochen Eisinger  <jochen@chromium.org>
> 
>         Test that an IDBDatabase object is garbage collected once no further references to it exist.
>diff --git a/LayoutTests/webaudio/sample-accurate-scheduling-expected.txt b/LayoutTests/webaudio/sample-accurate-scheduling-expected.txt
>index 48197530bd5a7111197b1498c40953dea403bc41..22eed8121652c3bb3f8a5d93f02ae805c007128a 100644
>--- a/LayoutTests/webaudio/sample-accurate-scheduling-expected.txt
>+++ b/LayoutTests/webaudio/sample-accurate-scheduling-expected.txt
>@@ -2,6 +2,7 @@ Tests sample-accurate scheduling.
> 
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
>+PASS Expected number of impulses found.
> PASS All events rendered with sample-accuracy.
> PASS successfullyParsed is true
> 
>diff --git a/LayoutTests/webaudio/sample-accurate-scheduling.html b/LayoutTests/webaudio/sample-accurate-scheduling.html
>index 7be551386d7f4c6dc5da22ff7df012c7ab86ec3e..ffebdd21646ad9ded039416a99f6326d10576159 100644
>--- a/LayoutTests/webaudio/sample-accurate-scheduling.html
>+++ b/LayoutTests/webaudio/sample-accurate-scheduling.html
>@@ -53,6 +53,8 @@ function checkSampleAccuracy(event) {
>     var bufferDataR = buffer.getChannelData(1);
> 
>     var success = true;
>+    var impulseCount = 0;
>+    var badOffsetCount = false;
>     
>     // Go through every sample and make sure it's 0, except at positions in sampleOffsets.
>     for (var i = 0; i < buffer.length; ++i) {
>@@ -72,15 +74,27 @@ function checkSampleAccuracy(event) {
>                     break;
>                 }
>             }
>-            
>+            ++impulseCount;
>             if (!found) {
>-                testFailed("Non-zero sample found at wrong sample offset.");
>+                testFailed("Non-zero sample found at sample offset " + i);
>                 success = false;
>-                break;
>+                ++badOffsetCount;
>             }
>         }
>     }
> 
>+    if (impulseCount == sampleOffsets.length) {
>+        if (badOffsetCount == 0) {
>+            testPassed("Expected number of events found.");
>+        } else {
>+            testFailed("Expected number of events found, but " + badOffsetCount + " are at incorrect offsets.");
>+            success = false;
>+        }
>+    } else {
>+        testFailed("Expected " + sampleOffsets.length + " impulses but only found " + impulseCount);
>+        success = false;
>+    }
>+
>     if (success) {
>         testPassed("All events rendered with sample-accuracy.");
>     } else {
>@@ -103,7 +117,7 @@ function runTest() {
>     createImpulse();    
> 
>     for (var i = 0; i < sampleOffsets.length; ++i) {
>-        var timeInSeconds = sampleOffsets[i] * sampleRate;
>+        var timeInSeconds = sampleOffsets[i] / sampleRate;
>         playNote(timeInSeconds);
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 75996: 121925 | 122037 | 122459 | 124618