Attachment 116605 Details for Bug 73125 – Patch

[patch] Patch

bug-73125-20111125223156.patch (text/plain), 8.10 KB, created by Kentaro Hara on 2011-11-25 05:31:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Kentaro Hara

Created: 2011-11-25 05:31:59 PST

Size: 8.10 KB

patch

obsolete

>Subversion Revision: 101153
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 56c3000bd87681d4c3d656cc1f130b18c913a365..4ecc083d3e0719709c77b3d7961921a5ff1770c5 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2011-11-25  Kentaro Hara  <haraken@chromium.org>
>+
>+        StorageEvent.key should not be nullable
>+        https://bugs.webkit.org/show_bug.cgi?id=73125
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Currently, document.createEvent('StorageEvent').key is evaluated as null.
>+        However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
>+        says that StorageEvent.key is not a nullable type, and thus
>+        document.createEvent('StorageEvent').key should be '' (an empty string).
>+
>+        * storage/StorageEvent.idl: Removed a [ConvertNullStringTo=Null] IDL from StorageEvent.key.
>+
> 2011-11-24  Kentaro Hara  <haraken@chromium.org>
> 
>         Initialize global variables during IDLParser object creation
>diff --git a/Source/WebCore/storage/StorageEvent.idl b/Source/WebCore/storage/StorageEvent.idl
>index 2e2e358757bae6c5a15750281f74783439b5c126..9da73ab78b407f5a5b4f117c1004ca9d6c8d9178 100644
>--- a/Source/WebCore/storage/StorageEvent.idl
>+++ b/Source/WebCore/storage/StorageEvent.idl
>@@ -26,7 +26,7 @@
> module storage {
> 
>     interface StorageEvent : Event {
>-        readonly attribute [ConvertNullStringTo=Null] DOMString key;
>+        readonly attribute DOMString key;
>         readonly attribute [ConvertNullStringTo=Null] DOMString oldValue;
>         readonly attribute [ConvertNullStringTo=Null] DOMString newValue;
>         readonly attribute DOMString url;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index f5f50c222d4703a186e38a66c7d504c9d91c17bf..d8a8548c0aa5c868ab1acb1456bd833931f7540d 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,25 @@
>+2011-11-25  Kentaro Hara  <haraken@chromium.org>
>+
>+        StorageEvent.key should not be nullable
>+        https://bugs.webkit.org/show_bug.cgi?id=73125
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Currently, document.createEvent('StorageEvent').key is evaluated as null.
>+        However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
>+        says that StorageEvent.key is not a nullable type, and thus
>+        document.createEvent('StorageEvent').key should be '' (an empty string).
>+
>+        * storage/domstorage/events/basic-body-attribute-expected.txt: Updated the test result as described above.
>+        * storage/domstorage/events/basic-expected.txt: Ditto.
>+        * storage/domstorage/events/basic-setattribute-expected.txt: Ditto.
>+        * storage/domstorage/events/script-tests/basic-body-attribute.js: Ditto.
>+        (step6):
>+        * storage/domstorage/events/script-tests/basic-setattribute.js: Ditto.
>+        (step6):
>+        * storage/domstorage/events/script-tests/basic.js: Ditto.
>+        (step6):
>+
> 2011-11-24  Arko Saha  <arko@motorola.com>
> 
>         Microdata: Support for properties attribute.
>diff --git a/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt b/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt
>index 273c95bc91cbdf48cb3a6446b90d846076cea29b..fa0bdc7e60c72363a47d244d6f9705741e4f0578 100644
>--- a/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt
>+++ b/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt
>@@ -44,7 +44,7 @@ PASS storageEventList[6].oldValue is "BAR"
> PASS storageEventList[6].newValue is null
> storage.clear()
> PASS storageEventList.length is 8
>-PASS storageEventList[7].key is null
>+PASS storageEventList[7].key is ""
> PASS storageEventList[7].oldValue is null
> PASS storageEventList[7].newValue is null
> 
>@@ -90,7 +90,7 @@ PASS storageEventList[6].oldValue is "BAR"
> PASS storageEventList[6].newValue is null
> storage.clear()
> PASS storageEventList.length is 8
>-PASS storageEventList[7].key is null
>+PASS storageEventList[7].key is ""
> PASS storageEventList[7].oldValue is null
> PASS storageEventList[7].newValue is null
> 
>diff --git a/LayoutTests/storage/domstorage/events/basic-expected.txt b/LayoutTests/storage/domstorage/events/basic-expected.txt
>index bccdb5c122c31daf8e1f635a45dd9d88eb27ad22..46703af188cb332ac90b836029f52ede88f316a2 100644
>--- a/LayoutTests/storage/domstorage/events/basic-expected.txt
>+++ b/LayoutTests/storage/domstorage/events/basic-expected.txt
>@@ -42,7 +42,7 @@ PASS storageEventList[6].oldValue is "BAR"
> PASS storageEventList[6].newValue is null
> storage.clear()
> PASS storageEventList.length is 8
>-PASS storageEventList[7].key is null
>+PASS storageEventList[7].key is ""
> PASS storageEventList[7].oldValue is null
> PASS storageEventList[7].newValue is null
> 
>@@ -86,7 +86,7 @@ PASS storageEventList[6].oldValue is "BAR"
> PASS storageEventList[6].newValue is null
> storage.clear()
> PASS storageEventList.length is 8
>-PASS storageEventList[7].key is null
>+PASS storageEventList[7].key is ""
> PASS storageEventList[7].oldValue is null
> PASS storageEventList[7].newValue is null
> 
>diff --git a/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt b/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt
>index 99c7f185e289f9c6d7ebdc82b15046939d61e7ee..357e7dfeb6dfe3589262548cb2e576aa85f4c3d8 100644
>--- a/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt
>+++ b/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt
>@@ -44,7 +44,7 @@ PASS storageEventList[6].oldValue is "BAR"
> PASS storageEventList[6].newValue is null
> storage.clear()
> PASS storageEventList.length is 8
>-PASS storageEventList[7].key is null
>+PASS storageEventList[7].key is ""
> PASS storageEventList[7].oldValue is null
> PASS storageEventList[7].newValue is null
> 
>@@ -90,7 +90,7 @@ PASS storageEventList[6].oldValue is "BAR"
> PASS storageEventList[6].newValue is null
> storage.clear()
> PASS storageEventList.length is 8
>-PASS storageEventList[7].key is null
>+PASS storageEventList[7].key is ""
> PASS storageEventList[7].oldValue is null
> PASS storageEventList[7].newValue is null
> 
>diff --git a/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js b/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js
>index 9673501f7d57f118a8464ea5353dc4f2158683f6..c4d937e925a0b817d1f74cf3a697473b9f1e14c1 100644
>--- a/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js
>+++ b/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js
>@@ -86,7 +86,7 @@ function step5()
> function step6()
> {
>     shouldBe("storageEventList.length", "8");
>-    shouldBeNull("storageEventList[7].key");
>+    shouldBeEqualToString("storageEventList[7].key", "");
>     shouldBeNull("storageEventList[7].oldValue");
>     shouldBeNull("storageEventList[7].newValue");
>  
>diff --git a/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js b/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js
>index edf0a8eccdabb8ebba599dd28d650af20147d84a..1b4bacf25c0e859782ccd37d19c42663cc76bc60 100644
>--- a/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js
>+++ b/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js
>@@ -86,7 +86,7 @@ function step5()
> function step6()
> {
>     shouldBe("storageEventList.length", "8");
>-    shouldBeNull("storageEventList[7].key");
>+    shouldBeEqualToString("storageEventList[7].key", "");
>     shouldBeNull("storageEventList[7].oldValue");
>     shouldBeNull("storageEventList[7].newValue");
>  
>diff --git a/LayoutTests/storage/domstorage/events/script-tests/basic.js b/LayoutTests/storage/domstorage/events/script-tests/basic.js
>index 691f02caf1a1ca2ee1416a7afd89ae953a263ead..605fe15487a3fbc61990fdbb082fea6444e7957a 100644
>--- a/LayoutTests/storage/domstorage/events/script-tests/basic.js
>+++ b/LayoutTests/storage/domstorage/events/script-tests/basic.js
>@@ -86,7 +86,7 @@ function step5()
> function step6()
> {
>     shouldBe("storageEventList.length", "8");
>-    shouldBeNull("storageEventList[7].key");
>+    shouldBeEqualToString("storageEventList[7].key", "");
>     shouldBeNull("storageEventList[7].oldValue");
>     shouldBeNull("storageEventList[7].newValue");
>

Actions: View | Formatted Diff | Diff

Attachments on bug 73125: 116600 | 116605