Attachment 116053 Details for Bug 71801 – Patch

[patch] Patch

bug-71801-20111121104450.patch (text/plain), 2.19 KB, created by Andy Wingo on 2011-11-21 01:44:52 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Wingo

Created: 2011-11-21 01:44:52 PST

Size: 2.19 KB

patch

obsolete

>Subversion Revision: 100888
>diff --git a/PerformanceTests/SunSpider/ChangeLog b/PerformanceTests/SunSpider/ChangeLog
>index d85348efe7aa1b82e7b29ad0a9eee6c9456978d4..a582bb7f0a1fceb1e54f24ae8dadfdc6bd32b5eb 100644
>--- a/PerformanceTests/SunSpider/ChangeLog
>+++ b/PerformanceTests/SunSpider/ChangeLog
>@@ -1,3 +1,15 @@
>+2011-11-21  Andy Wingo  <wingo@igalia.com>
>+
>+        Benchmark using higher-precision timers
>+        https://bugs.webkit.org/show_bug.cgi?id=71801
>+
>+        This shows up on SunSpider as a huge lose, because we are counting
>+        fractions of milliseconds that were truncated off before.
>+        It is not an actual slowdown, though.
>+
>+        * resources/sunspider-standalone-driver.js: Use preciseTime() and
>+        load() instead of run().
>+
> 2011-11-15  Andy Wingo  <wingo@igalia.com>
> 
>         Extend sunspider driver to be able to run kraken
>diff --git a/PerformanceTests/SunSpider/resources/sunspider-standalone-driver.js b/PerformanceTests/SunSpider/resources/sunspider-standalone-driver.js
>index e6686f1f63856b1c45e541c3d9fca392e4c4e77d..2d84d6bdbdb836a1b9e7c1d861b635027115ae70 100644
>--- a/PerformanceTests/SunSpider/resources/sunspider-standalone-driver.js
>+++ b/PerformanceTests/SunSpider/resources/sunspider-standalone-driver.js
>@@ -41,18 +41,13 @@ for (var j = 0; j < tests.length; j++) {
>     } else {
>         // Tests may or may not have associated -data files whose loading
>         // should not be timed.
>-        try {
>-            load(testData);
>-            // If a file does have test data, then we can't use the
>-            // higher-precision `run' timer, because `run' uses a fresh
>-            // global environment, so we fall back to `load'.
>-            var startTime = new Date;
>-            load(testName);
>-            times[j] = new Date() - startTime;
>-        } catch (e) {
>-            // No test data, just use `run'.
>-            times[j] = run(testName);
>-        }
>+        try { load(testData); } catch (e) { }
>+
>+        // Use JSC-specific preciseTime(), which returns a time in seconds
>+        // as a floating-point number.
>+        var startTime = preciseTime();
>+        load(testName);
>+        times[j] = (preciseTime() - startTime) * 1000;
>     }
>     gc();
> }

Flags:

mjs: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 71801: 114045 | 116051 | 116053