WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-68414-20110919165044.patch (text/plain), 37.65 KB, created by
Adam Barth
on 2011-09-19 16:50:45 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Adam Barth
Created:
2011-09-19 16:50:45 PDT
Size:
37.65 KB
patch
obsolete
>Index: ChangeLog >=================================================================== >--- ChangeLog (revision 95495) >+++ ChangeLog (working copy) >@@ -1,3 +1,15 @@ >+2011-09-19 Adam Barth <abarth@webkit.org> >+ >+ Always enable ENABLE(EVENTSOURCE) >+ https://bugs.webkit.org/show_bug.cgi?id=68414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Source/cmake/OptionsEfl.cmake: >+ * Source/cmake/OptionsWinCE.cmake: >+ * Source/cmakeconfig.h.cmake: >+ * configure.ac: >+ > 2011-09-17 Ryuan Choi <ryuan.choi@samsung.com> > > [EFL] Bump minimum requirement for cairo to 1.10. >Index: configure.ac >=================================================================== >--- configure.ac (revision 95488) >+++ configure.ac (working copy) >@@ -502,14 +502,6 @@ AC_ARG_ENABLE(sql_database, > [],[enable_sql_database="yes"]) > AC_MSG_RESULT([$enable_sql_database]) > >-# check whether to build with server-sent events support >-AC_MSG_CHECKING([whether to enable HTML5 server-sent events support]) >-AC_ARG_ENABLE(eventsource, >- AC_HELP_STRING([--enable-eventsource], >- [enable HTML5 server-sent events support [default=yes]]), >- [],[enable_eventsource="yes"]) >-AC_MSG_RESULT([$enable_eventsource]) >- > # check whether to build with icon database support > AC_MSG_CHECKING([whether to enable icon database support]) > AC_ARG_ENABLE(icon_database, >@@ -1135,7 +1127,6 @@ AM_CONDITIONAL([ENABLE_DOM_STORAGE],[tes > AM_CONDITIONAL([ENABLE_SQL_DATABASE],[test "$enable_sql_database" = "yes"]) > AM_CONDITIONAL([ENABLE_DATALIST],[test "$enable_datalist" = "yes"]) > AM_CONDITIONAL([ENABLE_DETAILS],[test "$enable_details" = "yes"]) >-AM_CONDITIONAL([ENABLE_EVENTSOURCE],[test "$enable_eventsource" = "yes"]) > AM_CONDITIONAL([ENABLE_FAST_MOBILE_SCROLLING],[test "$enable_fast_mobile_scrolling" = "yes"]) > AM_CONDITIONAL([ENABLE_FILE_SYSTEM],[test "$enable_file_system" = "yes"]) > AM_CONDITIONAL([ENABLE_QUOTA],[test "$enable_quota" = "yes"]) >@@ -1254,7 +1245,6 @@ Features: > HTML5 FileSystem API support : $enable_file_system > Quota API support : $enable_quota > HTML5 sandboxed iframe support : $enable_sandbox >- HTML5 server-sent events support : $enable_eventsource > HTML5 video element support : $enable_video > HTML5 track element support : $enable_video_track > Fullscreen API support : $enable_fullscreen_api >Index: Source/cmakeconfig.h.cmake >=================================================================== >--- Source/cmakeconfig.h.cmake (revision 95488) >+++ Source/cmakeconfig.h.cmake (working copy) >@@ -14,7 +14,6 @@ > #cmakedefine01 ENABLE_DATA_TRANSFER_ITEMS > #cmakedefine01 ENABLE_DEVICE_ORIENTATION > #cmakedefine01 ENABLE_DOM_STORAGE >-#cmakedefine01 ENABLE_EVENTSOURCE > #cmakedefine01 ENABLE_FAST_MOBILE_SCROLLING > #cmakedefine01 ENABLE_FILTERS > #cmakedefine01 ENABLE_FTPDIR >Index: Source/JavaScriptCore/ChangeLog >=================================================================== >--- Source/JavaScriptCore/ChangeLog (revision 95495) >+++ Source/JavaScriptCore/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2011-09-19 Adam Barth <abarth@webkit.org> >+ >+ Always enable ENABLE(EVENTSOURCE) >+ https://bugs.webkit.org/show_bug.cgi?id=68414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/FeatureDefines.xcconfig: >+ > 2011-09-19 Oliver Hunt <oliver@apple.com> > > Refactor Heap allocation logic into separate AllocationSpace class >Index: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >=================================================================== >--- Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig (revision 95488) >+++ Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig (working copy) >@@ -62,7 +62,6 @@ ENABLE_DETAILS = ENABLE_DETAILS; > ENABLE_DEVICE_ORIENTATION = ; > ENABLE_DIRECTORY_UPLOAD = ; > ENABLE_DOM_STORAGE = ENABLE_DOM_STORAGE; >-ENABLE_EVENTSOURCE = ENABLE_EVENTSOURCE; > ENABLE_FILE_SYSTEM = ; > ENABLE_FULLSCREEN_API = ENABLE_FULLSCREEN_API; > ENABLE_GEOLOCATION = ENABLE_GEOLOCATION; >@@ -97,4 +96,4 @@ ENABLE_XHTMLMP = ; > ENABLE_XPATH = ENABLE_XPATH; > ENABLE_XSLT = ENABLE_XSLT; > >-FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_CSS_EXCLUSIONS) $(ENABLE_CSS_REGIONS) $(ENABLE_SQL_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); >+FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_CSS_EXCLUSIONS) $(ENABLE_CSS_REGIONS) $(ENABLE_SQL_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); >Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 95495) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,34 @@ >+2011-09-19 Adam Barth <abarth@webkit.org> >+ >+ Always enable ENABLE(EVENTSOURCE) >+ https://bugs.webkit.org/show_bug.cgi?id=68414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ EventSource seems to be here to stay. This patch makes WebKit more >+ hackable by removing this ENABLE macro, as discussed on webkit-dev. >+ >+ * Configurations/FeatureDefines.xcconfig: >+ * GNUmakefile.am: >+ * bindings/cpp/WebDOMEventTarget.cpp: >+ (toWebKit): >+ * bindings/js/JSDOMWindowCustom.cpp: >+ (WebCore::JSDOMWindow::eventSource): >+ * bindings/js/JSEventSourceCustom.cpp: >+ * bindings/js/JSEventTarget.cpp: >+ (WebCore::toJS): >+ (WebCore::toEventTarget): >+ * bindings/js/JSWorkerContextCustom.cpp: >+ (WebCore::JSWorkerContext::eventSource): >+ * bindings/v8/V8DOMWrapper.cpp: >+ (WebCore::V8DOMWrapper::convertEventTargetToV8Object): >+ * features.pri: >+ * page/DOMWindow.idl: >+ * page/EventSource.cpp: >+ * page/EventSource.h: >+ * page/EventSource.idl: >+ * workers/WorkerContext.idl: >+ > 2011-09-19 Sheriff Bot <webkit.review.bot@gmail.com> > > Unreviewed, rolling out r95482. >Index: Source/WebCore/GNUmakefile.am >=================================================================== >--- Source/WebCore/GNUmakefile.am (revision 95488) >+++ Source/WebCore/GNUmakefile.am (working copy) >@@ -208,16 +208,6 @@ webcore_cppflags += -DENABLE_DATA_TRANSF > endif # END ENABLE_DATA_TRANSFER_ITEMS > > # ---- >-# HTML5 server-sent events >-# ---- >-if !ENABLE_EVENTSOURCE >-global_cppflags += -DENABLE_EVENTSOURCE=0 >-else >-FEATURE_DEFINES += ENABLE_EVENTSOURCE=1 >-webcore_cppflags += -DENABLE_EVENTSOURCE=1 >-endif # ENABLE_EVENTSOURCE >- >-# ---- > # Indexed Database API support > # ---- > if ENABLE_INDEXED_DATABASE >Index: Source/WebCore/features.pri >=================================================================== >--- Source/WebCore/features.pri (revision 95488) >+++ Source/WebCore/features.pri (working copy) >@@ -48,7 +48,6 @@ isEmpty(HAVE_QRAWFONT) { > > !contains(DEFINES, ENABLE_JAVASCRIPT_DEBUGGER=.): DEFINES += ENABLE_JAVASCRIPT_DEBUGGER=1 > !contains(DEFINES, ENABLE_SQL_DATABASE=.): DEFINES += ENABLE_SQL_DATABASE=1 >-!contains(DEFINES, ENABLE_EVENTSOURCE=.): DEFINES += ENABLE_EVENTSOURCE=1 > !contains(DEFINES, ENABLE_OFFLINE_WEB_APPLICATIONS=.): DEFINES += ENABLE_OFFLINE_WEB_APPLICATIONS=1 > !contains(DEFINES, ENABLE_DOM_STORAGE=.): DEFINES += ENABLE_DOM_STORAGE=1 > !contains(DEFINES, ENABLE_ICONDATABASE=.): DEFINES += ENABLE_ICONDATABASE=1 >@@ -207,7 +206,6 @@ FEATURE_DEFINES_JAVASCRIPT = LANGUAGE_JA > v8: FEATURE_DEFINES_JAVASCRIPT += V8_BINDING=1 > contains(DEFINES, ENABLE_CHANNEL_MESSAGING=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_CHANNEL_MESSAGING=1 > contains(DEFINES, ENABLE_ORIENTATION_EVENTS=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_ORIENTATION_EVENTS=1 >-contains(DEFINES, ENABLE_EVENTSOURCE=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_EVENTSOURCE=1 > contains(DEFINES, ENABLE_SQL_DATABASE=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SQL_DATABASE=1 > contains(DEFINES, ENABLE_DATALIST=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_DATALIST=1 > contains(DEFINES, ENABLE_DOM_STORAGE=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_DOM_STORAGE=1 >Index: Source/WebCore/Configurations/FeatureDefines.xcconfig >=================================================================== >--- Source/WebCore/Configurations/FeatureDefines.xcconfig (revision 95488) >+++ Source/WebCore/Configurations/FeatureDefines.xcconfig (working copy) >@@ -60,7 +60,6 @@ ENABLE_DETAILS = ENABLE_DETAILS; > ENABLE_DEVICE_ORIENTATION = ; > ENABLE_DIRECTORY_UPLOAD = ; > ENABLE_DOM_STORAGE = ENABLE_DOM_STORAGE; >-ENABLE_EVENTSOURCE = ENABLE_EVENTSOURCE; > ENABLE_FILE_SYSTEM = ; > ENABLE_FULLSCREEN_API = ENABLE_FULLSCREEN_API; > ENABLE_GEOLOCATION = ENABLE_GEOLOCATION; >@@ -96,4 +95,4 @@ ENABLE_XHTMLMP = ; > ENABLE_XPATH = ENABLE_XPATH; > ENABLE_XSLT = ENABLE_XSLT; > >-FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_SQL_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); >+FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_SQL_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); >Index: Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp >=================================================================== >--- Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp (revision 95488) >+++ Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp (working copy) >@@ -102,10 +102,7 @@ ConvertTo(DOMWindow) > ConvertTo(XMLHttpRequest) > ConvertTo(XMLHttpRequestUpload) > ConvertTo(MessagePort) >- >-#if ENABLE(EVENTSOURCE) > ConvertTo(EventSource) >-#endif > > #if ENABLE(OFFLINE_WEB_APPLICATIONS) > ConvertTo(DOMApplicationCache) >@@ -151,10 +148,8 @@ WebDOMEventTarget toWebKit(WebCore::Even > if (WebCore::MessagePort* messagePort = value->toMessagePort()) > return toWebKit(messagePort); > >-#if ENABLE(EVENTSOURCE) > if (WebCore::EventSource* eventSource = value->toEventSource()) > return toWebKit(eventSource); >-#endif > > #if ENABLE(SVG) && 0 > // FIXME: Enable once SVG bindings are generated. >Index: Source/WebCore/bindings/js/JSDOMWindowCustom.cpp >=================================================================== >--- Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (revision 95488) >+++ Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (working copy) >@@ -482,12 +482,10 @@ JSValue JSDOMWindow::event(ExecState* ex > return toJS(exec, const_cast<JSDOMWindow*>(this), event); > } > >-#if ENABLE(EVENTSOURCE) > JSValue JSDOMWindow::eventSource(ExecState* exec) const > { > return getDOMConstructor<JSEventSourceConstructor>(exec, this); > } >-#endif > > JSValue JSDOMWindow::image(ExecState* exec) const > { >Index: Source/WebCore/bindings/js/JSEventSourceCustom.cpp >=================================================================== >--- Source/WebCore/bindings/js/JSEventSourceCustom.cpp (revision 95488) >+++ Source/WebCore/bindings/js/JSEventSourceCustom.cpp (working copy) >@@ -30,9 +30,6 @@ > */ > > #include "config.h" >- >-#if ENABLE(EVENTSOURCE) >- > #include "JSEventSource.h" > > #include "EventSource.h" >@@ -69,5 +66,3 @@ EncodedJSValue JSC_HOST_CALL JSEventSour > } > > } // namespace WebCore >- >-#endif // ENABLE(EVENTSOURCE) >Index: Source/WebCore/bindings/js/JSEventTarget.cpp >=================================================================== >--- Source/WebCore/bindings/js/JSEventTarget.cpp (revision 95488) >+++ Source/WebCore/bindings/js/JSEventTarget.cpp (working copy) >@@ -51,10 +51,8 @@ > #include "XMLHttpRequest.h" > #include "XMLHttpRequestUpload.h" > >-#if ENABLE(EVENTSOURCE) > #include "EventSource.h" > #include "JSEventSource.h" >-#endif > > #if ENABLE(OFFLINE_WEB_APPLICATIONS) > #include "DOMApplicationCache.h" >@@ -113,11 +111,9 @@ JSValue toJS(ExecState* exec, JSDOMGloba > { > if (!target) > return jsNull(); >- >-#if ENABLE(EVENTSOURCE) >+ > if (EventSource* eventSource = target->toEventSource()) > return toJS(exec, globalObject, eventSource); >-#endif > > #if ENABLE(SVG) > // SVGElementInstance supports both toSVGElementInstance and toNode since so much mouse handling code depends on toNode returning a valid node. >@@ -220,9 +216,7 @@ EventTarget* toEventTarget(JSC::JSValue > if (value.inherits(&JSDOMWindowShell::s_info)) > return static_cast<JSDOMWindowShell*>(asObject(value))->impl(); > >-#if ENABLE(EVENTSOURCE) > CONVERT_TO_EVENT_TARGET(EventSource) >-#endif > > #if ENABLE(OFFLINE_WEB_APPLICATIONS) > CONVERT_TO_EVENT_TARGET(DOMApplicationCache) >Index: Source/WebCore/bindings/js/JSWorkerContextCustom.cpp >=================================================================== >--- Source/WebCore/bindings/js/JSWorkerContextCustom.cpp (revision 95488) >+++ Source/WebCore/bindings/js/JSWorkerContextCustom.cpp (working copy) >@@ -84,12 +84,10 @@ bool JSWorkerContext::getOwnPropertyDesc > return false; > } > >-#if ENABLE(EVENTSOURCE) > JSValue JSWorkerContext::eventSource(ExecState* exec) const > { > return getDOMConstructor<JSEventSourceConstructor>(exec, this); > } >-#endif > > JSValue JSWorkerContext::xmlHttpRequest(ExecState* exec) const > { >Index: Source/WebCore/bindings/v8/V8DOMWrapper.cpp >=================================================================== >--- Source/WebCore/bindings/v8/V8DOMWrapper.cpp (revision 95488) >+++ Source/WebCore/bindings/v8/V8DOMWrapper.cpp (working copy) >@@ -427,10 +427,8 @@ v8::Handle<v8::Value> V8DOMWrapper::conv > return toV8(domAppCache); > #endif > >-#if ENABLE(EVENTSOURCE) > if (EventSource* eventSource = target->toEventSource()) > return toV8(eventSource); >-#endif > > #if ENABLE(BLOB) > if (FileReader* fileReader = target->toFileReader()) >Index: Source/WebCore/page/DOMWindow.idl >=================================================================== >--- Source/WebCore/page/DOMWindow.idl (revision 95488) >+++ Source/WebCore/page/DOMWindow.idl (working copy) >@@ -571,9 +571,7 @@ module window { > attribute RangeConstructor Range; > attribute RangeExceptionConstructor RangeException; > >-#if ENABLE_EVENTSOURCE > attribute [JSCCustomGetter] EventSourceConstructor EventSource; // Usable with new the operator >-#endif > > // Mozilla has a separate XMLDocument object for XML documents. > // We just use Document for this. >Index: Source/WebCore/page/EventSource.cpp >=================================================================== >--- Source/WebCore/page/EventSource.cpp (revision 95488) >+++ Source/WebCore/page/EventSource.cpp (working copy) >@@ -32,9 +32,6 @@ > */ > > #include "config.h" >- >-#if ENABLE(EVENTSOURCE) >- > #include "EventSource.h" > > #include "MemoryCache.h" >@@ -376,5 +373,3 @@ EventTargetData* EventSource::ensureEven > } > > } // namespace WebCore >- >-#endif // ENABLE(EVENTSOURCE) >Index: Source/WebCore/page/EventSource.h >=================================================================== >--- Source/WebCore/page/EventSource.h (revision 95488) >+++ Source/WebCore/page/EventSource.h (working copy) >@@ -33,8 +33,6 @@ > #ifndef EventSource_h > #define EventSource_h > >-#if ENABLE(EVENTSOURCE) >- > #include "ActiveDOMObject.h" > #include "EventTarget.h" > #include "KURL.h" >@@ -125,6 +123,4 @@ namespace WebCore { > > } // namespace WebCore > >-#endif // ENABLE(EVENTSOURCE) >- > #endif // EventSource_h >Index: Source/WebCore/page/EventSource.idl >=================================================================== >--- Source/WebCore/page/EventSource.idl (revision 95488) >+++ Source/WebCore/page/EventSource.idl (working copy) >@@ -32,7 +32,6 @@ > module window { > > interface [ >- Conditional=EVENTSOURCE, > ActiveDOMObject, > CanBeConstructed, > CustomConstructFunction, >Index: Source/WebCore/workers/WorkerContext.idl >=================================================================== >--- Source/WebCore/workers/WorkerContext.idl (revision 95488) >+++ Source/WebCore/workers/WorkerContext.idl (working copy) >@@ -88,9 +88,7 @@ module threads { > #if ENABLE_CHANNEL_MESSAGING > attribute [JSCCustomGetter] MessageChannelConstructor MessageChannel; > #endif >-#if ENABLE_EVENTSOURCE > attribute [JSCCustomGetter] EventSourceConstructor EventSource; >-#endif > attribute [JSCCustomGetter] XMLHttpRequestConstructor XMLHttpRequest; > #if defined(ENABLE_WEB_SOCKETS) && ENABLE_WEB_SOCKETS > attribute [JSCCustomGetter,EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator >Index: Source/WebKit2/ChangeLog >=================================================================== >--- Source/WebKit2/ChangeLog (revision 95495) >+++ Source/WebKit2/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2011-09-19 Adam Barth <abarth@webkit.org> >+ >+ Always enable ENABLE(EVENTSOURCE) >+ https://bugs.webkit.org/show_bug.cgi?id=68414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/FeatureDefines.xcconfig: >+ > 2011-09-19 Alexis Menard <alexis.menard@openbossa.org> > > [Qt] Unreviewed coding style fix. >Index: Source/WebKit2/Configurations/FeatureDefines.xcconfig >=================================================================== >--- Source/WebKit2/Configurations/FeatureDefines.xcconfig (revision 95488) >+++ Source/WebKit2/Configurations/FeatureDefines.xcconfig (working copy) >@@ -60,7 +60,6 @@ ENABLE_DETAILS = ENABLE_DETAILS; > ENABLE_DEVICE_ORIENTATION = ; > ENABLE_DIRECTORY_UPLOAD = ; > ENABLE_DOM_STORAGE = ENABLE_DOM_STORAGE; >-ENABLE_EVENTSOURCE = ENABLE_EVENTSOURCE; > ENABLE_FILE_SYSTEM = ; > ENABLE_FULLSCREEN_API = ENABLE_FULLSCREEN_API; > ENABLE_GEOLOCATION = ENABLE_GEOLOCATION; >@@ -96,4 +95,4 @@ ENABLE_XHTMLMP = ; > ENABLE_XPATH = ENABLE_XPATH; > ENABLE_XSLT = ENABLE_XSLT; > >-FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); >+FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); >Index: Source/WebKit/chromium/ChangeLog >=================================================================== >--- Source/WebKit/chromium/ChangeLog (revision 95495) >+++ Source/WebKit/chromium/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2011-09-19 Adam Barth <abarth@webkit.org> >+ >+ Always enable ENABLE(EVENTSOURCE) >+ https://bugs.webkit.org/show_bug.cgi?id=68414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * features.gypi: >+ > 2011-09-19 Robert Kroeger <rjkroege@chromium.org> > > Suppress flakey test on windows in Chromium gesture recognizer >Index: Source/WebKit/chromium/features.gypi >=================================================================== >--- Source/WebKit/chromium/features.gypi (revision 95488) >+++ Source/WebKit/chromium/features.gypi (working copy) >@@ -44,7 +44,6 @@ > 'ENABLE_DIRECTORY_UPLOAD=1', > 'ENABLE_DOM_STORAGE=1', > 'ENABLE_DOWNLOAD_ATTRIBUTE=1', >- 'ENABLE_EVENTSOURCE=1', > 'ENABLE_FILE_SYSTEM=1', > 'ENABLE_FILTERS=1', > 'ENABLE_FULLSCREEN_API=1', >Index: Source/WebKit/mac/ChangeLog >=================================================================== >--- Source/WebKit/mac/ChangeLog (revision 95495) >+++ Source/WebKit/mac/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2011-09-19 Adam Barth <abarth@webkit.org> >+ >+ Always enable ENABLE(EVENTSOURCE) >+ https://bugs.webkit.org/show_bug.cgi?id=68414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/FeatureDefines.xcconfig: >+ > 2011-09-19 Anders Carlsson <andersca@apple.com> > > Fix crashes when running WebKit1 tests. >Index: Source/WebKit/mac/Configurations/FeatureDefines.xcconfig >=================================================================== >--- Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (revision 95488) >+++ Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (working copy) >@@ -60,7 +60,6 @@ ENABLE_DETAILS = ENABLE_DETAILS; > ENABLE_DEVICE_ORIENTATION = ; > ENABLE_DIRECTORY_UPLOAD = ; > ENABLE_DOM_STORAGE = ENABLE_DOM_STORAGE; >-ENABLE_EVENTSOURCE = ENABLE_EVENTSOURCE; > ENABLE_FILE_SYSTEM = ; > ENABLE_FULLSCREEN_API = ENABLE_FULLSCREEN_API; > ENABLE_GEOLOCATION = ENABLE_GEOLOCATION; >@@ -96,4 +95,4 @@ ENABLE_XHTMLMP = ; > ENABLE_XPATH = ENABLE_XPATH; > ENABLE_XSLT = ENABLE_XSLT; > >-FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); >+FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); >Index: Source/cmake/OptionsEfl.cmake >=================================================================== >--- Source/cmake/OptionsEfl.cmake (revision 95488) >+++ Source/cmake/OptionsEfl.cmake (working copy) >@@ -68,7 +68,6 @@ WEBKIT_FEATURE(ENABLE_DATALIST "Enable d > WEBKIT_FEATURE(ENABLE_DATA_TRANSFER_ITEMS "Enable data transfer items" DEFAULT OFF) > WEBKIT_FEATURE(ENABLE_DEVICE_ORIENTATION "Enable device orientation" DEFAULT OFF) > WEBKIT_FEATURE(ENABLE_DOM_STORAGE "Enable DOM storage" DEFAULT ON) >-WEBKIT_FEATURE(ENABLE_EVENTSOURCE "Enable event source" DEFAULT ON) > WEBKIT_FEATURE(ENABLE_FAST_MALLOC "Enable TCmalloc instead of system's allocator" DEFAULT ON) > WEBKIT_FEATURE(ENABLE_FAST_MOBILE_SCROLLING "Enable fast mobile scrolling" DEFAULT ON) > WEBKIT_FEATURE(ENABLE_FILTERS "Enable SVG filters" DEFAULT ON SVG) >Index: Source/cmake/OptionsWinCE.cmake >=================================================================== >--- Source/cmake/OptionsWinCE.cmake (revision 95488) >+++ Source/cmake/OptionsWinCE.cmake (working copy) >@@ -28,7 +28,6 @@ WEBKIT_FEATURE(ENABLE_DATAGRID "Enable d > WEBKIT_FEATURE(ENABLE_DATALIST "Enable datalist" DEFAULT OFF HTML) > WEBKIT_FEATURE(ENABLE_DATA_TRANSFER_ITEMS "Enable data transfer items" DEFAULT OFF) > WEBKIT_FEATURE(ENABLE_DOM_STORAGE "Enable DOM storage" DEFAULT OFF) >-WEBKIT_FEATURE(ENABLE_EVENTSOURCE "Enable event source" DEFAULT ON) > WEBKIT_FEATURE(ENABLE_FAST_MOBILE_SCROLLING "Enable fast mobile scrolling" DEFAULT ON) > WEBKIT_FEATURE(ENABLE_FILTERS "Enable SVG filters" DEFAULT OFF SVG) > WEBKIT_FEATURE(ENABLE_FTPDIR "Enable FTP directory support" DEFAULT OFF) >Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 95495) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2011-09-19 Adam Barth <abarth@webkit.org> >+ >+ Always enable ENABLE(EVENTSOURCE) >+ https://bugs.webkit.org/show_bug.cgi?id=68414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Scripts/build-webkit: >+ > 2011-09-19 Alexis Menard <alexis.menard@openbossa.org> > > Style checker should not check public Qt WK2 API for parameter_name. >Index: Tools/Scripts/build-webkit >=================================================================== >--- Tools/Scripts/build-webkit (revision 95488) >+++ Tools/Scripts/build-webkit (working copy) >@@ -81,7 +81,6 @@ my ( > $deviceOrientationSupport, > $directoryUploadSupport, > $domStorageSupport, >- $eventsourceSupport, > $fileSystemSupport, > $filtersSupport, > $fullscreenAPISupport, >@@ -179,9 +178,6 @@ my @features = ( > { option => "dom-storage", desc => "Toggle DOM Storage Support", > define => "ENABLE_DOM_STORAGE", default => 1, value => \$domStorageSupport }, > >- { option => "eventsource", desc => "Toggle server-sent events support", >- define => "ENABLE_EVENTSOURCE", default => 1, value => \$eventsourceSupport }, >- > { option => "file-system", desc => "Toggle FileSystem support", > define => "ENABLE_FILE_SYSTEM", default => 0, value => \$fileSystemSupport }, > >Index: WebKitLibraries/ChangeLog >=================================================================== >--- WebKitLibraries/ChangeLog (revision 95495) >+++ WebKitLibraries/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2011-09-19 Adam Barth <abarth@webkit.org> >+ >+ Always enable ENABLE(EVENTSOURCE) >+ https://bugs.webkit.org/show_bug.cgi?id=68414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * win/tools/vsprops/FeatureDefines.vsprops: >+ * win/tools/vsprops/FeatureDefinesCairo.vsprops: >+ > 2011-09-15 Adam Barth <abarth@webkit.org> > > Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE) >Index: WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops >=================================================================== >--- WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops (revision 95488) >+++ WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops (working copy) >@@ -9,7 +9,7 @@ > > > <Tool > Name="VCCLCompilerTool" >- PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_EVENTSOURCE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)" >+ PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)" > /> > <UserMacro > Name="ENABLE_3D_CANVAS" >@@ -92,11 +92,6 @@ > PerformEnvironmentSet="true" > /> > <UserMacro >- Name="ENABLE_EVENTSOURCE" >- Value="ENABLE_EVENTSOURCE" >- PerformEnvironmentSet="true" >- /> >- <UserMacro > Name="ENABLE_FILTERS" > Value="ENABLE_FILTERS" > PerformEnvironmentSet="true" >Index: WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops >=================================================================== >--- WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops (revision 95488) >+++ WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops (working copy) >@@ -9,7 +9,7 @@ > > > <Tool > Name="VCCLCompilerTool" >- PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_EVENTSOURCE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)" >+ PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)" > /> > <UserMacro > Name="ENABLE_3D_CANVAS" >@@ -92,11 +92,6 @@ > PerformEnvironmentSet="true" > /> > <UserMacro >- Name="ENABLE_EVENTSOURCE" >- Value="ENABLE_EVENTSOURCE" >- PerformEnvironmentSet="true" >- /> >- <UserMacro > Name="ENABLE_FILTERS" > Value="ENABLE_FILTERS" > PerformEnvironmentSet="true"
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=107945">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 68414
: 107945