Attachment 106411 Details for Bug 66937 – Patch

[patch] Patch

bug-66937-20110906190456.patch (text/plain), 5.99 KB, created by Sameer Patil on 2011-09-06 06:39:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sameer Patil

Created: 2011-09-06 06:39:55 PDT

Size: 5.99 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 94564)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2011-09-06  Sameer Patil  <mkrp87@motorola.com>
>+
>+        Locking padding size of input type search element on Webkit-GTK.
>+        https://bugs.webkit.org/show_bug.cgi?id=66937
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: fast/forms/search-styled-padding.html
>+
>+        * platform/gtk/RenderThemeGtk.cpp:
>+        (WebCore::RenderThemeGtk::adjustSearchFieldStyle):
>+        Locking input type search element padding so it will render as par with Safari when padding of search
>+        element is more than 1px.
>+        Also setting outline offset when input type search element is active to avoid focus ring looking
>+        outset to input element box.
>+
> 2011-09-06  Rob Buis  <rbuis@rim.com>
> 
>         use after free in WebCore::SVGTRefElement::updateReferencedText
>Index: Source/WebCore/platform/gtk/RenderThemeGtk.cpp
>===================================================================
>--- Source/WebCore/platform/gtk/RenderThemeGtk.cpp	(revision 94562)
>+++ Source/WebCore/platform/gtk/RenderThemeGtk.cpp	(working copy)
>@@ -27,6 +27,7 @@
> 
> #include "CSSValueKeywords.h"
> #include "FileSystem.h"
>+#include "Frame.h"
> #include "GOwnPtr.h"
> #include "Gradient.h"
> #include "GraphicsContext.h"
>@@ -364,6 +365,14 @@ void RenderThemeGtk::adjustSearchFieldSt
>     // We cannot give a proper rendering when border radius is active, unfortunately.
>     style->resetBorderRadius();
>     style->setLineHeight(RenderStyle::initialLineHeight());
>+
>+    const int padding = 1;
>+    style->setPaddingLeft(Length(padding, Fixed));
>+    style->setPaddingRight(Length(padding, Fixed));
>+    style->setPaddingTop(Length(padding, Fixed));
>+    style->setPaddingBottom(Length(padding, Fixed));
>+    if (e && e->focused() && e->document()->frame()->selection()->isFocusedAndActive())
>+        style->setOutlineOffset(-2);
> }
> 
> bool RenderThemeGtk::paintSearchField(RenderObject* o, const PaintInfo& i, const IntRect& rect)
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 94564)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2011-09-06  Sameer Patil  <mkrp87@motorola.com>
>+
>+        Padding size of input type search element is not locked on Webkit-GTK.
>+        https://bugs.webkit.org/show_bug.cgi?id=66937
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/forms/search-styled-padding.html: Added.
>+        * platform/gtk/fast/forms/search-styled-expected.txt:
>+        * platform/gtk/fast/forms/search-styled-padding-expected.txt: Added.
>+
> 2011-09-06  Rob Buis  <rbuis@rim.com>
> 
>         use after free in WebCore::SVGTRefElement::updateReferencedText
>Index: LayoutTests/fast/forms/search-styled-padding.html
>===================================================================
>--- LayoutTests/fast/forms/search-styled-padding.html	(revision 0)
>+++ LayoutTests/fast/forms/search-styled-padding.html	(revision 0)
>@@ -0,0 +1,12 @@
>+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
>+   "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
>+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
>+<head>
>+<style>
>+.inputsearch{padding-left: 25px;padding-right: 25px;padding-top: 25px;padding-bottom: 25px;}
>+</style>
>+</head>
>+<body>
>+<input type="search" class="inputsearch" title="Input type Search element" value="" results="10" />
>+</body>
>+</html>
>\ No newline at end of file
>Index: LayoutTests/platform/gtk/fast/forms/search-styled-expected.txt
>===================================================================
>--- LayoutTests/platform/gtk/fast/forms/search-styled-expected.txt	(revision 94562)
>+++ LayoutTests/platform/gtk/fast/forms/search-styled-expected.txt	(working copy)
>@@ -1,17 +1,17 @@
> layer at (0,0) size 800x600
>   RenderView at (0,0) size 800x600
>-layer at (0,0) size 800x41
>-  RenderBlock {HTML} at (0,0) size 800x41
>-    RenderBody {BODY} at (8,8) size 784x25
>-      RenderTextControl {INPUT} at (2,2) size 148x21 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
>-        RenderDeprecatedFlexibleBox {DIV} at (18,4) size 126x13
>+layer at (0,0) size 800x38
>+  RenderBlock {HTML} at (0,0) size 800x38
>+    RenderBody {BODY} at (8,8) size 784x22
>+      RenderTextControl {INPUT} at (2,3) size 130x17 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
>+        RenderDeprecatedFlexibleBox {DIV} at (2,2) size 126x13
>           RenderBlock {DIV} at (0,1) size 11x11
>           RenderBlock {DIV} at (11,0) size 104x13
>           RenderBlock {DIV} at (115,1) size 11x11
>       RenderText {#text} at (0,0) size 0x0
>-layer at (39,14) size 104x13
>+layer at (23,13) size 104x13
>   RenderBlock {DIV} at (0,0) size 104x13
>-layer at (39,14) size 104x13
>-  RenderBlock (relative positioned) {DIV} at (29,4) size 104x13 [color=#A9A9A9]
>+layer at (23,13) size 104x13
>+  RenderBlock (relative positioned) {DIV} at (13,2) size 104x13 [color=#A9A9A9]
>     RenderText {#text} at (1,0) size 88x13
>       text run at (1,0) width 88: "Search for Events"
>Index: LayoutTests/platform/gtk/fast/forms/search-styled-padding-expected.txt
>===================================================================
>--- LayoutTests/platform/gtk/fast/forms/search-styled-padding-expected.txt	(revision 0)
>+++ LayoutTests/platform/gtk/fast/forms/search-styled-padding-expected.txt	(revision 0)
>@@ -0,0 +1,13 @@
>+layer at (0,0) size 800x600
>+  RenderView at (0,0) size 800x600
>+layer at (0,0) size 800x45
>+  RenderBlock {HTML} at (0,0) size 800x45
>+    RenderBody {BODY} at (8,8) size 784x29
>+      RenderTextControl {INPUT} at (2,2) size 194x25 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
>+        RenderDeprecatedFlexibleBox {DIV} at (3,3) size 188x19
>+          RenderBlock {DIV} at (0,1) size 16x16
>+          RenderBlock {DIV} at (16,0) size 156x19
>+          RenderBlock {DIV} at (172,1) size 16x16
>+      RenderText {#text} at (0,0) size 0x0
>+layer at (29,13) size 156x19
>+  RenderBlock {DIV} at (0,0) size 156x19

Flags:

gustavo: review-
webkit.review.bot: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 66937: 105179 | 105180 | 105182 | 106411 | 106413 | 107166