Attachment 104623 Details for Bug 44114 – Patch

[patch] Patch

bug-44114-20110821123424.patch (text/plain), 2.08 KB, created by Lindsay Mathieson on 2011-08-20 19:34:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Lindsay Mathieson

Created: 2011-08-20 19:34:26 PDT

Size: 2.08 KB

patch

obsolete

>Subversion Revision: 93483
>diff --git a/Source/WebKit/qt/ChangeLog b/Source/WebKit/qt/ChangeLog
>index b8f2f6bc48a9064d92c76fde0351f6062c6a7cae..69a063150c31002ea86f08446399e55edc9e7709 100644
>--- a/Source/WebKit/qt/ChangeLog
>+++ b/Source/WebKit/qt/ChangeLog
>@@ -1,3 +1,14 @@
>+2011-08-20  Lindsay Mathieson  <lindsay.mathieson@gmail.com>
>+
>+        Fixes plugin unload bug (local QtPlatformPlugin)
>+        https://bugs.webkit.org/show_bug.cgi?id=44114
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebCoreSupport/TextCheckerClientQt.cpp:
>+        (WebCore::TextCheckerClientQt::loadSpellChecker):
>+        * WebCoreSupport/TextCheckerClientQt.h:
>+
> 2011-08-17  Adam Roben  <aroben@apple.com>
> 
>         Make WebCore keep track of the current device scale factor
>diff --git a/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.cpp b/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.cpp
>index 81b24dc3557a065a4c83964c607edf600b36ff61..d87992fd1e795d740f0dee1351ae85d3752c95b8 100644
>--- a/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.cpp
>+++ b/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.cpp
>@@ -152,8 +152,7 @@ bool TextCheckerClientQt::loadSpellChecker()
>     if (m_spellChecker)
>         return true;
> 
>-    QtPlatformPlugin platformPlugin;
>-    if ((m_spellChecker = platformPlugin.createSpellChecker()))
>+    if ((m_spellChecker = m_platformPlugin.createSpellChecker()))
>         return true;
> 
>     return false;
>diff --git a/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h b/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h
>index 1d249d013538df27f94e86dd175f94a6b44316ac..e78ce1d10c05d235a6a54b3bbbea7eea9ace8483 100644
>--- a/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h
>+++ b/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h
>@@ -29,6 +29,7 @@
> #ifndef TextCheckerClientQt_h
> #define TextCheckerClientQt_h
> 
>+#include "QtPlatformPlugin.h"
> #include "TextCheckerClient.h"
> #include "qwebkitplatformplugin.h"
> 
>@@ -58,6 +59,7 @@ private:
>     bool loadSpellChecker();
> 
> private:
>+    QtPlatformPlugin m_platformPlugin;
>     OwnPtr<QWebSpellChecker> m_spellChecker;
> };
>

Flags:

benjamin: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 44114: 102872 | 102875 | 103074 | 103075 | 103087 | 103765 | 103840 | 103842 | 103905 | 103995 | 104623