- a/LayoutTests/ChangeLog +11 lines
Lines 1-3 a/LayoutTests/ChangeLog_sec1
1
2011-06-03  Dominic Cooney  <dominicc@chromium.org>
2
3
        Reviewed by NOBODY (OOPS!).
4
5
        Adds a test that keygen clones have the right shadow pseudoclass.
6
        https://bugs.webkit.org/show_bug.cgi?id=61984
7
8
        * fast/html/clone-keygen-expected.txt: Added.
9
        * fast/html/clone-keygen.html: Added.
10
        * platform/win/Skipped: Test needs DRT functionality not in this port.
11
1
2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>
12
2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>
2
13
3
        Unreviewed. Test rebaseline for GTK after revision 87936.
14
        Unreviewed. Test rebaseline for GTK after revision 87936.
- a/LayoutTests/fast/html/clone-keygen-expected.txt +9 lines
Line 0 a/LayoutTests/fast/html/clone-keygen-expected.txt_sec1
1
Tests that a cloned keygen has the right shadow pseudo ID. You should see two big keygens with purple text (they should look the same.)
2
3
4
PASS specialK.clientHeight is k.clientHeight
5
PASS layoutTestController.shadowPseudoId(cloneShadow.firstChild) is layoutTestController.shadowPseudoId(kShadow.firstChild)
6
PASS successfullyParsed is true
7
8
TEST COMPLETE
9
- a/LayoutTests/fast/html/clone-keygen.html +39 lines
Line 0 a/LayoutTests/fast/html/clone-keygen.html_sec1
1
<!DOCTYPE html>
2
<html>
3
<head>
4
<script src="../js/resources/js-test-pre.js"></script>
5
<link rel="stylesheet" href="../js/resources/js-test-style.css">
6
<style type="text/css">
7
*::-webkit-keygen-select {
8
  color: purple;
9
  zoom: 1.5;  /* to work around bug 57966 */
10
}
11
</style>
12
</head>
13
<body>
14
<p>
15
Tests that a cloned keygen has the right shadow pseudo ID. You should
16
see two big keygens with purple text (they should look the same.)
17
</p>
18
<keygen id="k" style="display: block;">
19
<div id="console"></div>
20
<script>
21
var k = document.querySelector('#k');
22
var specialK = k.cloneNode();
23
24
k.insertAdjacentElement('afterEnd', specialK);
25
26
shouldBe('specialK.clientHeight', 'k.clientHeight');
27
28
if (window.layoutTestController) {
29
    var kShadow = layoutTestController.shadowRoot(k);
30
    var cloneShadow = layoutTestController.shadowRoot(specialK);
31
    shouldBe('layoutTestController.shadowPseudoId(cloneShadow.firstChild)',
32
             'layoutTestController.shadowPseudoId(kShadow.firstChild)');
33
}
34
35
var successfullyParsed = true;
36
</script>
37
<script src="../js/resources/js-test-post.js"></script>
38
</body>
39
</html>
- a/LayoutTests/platform/win/Skipped +1 lines
Lines 1285-1290 fast/images/animated-gif-restored-from-bfcache.html a/LayoutTests/platform/win/Skipped_sec1
1285
# Windows DRT needs an implementation of shadowRoot
1285
# Windows DRT needs an implementation of shadowRoot
1286
# https://bugs.webkit.org/show_bug.cgi?id=59081
1286
# https://bugs.webkit.org/show_bug.cgi?id=59081
1287
fast/dom/shadow
1287
fast/dom/shadow
1288
fast/html/clone-keygen.html
1288
fast/html/clone-range.html
1289
fast/html/clone-range.html
1289
inspector/elements/shadow-dom.html
1290
inspector/elements/shadow-dom.html
1290
media/audio-controls-do-not-fade-out.html
1291
media/audio-controls-do-not-fade-out.html
- a/Source/WebCore/ChangeLog +16 lines
Lines 1-5 a/Source/WebCore/ChangeLog_sec1
1
2011-06-03  Dominic Cooney  <dominicc@chromium.org>
1
2011-06-03  Dominic Cooney  <dominicc@chromium.org>
2
2
3
        Reviewed by NOBODY (OOPS!).
4
5
        Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
6
        https://bugs.webkit.org/show_bug.cgi?id=61984
7
8
        When cloneNode's tag name-based cloning algorithm clones the
9
        KeygenSelectElements of a keygen shadow as select elements. These
10
        lack the -webkit-keygen-select pseudoclass.
11
12
        Test: fast/html/clone-keygen.html
13
14
        * html/HTMLKeygenElement.cpp:
15
        (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.
16
17
2011-06-03  Dominic Cooney  <dominicc@chromium.org>
18
3
        Reviewed by Kent Tamura.
19
        Reviewed by Kent Tamura.
4
20
5
        Cloned range input sliders should be SliderThumbElements, not divs.
21
        Cloned range input sliders should be SliderThumbElements, not divs.
- a/Source/WebCore/html/HTMLKeygenElement.cpp +6 lines
Lines 60-65 protected: a/Source/WebCore/html/HTMLKeygenElement.cpp_sec1
60
        : HTMLSelectElement(selectTag, document, 0)
60
        : HTMLSelectElement(selectTag, document, 0)
61
    {
61
    {
62
    }
62
    }
63
64
private:
65
    virtual PassRefPtr<Element> cloneElementWithoutAttributesAndChildren() const
66
    {
67
        return create(document());
68
    }
63
};
69
};
64
70
65
inline HTMLKeygenElement::HTMLKeygenElement(const QualifiedName& tagName, Document* document, HTMLFormElement* form)
71
inline HTMLKeygenElement::HTMLKeygenElement(const QualifiedName& tagName, Document* document, HTMLFormElement* form)

Return to Bug 61984