Attachment #459178 for bug #240313

View Details Raw Unified Return to Bug 240313

| Differences between



2022-05-11  Alejandro G. Castro  <alex@igalia.com>

        [GTK][WPE] Make ANGLE backend EGL context initialization work
        https://bugs.webkit.org/show_bug.cgi?id=240313

        Two different issues at the same time were causing the problem.

        We need to add the current display as a hint for the display
        discovery to make sure it does not use the default in the mesa
        code because it is X11.

        We are also reducing the requirements of the EGL_SURFACE_TYPE
        attribute because the default is EGL_WINDOW_BIT, but we do not
        need that for our surfaceless solution.

        Reviewed by NOBODY (OOPS!).

        No new tests, it fixes the tests for the ANGLE implementation.

        * platform/graphics/gbm/GraphicsContextGLGBM.cpp:
        (WebCore::GraphicsContextGLGBM::platformInitializeContext):

2022-05-09  Gabriel Nava Marino  <gnavamarino@apple.com>

        ASSERT in WebCore::RenderTreeUpdater::updateRenderTree



#include "ANGLEHeaders.h"
#include "Logging.h"
#include "PixelBuffer.h"
#include "PlatformDisplay.h"

#if ENABLE(MEDIA_STREAM)
#include "VideoFrame.h"

        EGL_NONE,
    };

    m_displayObj = EGL_GetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, PlatformDisplay::sharedDisplay().eglDisplay(), displayAttributes.data());
    if (m_displayObj == EGL_NO_DISPLAY)
        return false;



    EGLint configAttributes[] = {
        EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,
        EGL_SURFACE_TYPE, EGL_PBUFFER_BIT,
        EGL_RED_SIZE, 8,
        EGL_GREEN_SIZE, 8,
        EGL_BLUE_SIZE, 8,

Return to Bug 240313

Lines 32-37 a/Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp_sec1
- a/Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp -1 / +3 lines
32	#include "ANGLEHeaders.h"	32	#include "ANGLEHeaders.h"
33	#include "Logging.h"	33	#include "Logging.h"
34	#include "PixelBuffer.h"	34	#include "PixelBuffer.h"
		35	#include "PlatformDisplay.h"
35		36
36	#if ENABLE(MEDIA_STREAM)	37	#if ENABLE(MEDIA_STREAM)
37	#include "VideoFrame.h"	38	#include "VideoFrame.h"
Lines 218-224 bool GraphicsContextGLGBM::platformInitializeContext() a/Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp_sec2
218	EGL_NONE,	219	EGL_NONE,
219	};	220	};
220		221
221	m_displayObj = EGL_GetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, EGL_DEFAULT_DISPLAY, displayAttributes.data());	222	m_displayObj = EGL_GetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, PlatformDisplay::sharedDisplay().eglDisplay(), displayAttributes.data());
222	if (m_displayObj == EGL_NO_DISPLAY)	223	if (m_displayObj == EGL_NO_DISPLAY)
223	return false;	224	return false;
224		225
Lines 234-239 bool GraphicsContextGLGBM::platformInitializeContext() a/Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp_sec3
234		235
235	EGLint configAttributes[] = {	236	EGLint configAttributes[] = {
236	EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,	237	EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,
		238	EGL_SURFACE_TYPE, EGL_PBUFFER_BIT,
237	EGL_RED_SIZE, 8,	239	EGL_RED_SIZE, 8,
238	EGL_GREEN_SIZE, 8,	240	EGL_GREEN_SIZE, 8,
239	EGL_BLUE_SIZE, 8,	241	EGL_BLUE_SIZE, 8,

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +22 lines
		1	2022-05-11 Alejandro G. Castro <alex@igalia.com>
		2
		3	[GTK][WPE] Make ANGLE backend EGL context initialization work
		4	https://bugs.webkit.org/show_bug.cgi?id=240313
		5
		6	Two different issues at the same time were causing the problem.
		7
		8	We need to add the current display as a hint for the display
		9	discovery to make sure it does not use the default in the mesa
		10	code because it is X11.
		11
		12	We are also reducing the requirements of the EGL_SURFACE_TYPE
		13	attribute because the default is EGL_WINDOW_BIT, but we do not
		14	need that for our surfaceless solution.
		15
		16	Reviewed by NOBODY (OOPS!).
		17
		18	No new tests, it fixes the tests for the ANGLE implementation.
		19
		20	* platform/graphics/gbm/GraphicsContextGLGBM.cpp:
		21	(WebCore::GraphicsContextGLGBM::platformInitializeContext):
		22
1	2022-05-09 Gabriel Nava Marino <gnavamarino@apple.com>	23	2022-05-09 Gabriel Nava Marino <gnavamarino@apple.com>
2		24
3	ASSERT in WebCore::RenderTreeUpdater::updateRenderTree	25	ASSERT in WebCore::RenderTreeUpdater::updateRenderTree