Attachment #448563 for bug #234315

View Details Raw Unified Return to Bug 234315

| Differences between



2022-01-06  Cathie Chen  <cathiechen@igalia.com>

        ASSERTION FAILED in RenderLayer::updateClipRects
        https://bugs.webkit.org/show_bug.cgi?id=234315

        Reviewed by NOBODY (OOPS!).

        In clippingRootForPainting(), the dialog element uses the top layer as its clipping root layer.
        When it caculates the clip rects, it caculates all its ancestors' clip rects and caches them
        including the clipping root layer. However, if the ancestor is a transformed layer, it should be
        treated as a root layer. When the tranformed layer updates its clip rects, the root layer won't
        match the one in cache. This patch stops the dialog descendant propagating its clipping root layer
        to the ancestors' in cache.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::clipCrossesPaintingBoundary const):

2022-01-06  Jean-Yves Avenard  <jya@apple.com>

        length argument passed to didReceiveData can never be negative.

Lines 4454-4459 ClipRects* RenderLayer::clipRects(const ClipRectsContext& context) const a/Source/WebCore/rendering/RenderLayer.cpp_sec1
- a/Source/WebCore/rendering/RenderLayer.cpp +3 lines
4454		4454
4455	bool RenderLayer::clipCrossesPaintingBoundary() const	4455	bool RenderLayer::clipCrossesPaintingBoundary() const
4456	{	4456	{
		4457	if (establishesTopLayer())
		4458	return true;
		4459
4457	return parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers)	4460	return parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers)
4458	\|\| parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();	4461	\|\| parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();
4459	}	4462	}



2022-01-06  Cathie Chen  <cathiechen@igalia.com>

        ASSERTION FAILED in RenderLayer::updateClipRects
        https://bugs.webkit.org/show_bug.cgi?id=234315

        Reviewed by NOBODY (OOPS!).

        * TestExpectations:

2022-01-05  Antoine Quint  <graouts@webkit.org>

        computed style for transition longhand properties is wrong




imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html [ ImageOnlyFailure ]

webkit.org/b/234315 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]

webkit.org/b/183994 imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block.html [ Failure ]

# Plugins

Return to Bug 234315

Lines 5073-5080 webkit.org/b/233344 imported/w3c/web-platform-tests/css/motion/offset-rotate-002 a/LayoutTests/TestExpectations_sec1
- a/LayoutTests/TestExpectations -2 lines
5073		5073
5074	imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html [ ImageOnlyFailure ]	5074	imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html [ ImageOnlyFailure ]
5075		5075
5076	webkit.org/b/234315 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]
5077
5078	webkit.org/b/183994 imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block.html [ Failure ]	5076	webkit.org/b/183994 imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block.html [ Failure ]
5079		5077
5080	# Plugins	5078	# Plugins

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +17 lines
		1	2022-01-06 Cathie Chen <cathiechen@igalia.com>
		2
		3	ASSERTION FAILED in RenderLayer::updateClipRects
		4	https://bugs.webkit.org/show_bug.cgi?id=234315
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	In clippingRootForPainting(), the dialog element uses the top layer as its clipping root layer.
		9	When it caculates the clip rects, it caculates all its ancestors' clip rects and caches them
		10	including the clipping root layer. However, if the ancestor is a transformed layer, it should be
		11	treated as a root layer. When the tranformed layer updates its clip rects, the root layer won't
		12	match the one in cache. This patch stops the dialog descendant propagating its clipping root layer
		13	to the ancestors' in cache.
		14
		15	* rendering/RenderLayer.cpp:
		16	(WebCore::RenderLayer::clipCrossesPaintingBoundary const):
		17
1	2022-01-06 Jean-Yves Avenard <jya@apple.com>	18	2022-01-06 Jean-Yves Avenard <jya@apple.com>
2		19
3	length argument passed to didReceiveData can never be negative.	20	length argument passed to didReceiveData can never be negative.

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +9 lines
		1	2022-01-06 Cathie Chen <cathiechen@igalia.com>
		2
		3	ASSERTION FAILED in RenderLayer::updateClipRects
		4	https://bugs.webkit.org/show_bug.cgi?id=234315
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* TestExpectations:
		9
1	2022-01-05 Antoine Quint <graouts@webkit.org>	10	2022-01-05 Antoine Quint <graouts@webkit.org>
2		11
3	computed style for transition longhand properties is wrong	12	computed style for transition longhand properties is wrong