Attachment #444357 for bug #233046

View Details Raw Unified Return to Bug 233046

| Differences between



2021-11-15  Cathie Chen  <cathiechen@igalia.com>

        [CSS contain] The size should be updated if layout containment is inside a fit-content parent
        https://bugs.webkit.org/show_bug.cgi?id=233046

        Reviewed by Rob Buis.

        When the object is a layout containment, we also need to add size containment as the constraint of
        being a relayout boundary. Otherwise when the layout size depends on the content, the layout size
        might not be updated correctly.

        Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html

        * rendering/RenderObject.cpp:
        (WebCore::objectIsRelayoutBoundary):

2021-11-15  Enrique Ocaña González  <eocanha@igalia.com>

        [GTK] webaudio/silent-audio-interrupted-in-background.html is a flaky timeout

Lines 505-511 static inline bool objectIsRelayoutBoundary(const RenderElement* object) a/Source/WebCore/rendering/RenderObject.cpp_sec1
- a/Source/WebCore/rendering/RenderObject.cpp -1 / +1 lines
505	if (object->isTextControl())	505	if (object->isTextControl())
506	return true;	506	return true;
507		507
508	if (shouldApplyLayoutContainment(*object))	508	if (shouldApplyLayoutContainment(object) && shouldApplySizeContainment(object))
509	return true;	509	return true;
510		510
511	if (object->isSVGRoot())	511	if (object->isSVGRoot())



2021-11-15  Cathie Chen  <cathiechen@igalia.com>

        [CSS contain] The size should be updated if layout containment is inside a fit-content parent
        https://bugs.webkit.org/show_bug.cgi?id=233046

        Reviewed by Rob Buis.

        * TestExpectations:

2021-11-15  Cathie Chen  <cathiechen@igalia.com>

        [CSS contain] Update css-contain tests from WPT

Lines 4837-4843 imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-001.html [ Imag a/LayoutTests/TestExpectations_sec1
- a/LayoutTests/TestExpectations -1 lines
4837	imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-002.html [ ImageOnlyFailure ]	4837	imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-002.html [ ImageOnlyFailure ]
4838	imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-003.html [ ImageOnlyFailure ]	4838	imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-003.html [ ImageOnlyFailure ]
4839	imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-004.html [ ImageOnlyFailure ]	4839	imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-004.html [ ImageOnlyFailure ]
4840	imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html [ ImageOnlyFailure ]
4841	imported/w3c/web-platform-tests/css/css-contain/contain-paint-026.html [ ImageOnlyFailure ]	4840	imported/w3c/web-platform-tests/css/css-contain/contain-paint-026.html [ ImageOnlyFailure ]
4842		4841
4843	# Flaky css-contain test	4842	# Flaky css-contain test

Return to Bug 233046

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +16 lines
		1	2021-11-15 Cathie Chen <cathiechen@igalia.com>
		2
		3	[CSS contain] The size should be updated if layout containment is inside a fit-content parent
		4	https://bugs.webkit.org/show_bug.cgi?id=233046
		5
		6	Reviewed by Rob Buis.
		7
		8	When the object is a layout containment, we also need to add size containment as the constraint of
		9	being a relayout boundary. Otherwise when the layout size depends on the content, the layout size
		10	might not be updated correctly.
		11
		12	Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html
		13
		14	* rendering/RenderObject.cpp:
		15	(WebCore::objectIsRelayoutBoundary):
		16
1	2021-11-15 Enrique Ocaña González <eocanha@igalia.com>	17	2021-11-15 Enrique Ocaña González <eocanha@igalia.com>
2		18
3	[GTK] webaudio/silent-audio-interrupted-in-background.html is a flaky timeout	19	[GTK] webaudio/silent-audio-interrupted-in-background.html is a flaky timeout

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +9 lines
		1	2021-11-15 Cathie Chen <cathiechen@igalia.com>
		2
		3	[CSS contain] The size should be updated if layout containment is inside a fit-content parent
		4	https://bugs.webkit.org/show_bug.cgi?id=233046
		5
		6	Reviewed by Rob Buis.
		7
		8	* TestExpectations:
		9
1	2021-11-15 Cathie Chen <cathiechen@igalia.com>	10	2021-11-15 Cathie Chen <cathiechen@igalia.com>
2		11
3	[CSS contain] Update css-contain tests from WPT	12	[CSS contain] Update css-contain tests from WPT