Attachment #435999 for bug #229321

View Details Raw Unified Return to Bug 229321



2021-08-20  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory
        https://bugs.webkit.org/show_bug.cgi?id=229321

        Reviewed by NOBODY (OOPS!).

        Reverting r274166 because it caused JSC tests to use too much memory.

        Reverted changeset:
                "[GTK] Reenable -fvisibility=hidden"
                https://bugs.webkit.org/show_bug.cgi?id=181916
                https://commits.webkit.org/r274166

        Covered by existing tests.

        * PlatformGTK.cmake:
        * dom/EventTarget.cpp:
        * dom/EventTarget.h:

2021-08-20  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, reverting r281307.

Lines 8-13 include(platform/TextureMapper.cmake) a/Source/WebCore/PlatformGTK.cmake_sec1
- a/Source/WebCore/PlatformGTK.cmake +7 lines
8		8
9	set(WebCore_OUTPUT_NAME WebCoreGTK)	9	set(WebCore_OUTPUT_NAME WebCoreGTK)
10		10
		11	# FIXME: https://bugs.webkit.org/show_bug.cgi?id=181916
		12	# Remove these lines when turning on hidden visibility
		13	list(APPEND WebCore_PRIVATE_LIBRARIES WebKit::WTF)
		14	if (NOT USE_SYSTEM_MALLOC)
		15	list(APPEND WebCore_PRIVATE_LIBRARIES WebKit::bmalloc)
		16	endif ()
		17
11	list(APPEND WebCore_UNIFIED_SOURCE_LIST_FILES	18	list(APPEND WebCore_UNIFIED_SOURCE_LIST_FILES
12	"SourcesGTK.txt"	19	"SourcesGTK.txt"
13		20



    return EventTargetConcrete::create(context);
}

EventTarget::~EventTarget() = default;

bool EventTarget::isNode() const
{
    return false;

Lines 103-109 public: a/Source/WebCore/dom/EventTarget.h_sec1
- a/Source/WebCore/dom/EventTarget.h -1 / +1 lines
103	const EventTargetData* eventTargetData() const;	103	const EventTargetData* eventTargetData() const;
104		104
105	protected:	105	protected:
106	WEBCORE_EXPORT virtual ~EventTarget();	106	virtual ~EventTarget() = default;
107		107
108	virtual EventTargetData* eventTargetData() = 0;	108	virtual EventTargetData* eventTargetData() = 0;
109	virtual EventTargetData* eventTargetDataConcurrently() = 0;	109	virtual EventTargetData* eventTargetDataConcurrently() = 0;




SET_PROJECT_VERSION(2 33 3)

set(CMAKE_C_VISIBILITY_PRESET hidden)
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(bmalloc_LIBRARY_TYPE OBJECT)
set(WTF_LIBRARY_TYPE OBJECT)

set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")




2021-08-20  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory
        https://bugs.webkit.org/show_bug.cgi?id=229321

        Reviewed by NOBODY (OOPS!).

        Reverting r274166 because it caused JSC tests to use too much memory.

        Reverted changeset:
                "[GTK] Reenable -fvisibility=hidden"
                https://bugs.webkit.org/show_bug.cgi?id=181916
                https://commits.webkit.org/r274166

        * TestWebKitAPI/PlatformGTK.cmake:
        * TestWebKitAPI/glib/TestExpectations.json:

2021-08-20  Youenn Fablet  <youenn@apple.com>

        Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging

Lines 28-33 list(APPEND TestWTF_LIBRARIES a/Tools/TestWebKitAPI/PlatformGTK.cmake_sec1
- a/Tools/TestWebKitAPI/PlatformGTK.cmake +3 lines
28	GTK::GTK	28	GTK::GTK
29	)	29	)
30		30
		31	# FIXME: Remove when turning on hidden visibility https://bugs.webkit.org/show_bug.cgi?id=181916
		32	list(APPEND TestJavaScriptCore_LIBRARIES WTF)
		33
31	# TestWebCore	34	# TestWebCore
32	list(APPEND TestWebCore_SOURCES	35	list(APPEND TestWebCore_SOURCES
33	${test_main_SOURCES}	36	${test_main_SOURCES}



        "subtests": {
            "/jsc/vm": {
                "expected": {"all": {"slow": true}}
            },
            "/jsc/weak-value": {
                "expected": {"all": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/222972"}}
            }
        }
    },



2021-08-20  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory
        https://bugs.webkit.org/show_bug.cgi?id=229321

        Reviewed by NOBODY (OOPS!).

        Reverting r274166 because it caused JSC tests to use too much memory.

        Reverted changeset:
                "[GTK] Reenable -fvisibility=hidden"
                https://bugs.webkit.org/show_bug.cgi?id=181916
                https://commits.webkit.org/r274166

        * Source/cmake/OptionsGTK.cmake:

2021-08-16  David Kilzer  <ddkilzer@apple.com>

        "make analyze" should run clang static analyzer in deep mode

Return to Bug 229321

Lines 66-73 Ref<EventTarget> EventTarget::create(ScriptExecutionContext& context) a/Source/WebCore/dom/EventTarget.cpp_sec1
- a/Source/WebCore/dom/EventTarget.cpp -2 lines
66	return EventTargetConcrete::create(context);	66	return EventTargetConcrete::create(context);
67	}	67	}
68		68
69	EventTarget::~EventTarget() = default;
70
71	bool EventTarget::isNode() const	69	bool EventTarget::isNode() const
72	{	70	{
73	return false;	71	return false;

Lines 321-329 a/Tools/TestWebKitAPI/glib/TestExpectations.json_sec1
- a/Tools/TestWebKitAPI/glib/TestExpectations.json -3 lines
321	"subtests": {	321	"subtests": {
322	"/jsc/vm": {	322	"/jsc/vm": {
323	"expected": {"all": {"slow": true}}	323	"expected": {"all": {"slow": true}}
324	},
325	"/jsc/weak-value": {
326	"expected": {"all": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/222972"}}
327	}	324	}
328	}	325	}
329	},	326	},

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +20 lines
		1	2021-08-20 Carlos Alberto Lopez Perez <clopez@igalia.com>
		2
		3	REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory
		4	https://bugs.webkit.org/show_bug.cgi?id=229321
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Reverting r274166 because it caused JSC tests to use too much memory.
		9
		10	Reverted changeset:
		11	"[GTK] Reenable -fvisibility=hidden"
		12	https://bugs.webkit.org/show_bug.cgi?id=181916
		13	https://commits.webkit.org/r274166
		14
		15	Covered by existing tests.
		16
		17	* PlatformGTK.cmake:
		18	* dom/EventTarget.cpp:
		19	* dom/EventTarget.h:
		20
1	2021-08-20 Commit Queue <commit-queue@webkit.org>	21	2021-08-20 Commit Queue <commit-queue@webkit.org>
2		22
3	Unreviewed, reverting r281307.	23	Unreviewed, reverting r281307.

Lines 5-14 WEBKIT_OPTION_BEGIN() a/Source/cmake/OptionsGTK.cmake_sec1
- a/Source/cmake/OptionsGTK.cmake -4 lines
5		5
6	SET_PROJECT_VERSION(2 33 3)	6	SET_PROJECT_VERSION(2 33 3)
7		7
8	set(CMAKE_C_VISIBILITY_PRESET hidden)
9	set(CMAKE_CXX_VISIBILITY_PRESET hidden)
10	set(bmalloc_LIBRARY_TYPE OBJECT)
11	set(WTF_LIBRARY_TYPE OBJECT)
12		8
13	set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")	9	set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
14		10

Lines 1-3 a/Tools/ChangeLog_sec1
- a/Tools/ChangeLog +17 lines
		1	2021-08-20 Carlos Alberto Lopez Perez <clopez@igalia.com>
		2
		3	REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory
		4	https://bugs.webkit.org/show_bug.cgi?id=229321
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Reverting r274166 because it caused JSC tests to use too much memory.
		9
		10	Reverted changeset:
		11	"[GTK] Reenable -fvisibility=hidden"
		12	https://bugs.webkit.org/show_bug.cgi?id=181916
		13	https://commits.webkit.org/r274166
		14
		15	* TestWebKitAPI/PlatformGTK.cmake:
		16	* TestWebKitAPI/glib/TestExpectations.json:
		17
1	2021-08-20 Youenn Fablet <youenn@apple.com>	18	2021-08-20 Youenn Fablet <youenn@apple.com>
2		19
3	Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging	20	Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging

Lines 1-3 a/ChangeLog_sec1
- a/ChangeLog +16 lines
		1	2021-08-20 Carlos Alberto Lopez Perez <clopez@igalia.com>
		2
		3	REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory
		4	https://bugs.webkit.org/show_bug.cgi?id=229321
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Reverting r274166 because it caused JSC tests to use too much memory.
		9
		10	Reverted changeset:
		11	"[GTK] Reenable -fvisibility=hidden"
		12	https://bugs.webkit.org/show_bug.cgi?id=181916
		13	https://commits.webkit.org/r274166
		14
		15	* Source/cmake/OptionsGTK.cmake:
		16
1	2021-08-16 David Kilzer <ddkilzer@apple.com>	17	2021-08-16 David Kilzer <ddkilzer@apple.com>
2		18
3	"make analyze" should run clang static analyzer in deep mode	19	"make analyze" should run clang static analyzer in deep mode