Attachment #421414 for bug #222360

View Details Raw Unified Return to Bug 222360



2021-02-24  Imanol Fernandez  <ifernandez@igalia.com>

        Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
        https://bugs.webkit.org/show_bug.cgi?id=222360

        Reviewed by NOBODY (OOPS!).

        Fixes xrCompatibe false value in WebGLRenderingContextBase::getContextAttributes()
        after WebGLRenderingContextBase::makeXRCompatible call succeeds.

        Test: webGLCanvasContext_create_xrcompatible.https.html

        * html/canvas/WebGLRenderingContextBase.cpp:
        (WebCore::WebGLRenderingContextBase::getContextAttributes):

2021-02-24  Imanol Fernandez  <ifernandez@igalia.com>

        Refactor OpenXR platform code into different classes and files.

Lines 2922-2927 Optional<WebGLContextAttributes> WebGLRenderingContextBase::getContextAttributes a/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp_sec1
- a/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp +3 lines
2922	attributes.depth = false;	2922	attributes.depth = false;
2923	if (!m_attributes.stencil)	2923	if (!m_attributes.stencil)
2924	attributes.stencil = false;	2924	attributes.stencil = false;
		2925	#if ENABLE(WEBXR)
		2926	attributes.xrCompatible = m_isXRCompatible;
		2927	#endif
2925	return attributes;	2928	return attributes;
2926	}	2929	}
2927		2930



2021-02-24  Imanol Fernandez  <ifernandez@igalia.com>

        Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
        https://bugs.webkit.org/show_bug.cgi?id=222360

        Reviewed by NOBODY (OOPS!).

        Update WebXR xrCompatible attribute test expectations.

        * platform/wpe/TestExpectations:

2021-02-24  Imanol Fernandez  <ifernandez@igalia.com>

        Implement WebXR getViewport



2021-02-24  Imanol Fernandez  <ifernandez@igalia.com>

        Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
        https://bugs.webkit.org/show_bug.cgi?id=222360

        Reviewed by NOBODY (OOPS!).

        Update WebXR xrCompatible attribute test expectations.

        * web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt: Added.

2021-02-24  Imanol Fernandez  <ifernandez@igalia.com>

        Implement WebXR getViewport

Line 0 a/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt_sec1
- a/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt +4 lines
	1
	2	PASS Verify promise from a non-reentrant to makeXRCompatible() is resolved
	3	PASS Verify promises from reentrant calls to makeXRCompatible() are resolved
	4




# WebXR
webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Failure ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_inline.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive_unsupported.https.html [ Pass ]

Return to Bug 222360

Lines 628-634 webkit.org/b/213131 http/tests/misc/gamepads-insecure.html [ Skip ] a/LayoutTests/platform/wpe/TestExpectations_sec1
- a/LayoutTests/platform/wpe/TestExpectations +2 lines
628		628
629	# WebXR	629	# WebXR
630	webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Failure ]	630	webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Failure ]
		631	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https.html [ Pass ]
631	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https.html [ Pass ]	632	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https.html [ Pass ]
		633	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https.html [ Pass ]
632	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_inline.https.html [ Pass ]	634	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_inline.https.html [ Pass ]
633	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive.https.html [ Pass ]	635	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive.https.html [ Pass ]
634	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive_unsupported.https.html [ Pass ]	636	webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive_unsupported.https.html [ Pass ]

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +15 lines
		1	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>
		2
		3	Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
		4	https://bugs.webkit.org/show_bug.cgi?id=222360
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Fixes xrCompatibe false value in WebGLRenderingContextBase::getContextAttributes()
		9	after WebGLRenderingContextBase::makeXRCompatible call succeeds.
		10
		11	Test: webGLCanvasContext_create_xrcompatible.https.html
		12
		13	* html/canvas/WebGLRenderingContextBase.cpp:
		14	(WebCore::WebGLRenderingContextBase::getContextAttributes):
		15
1	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>	16	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>
2		17
3	Refactor OpenXR platform code into different classes and files.	18	Refactor OpenXR platform code into different classes and files.

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +11 lines
		1	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>
		2
		3	Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
		4	https://bugs.webkit.org/show_bug.cgi?id=222360
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Update WebXR xrCompatible attribute test expectations.
		9
		10	* platform/wpe/TestExpectations:
		11
1	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>	12	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>
2		13
3	Implement WebXR getViewport	14	Implement WebXR getViewport

Lines 1-3 a/LayoutTests/imported/w3c/ChangeLog_sec1
- a/LayoutTests/imported/w3c/ChangeLog +11 lines
		1	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>
		2
		3	Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
		4	https://bugs.webkit.org/show_bug.cgi?id=222360
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Update WebXR xrCompatible attribute test expectations.
		9
		10	* web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt: Added.
		11
1	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>	12	2021-02-24 Imanol Fernandez <ifernandez@igalia.com>
2		13
3	Implement WebXR getViewport	14	Implement WebXR getViewport