View Details Raw Unified Return to Bug 219268
| Differences between
and this patch
Collapse All Expand All
- a/Source/WebKit/ChangeLog +10 lines
Lines 1-3 a/Source/WebKit/ChangeLog_sec1
1 
2020-11-23  Lauro Moura  <lmoura@igalia.com>
2 

            

            

              3
              
        [GTK4] Declare lambda return type to avoid build error deducing it

            

            

              4
              
        https://bugs.webkit.org/show_bug.cgi?id=219268

            

            

              5
              

            

            

              6
              
        Reviewed by NOBODY (OOPS!).

            

            

              7
              

            

            

              8
              
        * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

            

            

              9
              
        (WebKit::WebPopupMenuProxyGtk::createPopupMenu):

            

            

              10
              

            

        

          1
          
2020-11-21  Sihui Liu  <sihui_liu@apple.com>

          11
          
2020-11-21  Sihui Liu  <sihui_liu@apple.com>

        

        

          2
          

          12
          

        

        

          3
          
        Implement audio capture for SpeechRecognition on macOS

          13
          
        Implement audio capture for SpeechRecognition on macOS

        



-
  a/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
    
      -1 / +1 lines
    




  

    
      
            Lines 255-261
      
      void WebPopupMenuProxyGtk::createPopupMenu(const Vector<WebPopupItem>& items, in
      
        a/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp_sec1
      
    
  

        

          255
          
    gtk_widget_set_parent(m_popup, m_webView);

          255
          
    gtk_widget_set_parent(m_popup, m_webView);

        

        

          256
          

          256
          

        

        

          257
          
    auto* controller = gtk_event_controller_key_new();

          257
          
    auto* controller = gtk_event_controller_key_new();

        

          
            

              258
              
    g_signal_connect_swapped(controller, "key-pressed", G_CALLBACK(+[](WebPopupMenuProxyGtk* popupMenu, unsigned keyval, unsigned, GdkModifierType, GtkEventController* controller) {


              258
              
    g_signal_connect_swapped(controller, "key-pressed", G_CALLBACK(+[](WebPopupMenuProxyGtk* popupMenu, unsigned keyval, unsigned, GdkModifierType, GtkEventController* controller) -> gboolean {

            

        

          259
          
        auto* event = gtk_event_controller_get_current_event(controller);

          259
          
        auto* event = gtk_event_controller_get_current_event(controller);

        

        

          260
          
        if (popupMenu->typeAheadFind(keyval, gdk_event_get_time(event)))

          260
          
        if (popupMenu->typeAheadFind(keyval, gdk_event_get_time(event)))

        

        

          261
          
            return GDK_EVENT_STOP;

          261
          
            return GDK_EVENT_STOP;

        






  

  Return to Bug 219268