Attachment #408821 for bug #216518

View Details Raw Unified Return to Bug 216518

| Differences between



2020-09-15  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling custom elements
        https://bugs.webkit.org/show_bug.cgi?id=216518

        Reviewed by NOBODY (OOPS!).

        Remove runtime setting for enabling/disabling custom elements. There is no
        reason one need to disable it now, and it has been on by default for
        a long enough time.

        * dom/CustomElementRegistry.idl:
        * dom/Document.cpp:
        (WebCore::createUpgradeCandidateElement):
        * page/DOMWindow.idl:
        * page/Settings.yaml:

2020-09-14  Chris Dumez  <cdumez@apple.com>

        Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float

Lines 24-30 Source/WebCore/dom/CustomElementRegistry.idl_sec1
- Source/WebCore/dom/CustomElementRegistry.idl -1 lines
24	*/	24	*/
25		25
26	[	26	[
27	EnabledBySetting=CustomElements,
28	GenerateIsReachable=ImplScriptExecutionContext,	27	GenerateIsReachable=ImplScriptExecutionContext,
29	JSGenerateToNativeObject,	28	JSGenerateToNativeObject,
30	] interface CustomElementRegistry {	29	] interface CustomElementRegistry {




static ALWAYS_INLINE Ref<HTMLElement> createUpgradeCandidateElement(Document& document, const QualifiedName& name)
{
    if (Document::validateCustomElementName(name.localName()) != CustomElementNameValidationStatus::Valid)
        || Document::validateCustomElementName(name.localName()) != CustomElementNameValidationStatus::Valid)
        return HTMLUnknownElement::create(name, document);

    auto element = HTMLElement::create(name, document);

Lines 57-63 typedef USVString CSSOMString; Source/WebCore/page/DOMWindow.idl_sec1
- Source/WebCore/page/DOMWindow.idl -1 / +1 lines
57	attribute DOMString name;	57	attribute DOMString name;
58	[DoNotCheckSecurity, PutForwards=href, LegacyUnforgeable] readonly attribute Location location;	58	[DoNotCheckSecurity, PutForwards=href, LegacyUnforgeable] readonly attribute Location location;
59	readonly attribute History history;	59	readonly attribute History history;
60	[EnabledBySetting=CustomElements, ImplementedAs=ensureCustomElementRegistry] readonly attribute CustomElementRegistry customElements;	60	[ImplementedAs=ensureCustomElementRegistry] readonly attribute CustomElementRegistry customElements;
61	[Replaceable] readonly attribute BarProp locationbar;	61	[Replaceable] readonly attribute BarProp locationbar;
62	[Replaceable] readonly attribute BarProp menubar;	62	[Replaceable] readonly attribute BarProp menubar;
63	[Replaceable] readonly attribute BarProp personalbar;	63	[Replaceable] readonly attribute BarProp personalbar;



referrerPolicyAttributeEnabled:
  initial: true

customElementsEnabled:
  initial: true

dataTransferItemsEnabled:
  initial: false




2020-09-15  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling custom elements
        https://bugs.webkit.org/show_bug.cgi?id=216518

        Reviewed by NOBODY (OOPS!).

        Remove runtime setting for enabling/disabling custom elements. There is no
        reason one need to disable it now, and it has been on by default for
        a long enough time.

        * Shared/WebPreferences.yaml:

2020-09-14  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling ShadowDOM



  type: bool
  defaultValue: true

CustomElementsEnabled:
  type: bool
  defaultValue: true

MenuItemElementEnabled:
  type: bool
  defaultValue: false



2020-09-15  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling custom elements
        https://bugs.webkit.org/show_bug.cgi?id=216518

        Reviewed by NOBODY (OOPS!).

        Remove runtime setting for enabling/disabling custom elements. There is no
        reason one need to disable it now, and it has been on by default for
        a long enough time.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences setCustomElementsEnabled:]):
        (-[WebPreferences customElementsEnabled]):
        * WebView/WebPreferencesPrivate.h:

2020-09-14  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling ShadowDOM

Lines 177-183 Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h_sec1
- Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h -1 / +1 lines
177	#define WebKitHighlightAPIEnabledPreferenceKey @"WebKitHighlightAPIEnabled"	177	#define WebKitHighlightAPIEnabledPreferenceKey @"WebKitHighlightAPIEnabled"
178	#define WebKitServiceControlsEnabledPreferenceKey @"WebKitServiceControlsEnabled"	178	#define WebKitServiceControlsEnabledPreferenceKey @"WebKitServiceControlsEnabled"
179	#define WebKitMediaKeysStorageDirectoryKey @"WebKitMediaKeysStorageDirectory"	179	#define WebKitMediaKeysStorageDirectoryKey @"WebKitMediaKeysStorageDirectory"
180	#define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled"
181	#define WebKitDataTransferItemsEnabledPreferenceKey @"WebKitDataTransferItemsEnabled"	180	#define WebKitDataTransferItemsEnabledPreferenceKey @"WebKitDataTransferItemsEnabled"
182	#define WebKitCustomPasteboardDataEnabledPreferenceKey @"WebKitCustomPasteboardDataEnabled"	181	#define WebKitCustomPasteboardDataEnabledPreferenceKey @"WebKitCustomPasteboardDataEnabled"
183	#define WebKitDialogElementEnabledPreferenceKey @"WebKitDialogElementEnabledPreferenceKey"	182	#define WebKitDialogElementEnabledPreferenceKey @"WebKitDialogElementEnabledPreferenceKey"
Lines 295-297 Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h_sec2
295	// be removed when it is considered safe to do so.	294	// be removed when it is considered safe to do so.
296	#define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled"	295	#define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled"
297	#define WebKitHixie76WebSocketProtocolEnabledKey @"WebKitHixie76WebSocketProtocolEnabled"	296	#define WebKitHixie76WebSocketProtocolEnabledKey @"WebKitHixie76WebSocketProtocolEnabled"
		297	#define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled"



        @YES, WebKitMockCaptureDevicesPromptEnabledPreferenceKey,
        @YES, WebKitMediaCaptureRequiresSecureConnectionPreferenceKey,
#endif
        @YES, WebKitCustomElementsEnabledPreferenceKey,
        @YES, WebKitDataTransferItemsEnabledPreferenceKey,
        @NO, WebKitCustomPasteboardDataEnabledPreferenceKey,
        @NO, WebKitDialogElementEnabledPreferenceKey,

    [self _setBoolValue:flag forKey:WebKitMediaCaptureRequiresSecureConnectionPreferenceKey];
}

- (BOOL)customElementsEnabled
{
    return [self _boolValueForKey:WebKitCustomElementsEnabledPreferenceKey];
}

- (void)setCustomElementsEnabled:(BOOL)flag
{
    [self _setBoolValue:flag forKey:WebKitCustomElementsEnabledPreferenceKey];
}

- (BOOL)dataTransferItemsEnabled
{
    return [self _boolValueForKey:WebKitDataTransferItemsEnabledPreferenceKey];

    return YES;
}

- (void)setCustomElementsEnabled:(BOOL)flag
{
}

- (BOOL)customElementsEnabled
{
    return YES;
}

- (void)setVideoPluginProxyEnabled:(BOOL)flag
{
}



- (void)setMediaCaptureRequiresSecureConnection:(BOOL)flag;
- (BOOL)mediaCaptureRequiresSecureConnection;

- (void)setCustomElementsEnabled:(BOOL)flag;
- (BOOL)customElementsEnabled;

- (void)setDataTransferItemsEnabled:(BOOL)flag;
- (BOOL)dataTransferItemsEnabled;


- (void)setShadowDOMEnabled:(BOOL)flag;
- (BOOL)shadowDOMEnabled;

- (void)setCustomElementsEnabled:(BOOL)flag;
- (BOOL)customElementsEnabled;

- (void)setVideoPluginProxyEnabled:(BOOL)flag;
- (BOOL)isVideoPluginProxyEnabled;


Lines 3325-3331 - (void)_preferencesChanged:(WebPreferen Source/WebKitLegacy/mac/WebView/WebView.mm_sec1
- Source/WebKitLegacy/mac/WebView/WebView.mm -1 lines
3325		3325
3326	RuntimeEnabledFeatures::sharedFeatures().setHighlightAPIEnabled([preferences highlightAPIEnabled]);	3326	RuntimeEnabledFeatures::sharedFeatures().setHighlightAPIEnabled([preferences highlightAPIEnabled]);
3327		3327
3328	settings.setCustomElementsEnabled([preferences customElementsEnabled]);
3329	settings.setDataTransferItemsEnabled([preferences dataTransferItemsEnabled]);	3328	settings.setDataTransferItemsEnabled([preferences dataTransferItemsEnabled]);
3330	RuntimeEnabledFeatures::sharedFeatures().setCustomPasteboardDataEnabled([preferences customPasteboardDataEnabled]);	3329	RuntimeEnabledFeatures::sharedFeatures().setCustomPasteboardDataEnabled([preferences customPasteboardDataEnabled]);
3331		3330



2020-09-15  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling custom elements
        https://bugs.webkit.org/show_bug.cgi?id=216518

        Reviewed by NOBODY (OOPS!).

        Remove runtime setting for enabling/disabling custom elements. There is no
        reason one need to disable it now, and it has been on by default for
        a long enough time.

        * WebPreferences.cpp:
        (WebPreferences::customElementsEnabled):
        (WebPreferences::setCustomElementsEnabled):
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

2020-09-14  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling ShadowDOM



{
    if (!enabled)
        return E_POINTER;
    *enabled = true;
    return S_OK;
}

HRESULT WebPreferences::setCustomElementsEnabled(BOOL)
{
    setBoolValue(WebKitCustomElementsEnabledPreferenceKey, enabled);
    return S_OK;
}




        return hr;
    RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(!!enabled);

    hr = prefsPrivate->customElementsEnabled(&enabled);
    if (FAILED(hr))
        return hr;
    settings.setCustomElementsEnabled(!!enabled);

    hr = prefsPrivate->menuItemElementEnabled(&enabled);
    if (FAILED(hr))
        return hr;



2020-09-15  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling custom elements
        https://bugs.webkit.org/show_bug.cgi?id=216518

        Reviewed by NOBODY (OOPS!).

        Remove runtime setting for enabling/disabling custom elements. There is no
        reason one need to disable it now, and it has been on by default for
        a long enough time.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebPreferencesToConsistentValues):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebPreferencesToConsistentValues):

2020-09-14  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling custom elements
        https://bugs.webkit.org/show_bug.cgi?id=216518

        Reviewed by NOBODY (OOPS!).

        Remove runtime setting for enabling/disabling custom elements. There is no
        reason one need to disable it now, and it has been on by default for
        a long enough time.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebPreferencesToConsistentValues):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebPreferencesToConsistentValues):

2020-09-14  Sam Weinig  <weinig@apple.com>

        Remove runtime setting for enabling/disabling ShadowDOM



    [preferences setMediaSourceEnabled:YES];
    [preferences setSourceBufferChangeTypeEnabled:YES];

    [preferences setCustomElementsEnabled:YES];

    [preferences setDataTransferItemsEnabled:YES];
    [preferences setCustomPasteboardDataEnabled:YES];
    [preferences setDialogElementEnabled:YES];

Lines 898-904 static void resetWebPreferencesToConsist Tools/DumpRenderTree/win/DumpRenderTree.cpp_sec1
- Tools/DumpRenderTree/win/DumpRenderTree.cpp -1 lines
898	preferences->setFontSmoothing(FontSmoothingTypeStandard);	898	preferences->setFontSmoothing(FontSmoothingTypeStandard);
899		899
900	prefsPrivate->setFetchAPIEnabled(TRUE);	900	prefsPrivate->setFetchAPIEnabled(TRUE);
901	prefsPrivate->setCustomElementsEnabled(TRUE);
902	prefsPrivate->setResourceTimingEnabled(TRUE);	901	prefsPrivate->setResourceTimingEnabled(TRUE);
903	prefsPrivate->setUserTimingEnabled(TRUE);	902	prefsPrivate->setUserTimingEnabled(TRUE);
904	prefsPrivate->setDataTransferItemsEnabled(TRUE);	903	prefsPrivate->setDataTransferItemsEnabled(TRUE);

Return to Bug 216518

Lines 950-957 void Document::childrenChanged(const Chi Source/WebCore/dom/Document.cpp_sec1
- Source/WebCore/dom/Document.cpp -2 / +1 lines
950		950
951	static ALWAYS_INLINE Ref<HTMLElement> createUpgradeCandidateElement(Document& document, const QualifiedName& name)	951	static ALWAYS_INLINE Ref<HTMLElement> createUpgradeCandidateElement(Document& document, const QualifiedName& name)
952	{	952	{
953	if (!document.settings().customElementsEnabled()	953	if (Document::validateCustomElementName(name.localName()) != CustomElementNameValidationStatus::Valid)
954	\|\| Document::validateCustomElementName(name.localName()) != CustomElementNameValidationStatus::Valid)
955	return HTMLUnknownElement::create(name, document);	954	return HTMLUnknownElement::create(name, document);
956		955
957	auto element = HTMLElement::create(name, document);	956	auto element = HTMLElement::create(name, document);

Lines 1002-1010 lazyImageLoadingEnabled: Source/WebCore/page/Settings.yaml_sec1
- Source/WebCore/page/Settings.yaml -3 lines
1002	referrerPolicyAttributeEnabled:	1002	referrerPolicyAttributeEnabled:
1003	initial: true	1003	initial: true
1004		1004
1005	customElementsEnabled:
1006	initial: true
1007
1008	dataTransferItemsEnabled:	1005	dataTransferItemsEnabled:
1009	initial: false	1006	initial: false
1010		1007

Lines 814-823 AnimatedImageAsyncDecodingEnabled: Source/WebKit/Shared/WebPreferences.yaml_sec1
- Source/WebKit/Shared/WebPreferences.yaml -4 lines
814	type: bool	814	type: bool
815	defaultValue: true	815	defaultValue: true
816		816
817	CustomElementsEnabled:
818	type: bool
819	defaultValue: true
820
821	MenuItemElementEnabled:	817	MenuItemElementEnabled:
822	type: bool	818	type: bool
823	defaultValue: false	819	defaultValue: false

Lines 631-637 + (void)initialize Source/WebKitLegacy/mac/WebView/WebPreferences.mm_sec1
- Source/WebKitLegacy/mac/WebView/WebPreferences.mm -11 / +9 lines
631	@YES, WebKitMockCaptureDevicesPromptEnabledPreferenceKey,	631	@YES, WebKitMockCaptureDevicesPromptEnabledPreferenceKey,
632	@YES, WebKitMediaCaptureRequiresSecureConnectionPreferenceKey,	632	@YES, WebKitMediaCaptureRequiresSecureConnectionPreferenceKey,
633	#endif	633	#endif
634	@YES, WebKitCustomElementsEnabledPreferenceKey,
635	@YES, WebKitDataTransferItemsEnabledPreferenceKey,	634	@YES, WebKitDataTransferItemsEnabledPreferenceKey,
636	@NO, WebKitCustomPasteboardDataEnabledPreferenceKey,	635	@NO, WebKitCustomPasteboardDataEnabledPreferenceKey,
637	@NO, WebKitDialogElementEnabledPreferenceKey,	636	@NO, WebKitDialogElementEnabledPreferenceKey,
Lines 3048-3063 - (void)setMediaCaptureRequiresSecureCon Source/WebKitLegacy/mac/WebView/WebPreferences.mm_sec2
3048	[self _setBoolValue:flag forKey:WebKitMediaCaptureRequiresSecureConnectionPreferenceKey];	3047	[self _setBoolValue:flag forKey:WebKitMediaCaptureRequiresSecureConnectionPreferenceKey];
3049	}	3048	}
3050		3049
3051	- (BOOL)customElementsEnabled
3052	{
3053	return [self _boolValueForKey:WebKitCustomElementsEnabledPreferenceKey];
3054	}
3055
3056	- (void)setCustomElementsEnabled:(BOOL)flag
3057	{
3058	[self _setBoolValue:flag forKey:WebKitCustomElementsEnabledPreferenceKey];
3059	}
3060
3061	- (BOOL)dataTransferItemsEnabled	3050	- (BOOL)dataTransferItemsEnabled
3062	{	3051	{
3063	return [self _boolValueForKey:WebKitDataTransferItemsEnabledPreferenceKey];	3052	return [self _boolValueForKey:WebKitDataTransferItemsEnabledPreferenceKey];
Lines 3723-3728 - (BOOL)shadowDOMEnabled Source/WebKitLegacy/mac/WebView/WebPreferences.mm_sec3
3723	return YES;	3712	return YES;
3724	}	3713	}
3725		3714
		3715	- (void)setCustomElementsEnabled:(BOOL)flag
		3716	{
		3717	}
		3718
		3719	- (BOOL)customElementsEnabled
		3720	{
		3721	return YES;
		3722	}
		3723
3726	- (void)setVideoPluginProxyEnabled:(BOOL)flag	3724	- (void)setVideoPluginProxyEnabled:(BOOL)flag
3727	{	3725	{
3728	}	3726	}

Lines 537-545 @interface WebPreferences (WebPrivate) Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h_sec1
- Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h -3 / +3 lines
537	- (void)setMediaCaptureRequiresSecureConnection:(BOOL)flag;	537	- (void)setMediaCaptureRequiresSecureConnection:(BOOL)flag;
538	- (BOOL)mediaCaptureRequiresSecureConnection;	538	- (BOOL)mediaCaptureRequiresSecureConnection;
539		539
540	- (void)setCustomElementsEnabled:(BOOL)flag;
541	- (BOOL)customElementsEnabled;
542
543	- (void)setDataTransferItemsEnabled:(BOOL)flag;	540	- (void)setDataTransferItemsEnabled:(BOOL)flag;
544	- (BOOL)dataTransferItemsEnabled;	541	- (BOOL)dataTransferItemsEnabled;
545		542
Lines 705-710 @interface WebPreferences (WebPrivateDep Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h_sec2
705	- (void)setShadowDOMEnabled:(BOOL)flag;	702	- (void)setShadowDOMEnabled:(BOOL)flag;
706	- (BOOL)shadowDOMEnabled;	703	- (BOOL)shadowDOMEnabled;
707		704
		705	- (void)setCustomElementsEnabled:(BOOL)flag;
		706	- (BOOL)customElementsEnabled;
		707
708	- (void)setVideoPluginProxyEnabled:(BOOL)flag;	708	- (void)setVideoPluginProxyEnabled:(BOOL)flag;
709	- (BOOL)isVideoPluginProxyEnabled;	709	- (BOOL)isVideoPluginProxyEnabled;
710		710

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +17 lines
		1	2020-09-15 Sam Weinig <weinig@apple.com>
		2
		3	Remove runtime setting for enabling/disabling custom elements
		4	https://bugs.webkit.org/show_bug.cgi?id=216518
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Remove runtime setting for enabling/disabling custom elements. There is no
		9	reason one need to disable it now, and it has been on by default for
		10	a long enough time.
		11
		12	* dom/CustomElementRegistry.idl:
		13	* dom/Document.cpp:
		14	(WebCore::createUpgradeCandidateElement):
		15	* page/DOMWindow.idl:
		16	* page/Settings.yaml:
		17
1	2020-09-14 Chris Dumez <cdumez@apple.com>	18	2020-09-14 Chris Dumez <cdumez@apple.com>
2		19
3	Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float	20	Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float

Lines 1-3 Source/WebKit/ChangeLog_sec1
- Source/WebKit/ChangeLog +13 lines
		1	2020-09-15 Sam Weinig <weinig@apple.com>
		2
		3	Remove runtime setting for enabling/disabling custom elements
		4	https://bugs.webkit.org/show_bug.cgi?id=216518
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Remove runtime setting for enabling/disabling custom elements. There is no
		9	reason one need to disable it now, and it has been on by default for
		10	a long enough time.
		11
		12	* Shared/WebPreferences.yaml:
		13
1	2020-09-14 Sam Weinig <weinig@apple.com>	14	2020-09-14 Sam Weinig <weinig@apple.com>
2		15
3	Remove runtime setting for enabling/disabling ShadowDOM	16	Remove runtime setting for enabling/disabling ShadowDOM

Lines 1-3 Source/WebKitLegacy/mac/ChangeLog_sec1
- Source/WebKitLegacy/mac/ChangeLog +18 lines
		1	2020-09-15 Sam Weinig <weinig@apple.com>
		2
		3	Remove runtime setting for enabling/disabling custom elements
		4	https://bugs.webkit.org/show_bug.cgi?id=216518
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Remove runtime setting for enabling/disabling custom elements. There is no
		9	reason one need to disable it now, and it has been on by default for
		10	a long enough time.
		11
		12	* WebView/WebPreferenceKeysPrivate.h:
		13	* WebView/WebPreferences.mm:
		14	(+[WebPreferences initialize]):
		15	(-[WebPreferences setCustomElementsEnabled:]):
		16	(-[WebPreferences customElementsEnabled]):
		17	* WebView/WebPreferencesPrivate.h:
		18
1	2020-09-14 Sam Weinig <weinig@apple.com>	19	2020-09-14 Sam Weinig <weinig@apple.com>
2		20
3	Remove runtime setting for enabling/disabling ShadowDOM	21	Remove runtime setting for enabling/disabling ShadowDOM

Lines 1-3 Source/WebKitLegacy/win/ChangeLog_sec1
- Source/WebKitLegacy/win/ChangeLog +17 lines
		1	2020-09-15 Sam Weinig <weinig@apple.com>
		2
		3	Remove runtime setting for enabling/disabling custom elements
		4	https://bugs.webkit.org/show_bug.cgi?id=216518
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Remove runtime setting for enabling/disabling custom elements. There is no
		9	reason one need to disable it now, and it has been on by default for
		10	a long enough time.
		11
		12	* WebPreferences.cpp:
		13	(WebPreferences::customElementsEnabled):
		14	(WebPreferences::setCustomElementsEnabled):
		15	* WebView.cpp:
		16	(WebView::notifyPreferencesChanged):
		17
1	2020-09-14 Sam Weinig <weinig@apple.com>	18	2020-09-14 Sam Weinig <weinig@apple.com>
2		19
3	Remove runtime setting for enabling/disabling ShadowDOM	20	Remove runtime setting for enabling/disabling ShadowDOM

Lines 2077-2089 HRESULT WebPreferences::customElementsEn Source/WebKitLegacy/win/WebPreferences.cpp_sec1
- Source/WebKitLegacy/win/WebPreferences.cpp -3 / +2 lines
2077	{	2077	{
2078	if (!enabled)	2078	if (!enabled)
2079	return E_POINTER;	2079	return E_POINTER;
2080	*enabled = boolValueForKey(WebKitCustomElementsEnabledPreferenceKey);	2080	*enabled = true;
2081	return S_OK;	2081	return S_OK;
2082	}	2082	}
2083		2083
2084	HRESULT WebPreferences::setCustomElementsEnabled(BOOL enabled)	2084	HRESULT WebPreferences::setCustomElementsEnabled(BOOL)
2085	{	2085	{
2086	setBoolValue(WebKitCustomElementsEnabledPreferenceKey, enabled);
2087	return S_OK;	2086	return S_OK;
2088	}	2087	}
2089		2088

Lines 5234-5244 HRESULT WebView::notifyPreferencesChange Source/WebKitLegacy/win/WebView.cpp_sec1
- Source/WebKitLegacy/win/WebView.cpp -5 lines
5234	return hr;	5234	return hr;
5235	RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(!!enabled);	5235	RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(!!enabled);
5236		5236
5237	hr = prefsPrivate->customElementsEnabled(&enabled);
5238	if (FAILED(hr))
5239	return hr;
5240	settings.setCustomElementsEnabled(!!enabled);
5241
5242	hr = prefsPrivate->menuItemElementEnabled(&enabled);	5237	hr = prefsPrivate->menuItemElementEnabled(&enabled);
5243	if (FAILED(hr))	5238	if (FAILED(hr))
5244	return hr;	5239	return hr;

Lines 1-3 Tools/ChangeLog_sec1
- Tools/ChangeLog +32 lines
		1	2020-09-15 Sam Weinig <weinig@apple.com>
		2
		3	Remove runtime setting for enabling/disabling custom elements
		4	https://bugs.webkit.org/show_bug.cgi?id=216518
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Remove runtime setting for enabling/disabling custom elements. There is no
		9	reason one need to disable it now, and it has been on by default for
		10	a long enough time.
		11
		12	* DumpRenderTree/mac/DumpRenderTree.mm:
		13	(resetWebPreferencesToConsistentValues):
		14	* DumpRenderTree/win/DumpRenderTree.cpp:
		15	(resetWebPreferencesToConsistentValues):
		16
		17	2020-09-14 Sam Weinig <weinig@apple.com>
		18
		19	Remove runtime setting for enabling/disabling custom elements
		20	https://bugs.webkit.org/show_bug.cgi?id=216518
		21
		22	Reviewed by NOBODY (OOPS!).
		23
		24	Remove runtime setting for enabling/disabling custom elements. There is no
		25	reason one need to disable it now, and it has been on by default for
		26	a long enough time.
		27
		28	* DumpRenderTree/mac/DumpRenderTree.mm:
		29	(resetWebPreferencesToConsistentValues):
		30	* DumpRenderTree/win/DumpRenderTree.cpp:
		31	(resetWebPreferencesToConsistentValues):
		32
1	2020-09-14 Sam Weinig <weinig@apple.com>	33	2020-09-14 Sam Weinig <weinig@apple.com>
2		34
3	Remove runtime setting for enabling/disabling ShadowDOM	35	Remove runtime setting for enabling/disabling ShadowDOM

Lines 935-942 static void resetWebPreferencesToConsist Tools/DumpRenderTree/mac/DumpRenderTree.mm_sec1
- Tools/DumpRenderTree/mac/DumpRenderTree.mm -2 lines
935	[preferences setMediaSourceEnabled:YES];	935	[preferences setMediaSourceEnabled:YES];
936	[preferences setSourceBufferChangeTypeEnabled:YES];	936	[preferences setSourceBufferChangeTypeEnabled:YES];
937		937
938	[preferences setCustomElementsEnabled:YES];
939
940	[preferences setDataTransferItemsEnabled:YES];	938	[preferences setDataTransferItemsEnabled:YES];
941	[preferences setCustomPasteboardDataEnabled:YES];	939	[preferences setCustomPasteboardDataEnabled:YES];
942	[preferences setDialogElementEnabled:YES];	940	[preferences setDialogElementEnabled:YES];