Attachment #381786 for bug #184566

View Details Raw Unified Return to Bug 184566



2019-10-24  Antoine Quint  <graouts@apple.com>

        [Web Animations] Fix compositing/backing/transform-transition-from-outside-view.html
        https://bugs.webkit.org/show_bug.cgi?id=184566

        Reviewed by NOBODY (OOPS!).

        For the most part this is the same fix that Simon Fraser made to address 184611 in r251412 although here I also
        changed the setTimeout call to requestAnimationFrame in order to ensure that the backing store bit was set in the
        layer dump for WK1.

        * TestExpectations:
        * compositing/backing/transform-transition-from-outside-view.html:

2019-10-22  Simon Fraser  <simon.fraser@apple.com>

        wpt/css/css-images/gradient/color-stops-parsing.html fails

Lines 3653-3659 webkit.org/b/190032 animations/animation-playstate-paused-style-resolution.html a/LayoutTests/TestExpectations_sec1
- a/LayoutTests/TestExpectations -1 lines
3653	webkit.org/b/190032 animations/missing-values-first-keyframe.html [ Failure ]	3653	webkit.org/b/190032 animations/missing-values-first-keyframe.html [ Failure ]
3654	webkit.org/b/190032 animations/missing-values-last-keyframe.html [ Failure ]	3654	webkit.org/b/190032 animations/missing-values-last-keyframe.html [ Failure ]
3655	webkit.org/b/190032 compositing/backing/backing-store-attachment-fill-forwards-animation.html [ Failure ]	3655	webkit.org/b/190032 compositing/backing/backing-store-attachment-fill-forwards-animation.html [ Failure ]
3656	webkit.org/b/190032 compositing/backing/transform-transition-from-outside-view.html [ Failure ]
3657	webkit.org/b/190032 compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html [ Failure ]	3656	webkit.org/b/190032 compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html [ Failure ]
3658	webkit.org/b/190032 compositing/layer-creation/mismatched-transform-transition-overlap.html [ Failure ]	3657	webkit.org/b/190032 compositing/layer-creation/mismatched-transform-transition-overlap.html [ Failure ]
3659	webkit.org/b/190032 compositing/layer-creation/scale-rotation-transition-overlap.html [ Failure ]	3658	webkit.org/b/190032 compositing/layer-creation/scale-rotation-transition-overlap.html [ Failure ]



            testRunner.waitUntilDone();
        }

        function filterString(inputString, skippedLinesRegexp)
        {
            var lines = inputString.split("\n");
            var filtered = lines.filter(function (str) { return !skippedLinesRegexp.test(str); });
            return filtered.join("\n");
        }

        function dumpLayers()
        {
            if (window.testRunner) {
                output.innerText = filterString(window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_BACKING_STORE_ATTACHED), /transform/);
                testRunner.notifyDone();
            }
        }

        window.addEventListener("load", function() {
            document.body.classList.add('changed');
            requestAnimationFrame(dumpLayers);
        });
    </script>
</head>

Return to Bug 184566

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +14 lines
		1	2019-10-24 Antoine Quint <graouts@apple.com>
		2
		3	[Web Animations] Fix compositing/backing/transform-transition-from-outside-view.html
		4	https://bugs.webkit.org/show_bug.cgi?id=184566
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	For the most part this is the same fix that Simon Fraser made to address 184611 in r251412 although here I also
		9	changed the setTimeout call to requestAnimationFrame in order to ensure that the backing store bit was set in the
		10	layer dump for WK1.
		11
		12	* TestExpectations:
		13	* compositing/backing/transform-transition-from-outside-view.html:
		14
1	2019-10-22 Simon Fraser <simon.fraser@apple.com>	15	2019-10-22 Simon Fraser <simon.fraser@apple.com>
2		16
3	wpt/css/css-images/gradient/color-stops-parsing.html fails	17	wpt/css/css-images/gradient/color-stops-parsing.html fails

Lines 33-49 a/LayoutTests/compositing/backing/transform-transition-from-outside-view.html_sec1
- a/LayoutTests/compositing/backing/transform-transition-from-outside-view.html -2 / +9 lines
33	testRunner.waitUntilDone();	33	testRunner.waitUntilDone();
34	}	34	}
35		35
		36	function filterString(inputString, skippedLinesRegexp)
		37	{
		38	var lines = inputString.split("\n");
		39	var filtered = lines.filter(function (str) { return !skippedLinesRegexp.test(str); });
		40	return filtered.join("\n");
		41	}
		42
36	function dumpLayers()	43	function dumpLayers()
37	{	44	{
38	if (window.testRunner) {	45	if (window.testRunner) {
39	output.innerText = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_BACKING_STORE_ATTACHED);	46	output.innerText = filterString(window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_BACKING_STORE_ATTACHED), /transform/);
40	testRunner.notifyDone();	47	testRunner.notifyDone();
41	}	48	}
42	}	49	}
43		50
44	window.addEventListener("load", function() {	51	window.addEventListener("load", function() {
45	document.body.classList.add('changed');	52	document.body.classList.add('changed');
46	window.setTimeout(dumpLayers, 0);	53	requestAnimationFrame(dumpLayers);
47	});	54	});
48	</script>	55	</script>
49	</head>	56	</head>