View Details Raw Unified Return to Bug 200820
Collapse All Expand All
- a/Source/cmake/OptionsWin.cmake -2 / +7 lines
Lines 162-169 set(WTF_LIBRARY_TYPE SHARED) a/Source/cmake/OptionsWin.cmake_sec1
162 
set(PAL_LIBRARY_TYPE STATIC)
 162 
set(PAL_LIBRARY_TYPE STATIC)
163 
set(WebKitLegacy_LIBRARY_TYPE SHARED)
 163 
set(WebKitLegacy_LIBRARY_TYPE SHARED)
164 

          164
          

        

          
            

              165
              
if (NOT ENABLE_UNIFIED_BUILDS AND WebCore_LIBRARY_TYPE MATCHES STATIC)


              165
              
if (NOT ENABLE_UNIFIED_BUILDS)

            

            

              166
              
    set(WebCore_LIBRARY_TYPE OBJECT)


              166
              
    if (WebCore_LIBRARY_TYPE MATCHES STATIC)

            

            

              
              

              167
              
        set(WebCore_LIBRARY_TYPE OBJECT)

            

            


              168
              
    endif ()

            

            


              169
              
    if (WebCoreTestSupport_LIBRARY_TYPE MATCHES STATIC)

            

            


              170
              
        set(WebCoreTestSupport_LIBRARY_TYPE OBJECT)

            

            


              171
              
    endif ()

            

        

          167
          
endif ()

          172
          
endif ()

        

        

          168
          

          173
          

        

        

          169
          
# If <winsock2.h> is not included before <windows.h> redefinition errors occur

          174
          
# If <winsock2.h> is not included before <windows.h> redefinition errors occur

        



-
  a/ChangeLog
    
      +11 lines
    




  

    
      
            Lines 1-3
      
      
      
        a/ChangeLog_sec1
      
    
  

            

              
              
              1
              
2019-08-16  Ross Kirsling  <ross.kirsling@sony.com>

            

            

              2
              

            

            

              3
              
        [Win] WebCoreTestSupport is too big to link

            

            

              4
              
        https://bugs.webkit.org/show_bug.cgi?id=200820

            

            

              5
              

            

            

              6
              
        Reviewed by NOBODY (OOPS!).

            

            

              7
              

            

            

              8
              
        * Source/cmake/OptionsWin.cmake:

            

            

              9
              
        As with WebCore itself, build WebCoreTestSupport as an object library when unified builds are disabled

            

            

              10
              
        (and we haven't explicitly asked to build it as a shared library).

            

            

              11
              

            

        

          1
          
2019-08-08  Brent Fulgham  <bfulgham@apple.com>

          12
          
2019-08-08  Brent Fulgham  <bfulgham@apple.com>

        

        

          2
          

          13
          

        

        

          3
          
        [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing

          14
          
        [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing

        






  

  Return to Bug 200820