Attachment #358533 for bug #193214

View Details Raw Unified Return to Bug 193214



2019-01-07  Dean Jackson  <dino@apple.com>

        Turn on Pointer Events by default for iOS
        https://bugs.webkit.org/show_bug.cgi?id=193214
        <rdar://problem/46974878>

        Reviewed by NOBODY (OOPS!).

        Turn on Pointer Events.

        * Shared/WebPreferences.yaml:
        * Shared/WebPreferencesDefaultValues.h: Make a new #define for iOS.

2019-01-07  Antti Koivisto  <antti@apple.com>

        UI process side scrollbars for UI side compositing on Mac

Lines 1240-1246 VisualViewportAPIEnabled: a/Source/WebKit/Shared/WebPreferences.yaml_sec1
- a/Source/WebKit/Shared/WebPreferences.yaml -1 / +1 lines
1240		1240
1241	PointerEventsEnabled:	1241	PointerEventsEnabled:
1242	type: bool	1242	type: bool
1243	defaultValue: false	1243	defaultValue: DEFAULT_POINTER_EVENTS_ENABLED
1244	humanReadableName: "Pointer Events"	1244	humanReadableName: "Pointer Events"
1245	humanReadableDescription: "Enable Pointer Events"	1245	humanReadableDescription: "Enable Pointer Events"
1246	webcoreBinding: RuntimeEnabledFeatures	1246	webcoreBinding: RuntimeEnabledFeatures

Lines 208-213 a/Source/WebKit/Shared/WebPreferencesDefaultValues.h_sec1
- a/Source/WebKit/Shared/WebPreferencesDefaultValues.h +6 lines
208	#define DEFAULT_SERVICE_WORKERS_ENABLED false	208	#define DEFAULT_SERVICE_WORKERS_ENABLED false
209	#endif	209	#endif
210		210
		211	#if PLATFORM(IOS_FAMILY)
		212	#define DEFAULT_POINTER_EVENTS_ENABLED true
		213	#else
		214	#define DEFAULT_POINTER_EVENTS_ENABLED false
		215	#endif
		216
211	#if PLATFORM(MAC) \|\| PLATFORM(IOS)	217	#if PLATFORM(MAC) \|\| PLATFORM(IOS)
212	#define DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED true	218	#define DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED true
213	#else	219	#else



2019-01-07  Dean Jackson  <dino@apple.com>

        Turn on Pointer Events by default for iOS
        https://bugs.webkit.org/show_bug.cgi?id=193214
        <rdar://problem/46974878>

        Reviewed by NOBODY (OOPS!).

        Skip the pointer events tests everywhere but iOS.

        * TestExpectations:
        * platform/ios-wk1/TestExpectations:
        * platform/ios-wk2/TestExpectations:
        * platform/mac-wk1/TestExpectations:

2019-01-07  Wenson Hsieh  <wenson_hsieh@apple.com>

        Native caret shows up alongside the page's caret when requesting desktop site on jsfiddle.net



2019-01-07  Dean Jackson  <dino@apple.com>

        Turn on Pointer Events by default for iOS
        https://bugs.webkit.org/show_bug.cgi?id=193214
        <rdar://problem/46974878>

        Reviewed by NOBODY (OOPS!).

        Update expected results.

        * web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt:
        * web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt:
        * web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt:

2019-01-05  Youenn Fablet  <youenn@apple.com>

        Service Worker fetch should obey its referrer policy

Lines 434-439 fast/web-share [ Skip ] a/LayoutTests/TestExpectations_sec1
- a/LayoutTests/TestExpectations +4 lines
434	# This test was created to test a mac-wk2 bugfix	434	# This test was created to test a mac-wk2 bugfix
435	fast/animation/request-animation-frame-in-two-pages.html [ Skip ]	435	fast/animation/request-animation-frame-in-two-pages.html [ Skip ]
436		436
		437	# Only supported on iOS
		438	imported/w3c/web-platform-tests/pointerevents [ Skip ]
		439	pointerevents [ Skip ]
		440
437	#//////////////////////////////////////////////////////////////////////////////////////////	441	#//////////////////////////////////////////////////////////////////////////////////////////
438	# End platform-specific tests.	442	# End platform-specific tests.
439	#//////////////////////////////////////////////////////////////////////////////////////////	443	#//////////////////////////////////////////////////////////////////////////////////////////



The following pointer types were detected: .


PASS default 
FAIL stylesheet-none assert_equals: expected "auto" but got "none"
PASS explicit-auto 
FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x"
FAIL explicit-pan-left assert_equals: expected "auto" but got "pan-left"
FAIL explicit-pan-right assert_equals: expected "auto" but got "pan-right"
FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y"
FAIL explicit-pan-up assert_equals: expected "auto" but got "pan-up"
FAIL explicit-pan-down assert_equals: expected "auto" but got "pan-down"
FAIL explicit-pinch-zoom assert_equals: expected "auto" but got "pinch-zoom"
FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y"
FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y"
FAIL explicit-pan-left-pan-up assert_equals: expected "auto" but got "pan-left pan-up"
FAIL explicit-pan-left-pan-down assert_equals: expected "auto" but got "pan-left pan-down"
FAIL explicit-pan-right-pan-up assert_equals: expected "auto" but got "pan-right pan-up"
FAIL explicit-pan-right-pan-down assert_equals: expected "auto" but got "pan-right pan-down"
FAIL explicit-pan-up-pan-left assert_equals: expected "auto" but got "pan-left pan-up"
FAIL explicit-pan-up-pan-right assert_equals: expected "auto" but got "pan-right pan-up"
FAIL explicit-pan-down-pan-left assert_equals: expected "auto" but got "pan-left pan-down"
FAIL explicit-pan-down-pan-right assert_equals: expected "auto" but got "pan-right pan-down"
FAIL explicit-pinch-zoom-pan-x-pan-up assert_equals: expected "auto" but got "pan-x pan-up pinch-zoom"
FAIL explicit-pinch-zoom-pan-x-pan-y assert_equals: expected "auto" but got "manipulation"
PASS explicit-manipulation 
FAIL explicit-none assert_equals: expected "auto" but got "none"
PASS explicit-invalid-1 
FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none"
PASS explicit-invalid-3 
PASS explicit-invalid-4 
PASS explicit-invalid-5 
PASS explicit-invalid-6 
PASS explicit-invalid-7 
PASS explicit-invalid-8 
PASS explicit-invalid-9 
PASS explicit-invalid-10 
PASS explicit-invalid-11 
PASS explicit-invalid-12 
PASS explicit-invalid-13 
PASS explicit-invalid-14 
PASS not-inherited 
FAIL inherit assert_equals: expected "auto" but got "none"
PASS initial 


Lines 7-13 touch-action: none a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt_sec1
- a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt -3 / +3 lines
7	The following pointer types were detected: (none).	7	The following pointer types were detected: (none).
8		8
9		9
10	FAIL 'pan-x none' is corrected properly assert_true: 'pan-x none' is corrected properly expected true got false	10	PASS 'pan-x none' is corrected properly
11	FAIL 'pan-y none' is corrected properly assert_true: 'pan-y none' is corrected properly expected true got false	11	PASS 'pan-y none' is corrected properly
12	FAIL 'auto none' is corrected properly assert_true: 'auto none' is corrected properly expected true got false	12	PASS 'auto none' is corrected properly
13		13



touch-action: basic verification


PASS default 
FAIL stylesheet-none assert_equals: expected "auto" but got "none"
PASS explicit-auto 
FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x"
FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y"
FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y"
FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y"
PASS explicit-manipulation 
FAIL explicit-none assert_equals: expected "auto" but got "none"
PASS explicit-invalid-1 
FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none"
PASS explicit-invalid-3 
PASS explicit-invalid-4 
PASS explicit-invalid-5 
PASS explicit-invalid-6 
PASS explicit-invalid-7 
PASS explicit-invalid-8 
PASS explicit-invalid-9 
PASS explicit-invalid-10 
PASS explicit-invalid-11 
PASS explicit-invalid-12 
PASS explicit-invalid-13 
PASS not-inherited 
FAIL inherit assert_equals: expected "auto" but got "none"
PASS initial 




# Not supported on WK1
media/no-fullscreen-when-hidden.html [ Skip ]

# Skip pointerevents on WK1
pointerevents [ Skip ]
imported/w3c/web-platform-tests/pointerevents [ Skip ]

# Datalist is unsupported in WK1
fast/forms/datalist [ WontFix ]
imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]

Lines 55-60 applicationmanifest/ [ Pass ] a/LayoutTests/platform/ios-wk2/TestExpectations_sec1
- a/LayoutTests/platform/ios-wk2/TestExpectations +3 lines
55		55
56	webkit.org/b/187773 http/tests/webAPIStatistics [ Pass ]	56	webkit.org/b/187773 http/tests/webAPIStatistics [ Pass ]
57		57
		58	imported/w3c/web-platform-tests/pointerevents [ Pass ]
		59	pointerevents [ Pass ]
		60
58	#//////////////////////////////////////////////////////////////////////////////////////////	61	#//////////////////////////////////////////////////////////////////////////////////////////
59	# End platform-specific directories.	62	# End platform-specific directories.
60	#//////////////////////////////////////////////////////////////////////////////////////////	63	#//////////////////////////////////////////////////////////////////////////////////////////



webrtc/datachannel/mdns-ice-candidates.html [ Skip ]
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]

# Skip pointerevents on WK1
pointerevents [ Skip ]
imported/w3c/web-platform-tests/pointerevents [ Skip ]

# Datalist is unsupported in WK1
fast/forms/datalist [ WontFix ]
imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]

Return to Bug 193214

Lines 166-175 webrtc/datachannel [ Pass ] a/LayoutTests/platform/mac-wk1/TestExpectations_sec1
- a/LayoutTests/platform/mac-wk1/TestExpectations -4 lines
166	webrtc/datachannel/mdns-ice-candidates.html [ Skip ]	166	webrtc/datachannel/mdns-ice-candidates.html [ Skip ]
167	imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]	167	imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]
168		168
169	# Skip pointerevents on WK1
170	pointerevents [ Skip ]
171	imported/w3c/web-platform-tests/pointerevents [ Skip ]
172
173	# Datalist is unsupported in WK1	169	# Datalist is unsupported in WK1
174	fast/forms/datalist [ WontFix ]	170	fast/forms/datalist [ WontFix ]
175	imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]	171	imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]

Lines 1-3 a/Source/WebKit/ChangeLog_sec1
- a/Source/WebKit/ChangeLog +13 lines
		1	2019-01-07 Dean Jackson <dino@apple.com>
		2
		3	Turn on Pointer Events by default for iOS
		4	https://bugs.webkit.org/show_bug.cgi?id=193214
		5	<rdar://problem/46974878>
		6
		7	Reviewed by NOBODY (OOPS!).
		8
		9	Turn on Pointer Events.
		10
		11	* Shared/WebPreferences.yaml:
		12	* Shared/WebPreferencesDefaultValues.h: Make a new #define for iOS.
		13
1	2019-01-07 Antti Koivisto <antti@apple.com>	14	2019-01-07 Antti Koivisto <antti@apple.com>
2		15
3	UI process side scrollbars for UI side compositing on Mac	16	UI process side scrollbars for UI side compositing on Mac

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +15 lines
		1	2019-01-07 Dean Jackson <dino@apple.com>
		2
		3	Turn on Pointer Events by default for iOS
		4	https://bugs.webkit.org/show_bug.cgi?id=193214
		5	<rdar://problem/46974878>
		6
		7	Reviewed by NOBODY (OOPS!).
		8
		9	Skip the pointer events tests everywhere but iOS.
		10
		11	* TestExpectations:
		12	* platform/ios-wk1/TestExpectations:
		13	* platform/ios-wk2/TestExpectations:
		14	* platform/mac-wk1/TestExpectations:
		15
1	2019-01-07 Wenson Hsieh <wenson_hsieh@apple.com>	16	2019-01-07 Wenson Hsieh <wenson_hsieh@apple.com>
2		17
3	Native caret shows up alongside the page's caret when requesting desktop site on jsfiddle.net	18	Native caret shows up alongside the page's caret when requesting desktop site on jsfiddle.net

Lines 1-3 a/LayoutTests/imported/w3c/ChangeLog_sec1
- a/LayoutTests/imported/w3c/ChangeLog +14 lines
		1	2019-01-07 Dean Jackson <dino@apple.com>
		2
		3	Turn on Pointer Events by default for iOS
		4	https://bugs.webkit.org/show_bug.cgi?id=193214
		5	<rdar://problem/46974878>
		6
		7	Reviewed by NOBODY (OOPS!).
		8
		9	Update expected results.
		10
		11	* web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt:
		12	* web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt:
		13	* web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt:
		14
1	2019-01-05 Youenn Fablet <youenn@apple.com>	15	2019-01-05 Youenn Fablet <youenn@apple.com>
2		16
3	Service Worker fetch should obey its referrer policy	17	Service Worker fetch should obey its referrer policy

Lines 5-33 Test Description: Test will automatically check parsing behaviour of various tou a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt_sec1
- a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt -25 / +25 lines
5	touch-action: basic verification	5	touch-action: basic verification
6		6
7		7
8	FAIL default assert_equals: expected (undefined) undefined but got (string) "auto"	8	PASS default
9	FAIL stylesheet-none assert_equals: expected (undefined) undefined but got (string) "none"	9	FAIL stylesheet-none assert_equals: expected "auto" but got "none"
10	FAIL explicit-auto assert_equals: expected (undefined) undefined but got (string) "auto"	10	PASS explicit-auto
11	FAIL explicit-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x"	11	FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x"
12	FAIL explicit-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-y"	12	FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y"
13	FAIL explicit-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"	13	FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y"
14	FAIL explicit-pan-y-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"	14	FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y"
15	FAIL explicit-manipulation assert_equals: expected (undefined) undefined but got (string) "manipulation"	15	PASS explicit-manipulation
16	FAIL explicit-none assert_equals: expected (undefined) undefined but got (string) "none"	16	FAIL explicit-none assert_equals: expected "auto" but got "none"
17	FAIL explicit-invalid-1 assert_equals: expected (undefined) undefined but got (string) "auto"	17	PASS explicit-invalid-1
18	FAIL explicit-invalid-2 assert_equals: expected (undefined) undefined but got (string) "none"	18	FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none"
19	FAIL explicit-invalid-3 assert_equals: expected (undefined) undefined but got (string) "auto"	19	PASS explicit-invalid-3
20	FAIL explicit-invalid-4 assert_equals: expected (undefined) undefined but got (string) "auto"	20	PASS explicit-invalid-4
21	FAIL explicit-invalid-5 assert_equals: expected (undefined) undefined but got (string) "auto"	21	PASS explicit-invalid-5
22	FAIL explicit-invalid-6 assert_equals: expected (undefined) undefined but got (string) "auto"	22	PASS explicit-invalid-6
23	FAIL explicit-invalid-7 assert_equals: expected (undefined) undefined but got (string) "auto"	23	PASS explicit-invalid-7
24	FAIL explicit-invalid-8 assert_equals: expected (undefined) undefined but got (string) "auto"	24	PASS explicit-invalid-8
25	FAIL explicit-invalid-9 assert_equals: expected (undefined) undefined but got (string) "auto"	25	PASS explicit-invalid-9
26	FAIL explicit-invalid-10 assert_equals: expected (undefined) undefined but got (string) "auto"	26	PASS explicit-invalid-10
27	FAIL explicit-invalid-11 assert_equals: expected (undefined) undefined but got (string) "auto"	27	PASS explicit-invalid-11
28	FAIL explicit-invalid-12 assert_equals: expected (undefined) undefined but got (string) "auto"	28	PASS explicit-invalid-12
29	FAIL explicit-invalid-13 assert_equals: expected (undefined) undefined but got (string) "auto"	29	PASS explicit-invalid-13
30	FAIL not-inherited assert_equals: expected (undefined) undefined but got (string) "auto"	30	PASS not-inherited
31	FAIL inherit assert_equals: expected (undefined) undefined but got (string) "none"	31	FAIL inherit assert_equals: expected "auto" but got "none"
32	FAIL initial assert_equals: expected (undefined) undefined but got (string) "auto"	32	PASS initial
33		33

Lines 23-32 webrtc [ Skip ] a/LayoutTests/platform/ios-wk1/TestExpectations_sec1
- a/LayoutTests/platform/ios-wk1/TestExpectations -4 lines
23	# Not supported on WK1	23	# Not supported on WK1
24	media/no-fullscreen-when-hidden.html [ Skip ]	24	media/no-fullscreen-when-hidden.html [ Skip ]
25		25
26	# Skip pointerevents on WK1
27	pointerevents [ Skip ]
28	imported/w3c/web-platform-tests/pointerevents [ Skip ]
29
30	# Datalist is unsupported in WK1	26	# Datalist is unsupported in WK1
31	fast/forms/datalist [ WontFix ]	27	fast/forms/datalist [ WontFix ]
32	imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]	28	imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]