Attachment #341061 for bug #185899

View Details Raw Unified Return to Bug 185899



2018-05-22  Myles C. Maxfield  <mmaxfield@apple.com>

        Text can wrap between hyphens and commas
        https://bugs.webkit.org/show_bug.cgi?id=185899
        <rdar://problem/40118983>

        Reviewed by NOBODY (OOPS!).

        Chrome, Firefox, and ICU all agree that text shouldn't wrap there.

        Test: fast/text/line-break-hyphen-comma.html

        * rendering/BreakLines.cpp:

2018-05-22  Dean Jackson  <dino@apple.com>

        Optimized path zoom animation needs a valid UIImage and CGRect

Lines 64-70 WEBCORE_EXPORT const unsigned char lineBreakTable[][lineBreakTableColumnCount] = a/Source/WebCore/rendering/BreakLines.cpp_sec1
- a/Source/WebCore/rendering/BreakLines.cpp -1 / +1 lines
64	{ B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // *	64	{ B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // *
65	{ B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // +	65	{ B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // +
66	{ B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // ,	66	{ B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // ,
67	{ B(1, 1, 1, 1, 1, 1, 1, 1), B(1, 1, 1, 1, 1, 0, 1, 0), 0, B(0, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1) }, // - Note: breaking before '0'-'9' is handled hard-coded in shouldBreakAfter().	67	{ B(1, 1, 1, 1, 1, 1, 1, 1), B(1, 1, 1, 0, 1, 0, 1, 0), 0, B(0, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1) }, // - Note: breaking before '0'-'9' is handled hard-coded in shouldBreakAfter().
68	{ B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // .	68	{ B(0, 0, 0, 0, 0, 0, 0, 1), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 1, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 1, 0, 0, 0, 0, 0) }, // .
69	{ B(0, 0, 0, 0, 0, 0, 0, 0), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 0, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 0, 0, 0, 0, 0, 0) }, // /	69	{ B(0, 0, 0, 0, 0, 0, 0, 0), B(0, 0, 0, 0, 0, 0, 0, 0), 0, B(0, 0, 0, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 0, 0, 0, 0, 0, 0), 0, 0, 0, B(0, 0, 0, 0, 0, 0, 0, 0) }, // /
70	DI, DI, DI, DI, DI, DI, DI, DI, DI, DI, // 0-9	70	DI, DI, DI, DI, DI, DI, DI, DI, DI, DI, // 0-9



2018-05-22  Myles C. Maxfield  <mmaxfield@apple.com>

        Text can wrap between hyphens and commas
        https://bugs.webkit.org/show_bug.cgi?id=185899
        <rdar://problem/40118983>

        Reviewed by NOBODY (OOPS!).

        * fast/text/line-break-hyphen-comma-expected.html: Added.
        * fast/text/line-break-hyphen-comma.html: Added.

2018-05-22  David Fenton  <david_fenton@apple.com>

        Update test expectations for newly imported css-text layout tests



<!DOCTYPE html>
<html>
<head>
</head>
<body>
This test makes sure that there is no line break allowed between a hyphen and a comma. The test passes if there is no line break below.
<div style="font: 100px monospace;">-,</div>
</body>
</html>



<!DOCTYPE html>
<html>
<head>
</head>
<body>
This test makes sure that there is no line break allowed between a hyphen and a comma. The test passes if there is no line break below.
<div style="width: 80px; font: 100px monospace;">-,</div>
</body>
</html>

Return to Bug 185899

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +14 lines
		1	2018-05-22 Myles C. Maxfield <mmaxfield@apple.com>
		2
		3	Text can wrap between hyphens and commas
		4	https://bugs.webkit.org/show_bug.cgi?id=185899
		5	<rdar://problem/40118983>
		6
		7	Reviewed by NOBODY (OOPS!).
		8
		9	Chrome, Firefox, and ICU all agree that text shouldn't wrap there.
		10
		11	Test: fast/text/line-break-hyphen-comma.html
		12
		13	* rendering/BreakLines.cpp:
		14
1	2018-05-22 Dean Jackson <dino@apple.com>	15	2018-05-22 Dean Jackson <dino@apple.com>
2		16
3	Optimized path zoom animation needs a valid UIImage and CGRect	17	Optimized path zoom animation needs a valid UIImage and CGRect

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +11 lines
		1	2018-05-22 Myles C. Maxfield <mmaxfield@apple.com>
		2
		3	Text can wrap between hyphens and commas
		4	https://bugs.webkit.org/show_bug.cgi?id=185899
		5	<rdar://problem/40118983>
		6
		7	Reviewed by NOBODY (OOPS!).
		8
		9	* fast/text/line-break-hyphen-comma-expected.html: Added.
		10	* fast/text/line-break-hyphen-comma.html: Added.
		11
1	2018-05-22 David Fenton <david_fenton@apple.com>	12	2018-05-22 David Fenton <david_fenton@apple.com>
2		13
3	Update test expectations for newly imported css-text layout tests	14	Update test expectations for newly imported css-text layout tests

Line 0 a/LayoutTests/fast/text/line-break-hyphen-comma-expected.html_sec1
- a/LayoutTests/fast/text/line-break-hyphen-comma-expected.html +9 lines
	1	<!DOCTYPE html>
	2	<html>
	3	<head>
	4	</head>
	5	<body>
	6	This test makes sure that there is no line break allowed between a hyphen and a comma. The test passes if there is no line break below.
	7	<div style="font: 100px monospace;">-,</div>
	8	</body>
	9	</html>