Attachment #320245 for bug #176585

View Details Raw Unified Return to Bug 176585

| Differences between



2017-09-07  Frederic Wang  <fwang@igalia.com>

        Use RenderLayerBacking::renderer() when possible
        https://bugs.webkit.org/show_bug.cgi?id=176585

        The private member renderer() is a shorthand for m_owningLayer.renderer(). This patch uses
        it in RenderLayerBacking when possible.

        Reviewed by NOBODY (OOPS!).

        No new tests, behavior not changed.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGeometry):
        (WebCore::RenderLayerBacking::setContentsNeedDisplay):
        (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

2017-09-07  Wenson Hsieh  <wenson_hsieh@apple.com>

        [Directory Upload] Extend drag and drop support to iOS



    if (m_maskLayer)
        updateMaskingLayerGeometry();
    
    if (renderer().hasTransformRelatedProperty()) {
        // Update properties that depend on layer dimensions.
        FloatPoint3D transformOrigin = computeTransformOriginForPainting(downcast<RenderBox>(renderer()).borderBoxRect());
        FloatPoint layerOffset = roundPointToDevicePixels(toLayoutPoint(rendererOffset.fromParentGraphicsLayer()), deviceScaleFactor());

{
    ASSERT(!paintsIntoCompositedAncestor());

    FrameView& frameView = renderer().view().frameView();
    if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())
        frameView.addTrackedRepaintRect(owningLayer().absoluteBoundingBoxForPainting());
    

    ASSERT(!paintsIntoCompositedAncestor());

    FloatRect pixelSnappedRectForPainting = snapRectToDevicePixels(r, deviceScaleFactor());
    FrameView& frameView = renderer().view().frameView();
    if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())
        frameView.addTrackedRepaintRect(pixelSnappedRectForPainting);


Return to Bug 176585

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +17 lines
		1	2017-09-07 Frederic Wang <fwang@igalia.com>
		2
		3	Use RenderLayerBacking::renderer() when possible
		4	https://bugs.webkit.org/show_bug.cgi?id=176585
		5
		6	The private member renderer() is a shorthand for m_owningLayer.renderer(). This patch uses
		7	it in RenderLayerBacking when possible.
		8
		9	Reviewed by NOBODY (OOPS!).
		10
		11	No new tests, behavior not changed.
		12
		13	* rendering/RenderLayerBacking.cpp:
		14	(WebCore::RenderLayerBacking::updateGeometry):
		15	(WebCore::RenderLayerBacking::setContentsNeedDisplay):
		16	(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
		17
1	2017-09-07 Wenson Hsieh <wenson_hsieh@apple.com>	18	2017-09-07 Wenson Hsieh <wenson_hsieh@apple.com>
2		19
3	[Directory Upload] Extend drag and drop support to iOS	20	[Directory Upload] Extend drag and drop support to iOS

Lines 1052-1058 void RenderLayerBacking::updateGeometry() a/Source/WebCore/rendering/RenderLayerBacking.cpp_sec1
- a/Source/WebCore/rendering/RenderLayerBacking.cpp -3 / +3 lines
1052	if (m_maskLayer)	1052	if (m_maskLayer)
1053	updateMaskingLayerGeometry();	1053	updateMaskingLayerGeometry();
1054		1054
1055	if (m_owningLayer.renderer().hasTransformRelatedProperty()) {	1055	if (renderer().hasTransformRelatedProperty()) {
1056	// Update properties that depend on layer dimensions.	1056	// Update properties that depend on layer dimensions.
1057	FloatPoint3D transformOrigin = computeTransformOriginForPainting(downcast<RenderBox>(renderer()).borderBoxRect());	1057	FloatPoint3D transformOrigin = computeTransformOriginForPainting(downcast<RenderBox>(renderer()).borderBoxRect());
1058	FloatPoint layerOffset = roundPointToDevicePixels(toLayoutPoint(rendererOffset.fromParentGraphicsLayer()), deviceScaleFactor());	1058	FloatPoint layerOffset = roundPointToDevicePixels(toLayoutPoint(rendererOffset.fromParentGraphicsLayer()), deviceScaleFactor());
Lines 2433-2439 void RenderLayerBacking::setContentsNeedDisplay(GraphicsLayer::ShouldClipToLayer a/Source/WebCore/rendering/RenderLayerBacking.cpp_sec2
2433	{	2433	{
2434	ASSERT(!paintsIntoCompositedAncestor());	2434	ASSERT(!paintsIntoCompositedAncestor());
2435		2435
2436	FrameView& frameView = owningLayer().renderer().view().frameView();	2436	FrameView& frameView = renderer().view().frameView();
2437	if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())	2437	if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())
2438	frameView.addTrackedRepaintRect(owningLayer().absoluteBoundingBoxForPainting());	2438	frameView.addTrackedRepaintRect(owningLayer().absoluteBoundingBoxForPainting());
2439		2439
Lines 2468-2474 void RenderLayerBacking::setContentsNeedDisplayInRect(const LayoutRect& r, Graph a/Source/WebCore/rendering/RenderLayerBacking.cpp_sec3
2468	ASSERT(!paintsIntoCompositedAncestor());	2468	ASSERT(!paintsIntoCompositedAncestor());
2469		2469
2470	FloatRect pixelSnappedRectForPainting = snapRectToDevicePixels(r, deviceScaleFactor());	2470	FloatRect pixelSnappedRectForPainting = snapRectToDevicePixels(r, deviceScaleFactor());
2471	FrameView& frameView = owningLayer().renderer().view().frameView();	2471	FrameView& frameView = renderer().view().frameView();
2472	if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())	2472	if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())
2473	frameView.addTrackedRepaintRect(pixelSnappedRectForPainting);	2473	frameView.addTrackedRepaintRect(pixelSnappedRectForPainting);
2474		2474