Attachment #316889 for bug #175043

View Details Raw Unified Return to Bug 175043



2017-08-01  obinna obike  <oobike@apple.com>

        Unsorted EWS on patch page
        https://bugs.webkit.org/show_bug.cgi?id=175043

        Reviewed by NOBODY (OOPS!).

        * QueueStatusServer/handlers/patch.py:
        (Patch.get):
        * QueueStatusServer/templates/patch.html:

2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>

        Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future

Lines 44-50 class Patch(webapp.RequestHandler): Tools/QueueStatusServer/handlers/patch.py_sec1
- Tools/QueueStatusServer/handlers/patch.py -1 / +1 lines
44	per_queue_statuses = queue_status.get(status.queue_name, [])	44	per_queue_statuses = queue_status.get(status.queue_name, [])
45	per_queue_statuses.append(status)	45	per_queue_statuses.append(status)
46	queue_status[status.queue_name] = per_queue_statuses	46	queue_status[status.queue_name] = per_queue_statuses
47		47	queue_status = sorted(queue_status.items())
48	template_values = {	48	template_values = {
49	"attachment_id" : attachment_id,	49	"attachment_id" : attachment_id,
50	"bug_id" : bug_id,	50	"bug_id" : bug_id,

Lines 7-13 Tools/QueueStatusServer/templates/patch.html_sec1
- Tools/QueueStatusServer/templates/patch.html -1 / +1 lines
7	<body>	7	<body>
8	<h1>	8	<h1>
9	Patch {{ attachment_id\|force_escape\|webkit_attachment_id\|safe }} (Bug {{ bug_id\|force_escape\|webkit_bug_id\|safe }})	9	Patch {{ attachment_id\|force_escape\|webkit_attachment_id\|safe }} (Bug {{ bug_id\|force_escape\|webkit_bug_id\|safe }})
10	</h1>{% for queue_name, statuses in queue_status.items %}	10	</h1>{% for queue_name, statuses in queue_status %}
11	<div class="status-details">	11	<div class="status-details">
12	<h2>{{ queue_name }}</h2>	12	<h2>{{ queue_name }}</h2>
13	<ul>{% for status in statuses %}	13	<ul>{% for status in statuses %}

Return to Bug 175043

Lines 1-3 Tools/ChangeLog_sec1
- Tools/ChangeLog +11 lines
		1	2017-08-01 obinna obike <oobike@apple.com>
		2
		3	Unsorted EWS on patch page
		4	https://bugs.webkit.org/show_bug.cgi?id=175043
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* QueueStatusServer/handlers/patch.py:
		9	(Patch.get):
		10	* QueueStatusServer/templates/patch.html:
		11
1	2017-07-26 Jiewen Tan <jiewen_tan@apple.com>	12	2017-07-26 Jiewen Tan <jiewen_tan@apple.com>
2		13
3	Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future	14	Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future