Attachment #308615 for bug #171463

View Details Raw Unified Return to Bug 171463



2017-04-28  Aakash Jain  <aakash_jain@apple.com>

        EWS QueueServer shouldn't fail to release patch if last_status is None
        https://bugs.webkit.org/show_bug.cgi?id=171463

        Reviewed by NOBODY (OOPS!).

        * QueueStatusServer/handlers/releasepatch.py:
        (ReleasePatch.post): Access last_status.message only if last_status is not None.

2017-04-28  Jonathan Bedard  <jbedard@apple.com>

        Unreviewed follow-up to r214705.

Lines 50-60 class ReleasePatch(UpdateBase): Tools/QueueStatusServer/handlers/releasepatch.py_sec1
- Tools/QueueStatusServer/handlers/releasepatch.py -1 / +4 lines
50	attachment_id = self._int_from_request("attachment_id")	50	attachment_id = self._int_from_request("attachment_id")
51	attachment = Attachment(attachment_id)	51	attachment = Attachment(attachment_id)
52	last_status = attachment.status_for_queue(queue)	52	last_status = attachment.status_for_queue(queue)
		53	message = ""
		54	if last_status:
		55	message = last_status.message
53		56
54	# Ideally we should use a transaction for the calls to	57	# Ideally we should use a transaction for the calls to
55	# WorkItems and ActiveWorkItems.	58	# WorkItems and ActiveWorkItems.
56		59
57	queue.work_items().remove_work_item(attachment_id)	60	queue.work_items().remove_work_item(attachment_id)
58	RecordPatchEvent.stopped(attachment_id, queue_name, last_status.message)	61	RecordPatchEvent.stopped(attachment_id, queue_name, message)
59		62
60	queue.active_work_items().expire_item(attachment_id)	63	queue.active_work_items().expire_item(attachment_id)

Return to Bug 171463

Lines 1-3 Tools/ChangeLog_sec1
- Tools/ChangeLog +10 lines
		1	2017-04-28 Aakash Jain <aakash_jain@apple.com>
		2
		3	EWS QueueServer shouldn't fail to release patch if last_status is None
		4	https://bugs.webkit.org/show_bug.cgi?id=171463
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* QueueStatusServer/handlers/releasepatch.py:
		9	(ReleasePatch.post): Access last_status.message only if last_status is not None.
		10
1	2017-04-28 Jonathan Bedard <jbedard@apple.com>	11	2017-04-28 Jonathan Bedard <jbedard@apple.com>
2		12
3	Unreviewed follow-up to r214705.	13	Unreviewed follow-up to r214705.