View Details Raw Unified Return to Bug 161119
| Differences between
and this patch
Collapse All Expand All
- a/Source/WebCore/ChangeLog +12 lines
Lines 1-3 a/Source/WebCore/ChangeLog_sec1
1 
2016-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2 

            

            

              3
              
        [Cocoa] Improve performance of glyph advance metrics gathering

            

            

              4
              
        https://bugs.webkit.org/show_bug.cgi?id=161119

            

            

              5
              

            

            

              6
              
        Reviewed by NOBODY (OOPS!).

            

            

              7
              

            

            

              8
              
        No new tests (OOPS!).

            

            

              9
              

            

            

              10
              
        * platform/graphics/cocoa/FontCocoa.mm:

            

            

              11
              
        (WebCore::Font::platformWidthForGlyph):

            

            

              12
              

            

        

          1
          
2016-09-06  Commit Queue  <commit-queue@webkit.org>

          13
          
2016-09-06  Commit Queue  <commit-queue@webkit.org>

        

        

          2
          

          14
          

        

        

          3
          
        Unreviewed, rolling out r205521, r205526, and r205532.

          15
          
        Unreviewed, rolling out r205521, r205526, and r205532.

        



-
  a/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm
    
      +7 lines
    




  

    
      
            Lines 635-640
      
      float Font::platformWidthForGlyph(Glyph glyph) const
      
        a/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm_sec1
      
    
  

        

          635
          
    } else if (!populatedAdvance && platformData().size())

          635
          
    } else if (!populatedAdvance && platformData().size())

        

        

          636
          
        CTFontGetAdvancesForGlyphs(m_platformData.ctFont(), horizontal ? kCTFontOrientationHorizontal : kCTFontOrientationVertical, &glyph, &advance, 1);

          636
          
        CTFontGetAdvancesForGlyphs(m_platformData.ctFont(), horizontal ? kCTFontOrientationHorizontal : kCTFontOrientationVertical, &glyph, &advance, 1);

        

        

          637
          

          637
          

        

            

              
              
              638
              
    {

            

            

              639
              
        CGSize advance2 = CGSizeZero;

            

            

              640
              
        if (platformData().size())

            

            

              641
              
            CTFontGetAdvancesForGlyphs(m_platformData.ctFont(), horizontal || m_isBrokenIdeographFallback ? kCTFontOrientationHorizontal : kCTFontOrientationVertical, &glyph, &advance2, 1);

            

            

              642
              
        ASSERT(std::abs(advance2.width - advance.width) < 0.0001);

            

            

              643
              
    }

            

            

              644
              

            

        

          638
          
    return advance.width + m_syntheticBoldOffset;

          645
          
    return advance.width + m_syntheticBoldOffset;

        

        

          639
          
}

          646
          
}

        

        

          640
          

          647
          

        






  

  Return to Bug 161119