Attachment #267779 for bug #152471

View Details Raw Unified Return to Bug 152471

| Differences between



2015-12-21  Nikita Vasilyev  <nvasilyev@apple.com>

        WebInspector: Can't open a new tab: Uncaught Exception: TypeError: this.isNewTabWithTypeAllowed is not a function
        https://bugs.webkit.org/show_bug.cgi?id=152471

        Reviewed by Timothy Hatcher.

        * UserInterface/Base/Main.js:
        (WebInspector._updateNewTabButtonState):
        Don't use arrow functions because of https://webkit.org/b/152497 "Arrow functions: 'this' isn't lexically bound"

2015-12-21  Nikita Vasilyev  <nvasilyev@apple.com>

        Web Inspector: Remove unused WebInspector.Object.removeAllListeners
        https://bugs.webkit.org/show_bug.cgi?id=152474


Lines 490-496 WebInspector._updateNewTabButtonState = function(event) a/Source/WebInspectorUI/UserInterface/Base/Main.js_sec1
- a/Source/WebInspectorUI/UserInterface/Base/Main.js -1 / +5 lines
490	{	490	{
491	let allTabs = [...this._knownTabClassesByType.values()];	491	let allTabs = [...this._knownTabClassesByType.values()];
492	let addableTabs = allTabs.filter((tabClass) => !tabClass.isEphemeral());	492	let addableTabs = allTabs.filter((tabClass) => !tabClass.isEphemeral());
493	let canMakeNewTab = addableTabs.some((tabClass) => this.isNewTabWithTypeAllowed(tabClass.Type));	493
		494	// FIXME: Use arrow functions once http://webkit.org/b/152497 is resolved.
		495	let canMakeNewTab = addableTabs.some(function(tabClass) {
		496	return this.isNewTabWithTypeAllowed(tabClass.Type);
		497	}.bind(this));
494	this.tabBar.newTabItem.disabled = !canMakeNewTab;	498	this.tabBar.newTabItem.disabled = !canMakeNewTab;
495	};	499	};
496		500

Return to Bug 152471

Lines 1-5 a/Source/WebInspectorUI/ChangeLog_sec1
- a/Source/WebInspectorUI/ChangeLog +11 lines
1	2015-12-21 Nikita Vasilyev <nvasilyev@apple.com>	1	2015-12-21 Nikita Vasilyev <nvasilyev@apple.com>
2		2
		3	WebInspector: Can't open a new tab: Uncaught Exception: TypeError: this.isNewTabWithTypeAllowed is not a function
		4	https://bugs.webkit.org/show_bug.cgi?id=152471
		5
		6	Reviewed by Timothy Hatcher.
		7
		8	* UserInterface/Base/Main.js:
		9	(WebInspector._updateNewTabButtonState):
		10	Don't use arrow functions because of https://webkit.org/b/152497 "Arrow functions: 'this' isn't lexically bound"
		11
		12	2015-12-21 Nikita Vasilyev <nvasilyev@apple.com>
		13
3	Web Inspector: Remove unused WebInspector.Object.removeAllListeners	14	Web Inspector: Remove unused WebInspector.Object.removeAllListeners
4	https://bugs.webkit.org/show_bug.cgi?id=152474	15	https://bugs.webkit.org/show_bug.cgi?id=152474
5		16