View Details Raw Unified Return to Bug 152471
| Differences between
and this patch
Collapse All Expand All
- a/Source/WebInspectorUI/ChangeLog +11 lines
Lines 1-3 a/Source/WebInspectorUI/ChangeLog_sec1
1 
2015-12-20  Nikita Vasilyev  <nvasilyev@apple.com>
2 

            

            

              3
              
        WebInspector: Can't open a new tab: Uncaught Exception: TypeError: this.isNewTabWithTypeAllowed is not a function

            

            

              4
              
        https://bugs.webkit.org/show_bug.cgi?id=152471

            

            

              5
              

            

            

              6
              
        Reviewed by NOBODY (OOPS!).

            

            

              7
              

            

            

              8
              
        * UserInterface/Base/Main.js:

            

            

              9
              
        (WebInspector._updateNewTabButtonState):

            

            

              10
              
        Use `WebInspector` instead of `this` to make work in every context.

            

            

              11
              

            

        

          1
          
2015-12-19  Dan Bernstein  <mitz@apple.com>

          12
          
2015-12-19  Dan Bernstein  <mitz@apple.com>

        

        

          2
          

          13
          

        

        

          3
          
        [Mac] WebKit contains dead source code for OS X Mavericks and earlier

          14
          
        [Mac] WebKit contains dead source code for OS X Mavericks and earlier

        



-
  a/Source/WebInspectorUI/UserInterface/Base/Main.js
    
      -1 / +1 lines
    




  

    
      
            Lines 491-497
      
      WebInspector._updateNewTabButtonState = function(event)
      
        a/Source/WebInspectorUI/UserInterface/Base/Main.js_sec1
      
    
  

        

          491
          
{

          491
          
{

        

        

          492
          
    let allTabs = [...this._knownTabClassesByType.values()];

          492
          
    let allTabs = [...this._knownTabClassesByType.values()];

        

        

          493
          
    let addableTabs = allTabs.filter((tabClass) => !tabClass.isEphemeral());

          493
          
    let addableTabs = allTabs.filter((tabClass) => !tabClass.isEphemeral());

        

          
            

              494
              
    let canMakeNewTab = addableTabs.some((tabClass) => this.isNewTabWithTypeAllowed(tabClass.Type));


              494
              
    let canMakeNewTab = addableTabs.some((tabClass) => WebInspector.isNewTabWithTypeAllowed(tabClass.Type));

            

        

          495
          
    this.tabBar.newTabItem.disabled = !canMakeNewTab;

          495
          
    this.tabBar.newTabItem.disabled = !canMakeNewTab;

        

        

          496
          
};

          496
          
};

        

        

          497
          

          497
          

        






  

  Return to Bug 152471